From: Rob Herring <robh@kernel.org>
To: Srinath Mannam <srinath.mannam@broadcom.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>, Ray Jui <rjui@broadcom.com>,
linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] PCI: iproc: Display PCIe Link information
Date: Wed, 16 Sep 2020 19:52:45 -0600 [thread overview]
Message-ID: <20200917015245.GA678675@bogus> (raw)
In-Reply-To: <20200915134541.14711-4-srinath.mannam@broadcom.com>
On Tue, Sep 15, 2020 at 07:15:41PM +0530, Srinath Mannam wrote:
> After successful linkup more comprehensive information about PCIe link
> speed and link width will be displayed to the console.
>
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> ---
> drivers/pci/controller/pcie-iproc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index cc5b7823edeb..8ef2d1fe392c 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -1479,6 +1479,7 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res)
> {
> struct device *dev;
> int ret;
> + struct pci_dev *pdev;
> struct pci_host_bridge *host = pci_host_bridge_from_priv(pcie);
>
> dev = pcie->dev;
> @@ -1542,6 +1543,11 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res)
> goto err_power_off_phy;
> }
>
> + for_each_pci_bridge(pdev, host->bus) {
> + if (pci_pcie_type(pdev) == PCI_EXP_TYPE_ROOT_PORT)
> + pcie_print_link_status(pdev);
> + }
If this information is useful for 1 host implementation, why not all of
them and put this in a common spot.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Srinath Mannam <srinath.mannam@broadcom.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] PCI: iproc: Display PCIe Link information
Date: Wed, 16 Sep 2020 19:52:45 -0600 [thread overview]
Message-ID: <20200917015245.GA678675@bogus> (raw)
In-Reply-To: <20200915134541.14711-4-srinath.mannam@broadcom.com>
On Tue, Sep 15, 2020 at 07:15:41PM +0530, Srinath Mannam wrote:
> After successful linkup more comprehensive information about PCIe link
> speed and link width will be displayed to the console.
>
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> ---
> drivers/pci/controller/pcie-iproc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index cc5b7823edeb..8ef2d1fe392c 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -1479,6 +1479,7 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res)
> {
> struct device *dev;
> int ret;
> + struct pci_dev *pdev;
> struct pci_host_bridge *host = pci_host_bridge_from_priv(pcie);
>
> dev = pcie->dev;
> @@ -1542,6 +1543,11 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res)
> goto err_power_off_phy;
> }
>
> + for_each_pci_bridge(pdev, host->bus) {
> + if (pci_pcie_type(pdev) == PCI_EXP_TYPE_ROOT_PORT)
> + pcie_print_link_status(pdev);
> + }
If this information is useful for 1 host implementation, why not all of
them and put this in a common spot.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-17 1:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 13:45 [PATCH v2 0/3] PCI: iproc: Add fixes to pcie iproc Srinath Mannam
2020-09-15 13:45 ` Srinath Mannam
2020-09-15 13:45 ` [PATCH v2 1/3] PCI: iproc: fix out of bound array access Srinath Mannam
2020-09-15 13:45 ` Srinath Mannam
2020-09-15 13:45 ` [PATCH v2 2/3] PCI: iproc: fix invalidating PAXB address mapping Srinath Mannam
2020-09-15 13:45 ` Srinath Mannam
2020-09-15 13:45 ` [PATCH v2 3/3] PCI: iproc: Display PCIe Link information Srinath Mannam
2020-09-15 13:45 ` Srinath Mannam
2020-09-17 1:52 ` Rob Herring [this message]
2020-09-17 1:52 ` Rob Herring
2020-09-17 3:12 ` Srinath Mannam
2020-09-17 3:12 ` Srinath Mannam
2020-09-16 22:08 ` [PATCH v2 0/3] PCI: iproc: Add fixes to pcie iproc Bjorn Helgaas
2020-09-16 22:08 ` Bjorn Helgaas
2020-09-17 2:44 ` Srinath Mannam
2020-09-17 2:44 ` Srinath Mannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917015245.GA678675@bogus \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjui@broadcom.com \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.