From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: syzbot <syzbot+0eac6f0bbd558fd866d7@syzkaller.appspotmail.com>,
syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, glider@google.com,
jaegeuk@kernel.org
Subject: Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup
Date: Fri, 25 Sep 2020 09:45:38 -0700 [thread overview]
Message-ID: <20200925164538.GB3315208@gmail.com> (raw)
In-Reply-To: <20200925163819.GA3315208@gmail.com>
On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote:
> On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote:
> > Hi,
> >
> > I don't see any problem here, thanks for your report. :)
> >
> > Thanks,
>
> What about if max_depth == 0 in __f2fs_find_entry()? Then __f2fs_find_entry()
> would return NULL without initializing *res_page.
... and I now see Dan Carpenter already pointed this out. I was a bit late!
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: syzbot <syzbot+0eac6f0bbd558fd866d7@syzkaller.appspotmail.com>,
chao@kernel.org, glider@google.com, jaegeuk@kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup
Date: Fri, 25 Sep 2020 09:45:38 -0700 [thread overview]
Message-ID: <20200925164538.GB3315208@gmail.com> (raw)
In-Reply-To: <20200925163819.GA3315208@gmail.com>
On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote:
> On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote:
> > Hi,
> >
> > I don't see any problem here, thanks for your report. :)
> >
> > Thanks,
>
> What about if max_depth == 0 in __f2fs_find_entry()? Then __f2fs_find_entry()
> would return NULL without initializing *res_page.
... and I now see Dan Carpenter already pointed this out. I was a bit late!
- Eric
next prev parent reply other threads:[~2020-09-25 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 5:18 [f2fs-dev] KMSAN: uninit-value in f2fs_lookup syzbot
2020-09-25 5:18 ` syzbot
2020-09-25 9:06 ` [f2fs-dev] " Chao Yu
2020-09-25 9:06 ` Chao Yu
2020-09-25 10:57 ` Dan Carpenter
2020-09-25 10:57 ` Dan Carpenter
2020-09-25 15:01 ` Chao Yu
2020-09-25 15:01 ` Chao Yu
2020-09-25 16:38 ` Eric Biggers
2020-09-25 16:38 ` Eric Biggers
2020-09-25 16:45 ` Eric Biggers [this message]
2020-09-25 16:45 ` Eric Biggers
2020-09-25 23:17 ` Chao Yu
2020-09-25 23:17 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925164538.GB3315208@gmail.com \
--to=ebiggers@kernel.org \
--cc=glider@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+0eac6f0bbd558fd866d7@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.