Re: [RFC][PATCH 2/6] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation

Re: [RFC][PATCH 2/6] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200926042453.67517-3-john.stultz@linaro.org>
References: <20200926042453.67517-3-john.stultz@linaro.org>
TO: John Stultz <john.stultz@linaro.org>

Hi John,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linux/master]
[also build test WARNING on tegra-drm/drm/tegra/for-next linus/master next-20200925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/John-Stultz/dma-buf-Performance-improvements-for-system-heap/20200926-122541
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
config: x86_64-randconfig-c002-20200925 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/dma-buf/heaps/cma_heap.c:203:2-8: preceding lock on line 200
   drivers/dma-buf/heaps/cma_heap.c:208:2-8: preceding lock on line 200
--
>> drivers/dma-buf/heaps/cma_heap.c:119:5-8: Unneeded variable: "ret". Return "0" on line 131

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34164 bytes --]

[PATCH] dma-buf: heaps: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200926042453.67517-3-john.stultz@linaro.org>
References: <20200926042453.67517-3-john.stultz@linaro.org>
TO: John Stultz <john.stultz@linaro.org>

From: kernel test robot <lkp@intel.com>

drivers/dma-buf/heaps/cma_heap.c:119:5-8: Unneeded variable: "ret". Return "0" on line 131


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: John Stultz <john.stultz@linaro.org>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/John-Stultz/dma-buf-Performance-improvements-for-system-heap/20200926-122541
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago

Please take the patch only if it's a positive warning. Thanks!

 cma_heap.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/dma-buf/heaps/cma_heap.c
+++ b/drivers/dma-buf/heaps/cma_heap.c
@@ -116,7 +116,6 @@ static int cma_heap_dma_buf_begin_cpu_ac
 {
 	struct cma_heap_buffer *buffer = dmabuf->priv;
 	struct dma_heap_attachment *a;
-	int ret = 0;
 
 	if (buffer->vmap_cnt)
 		invalidate_kernel_vmap_range(buffer->vaddr, buffer->len);
@@ -128,7 +127,7 @@ static int cma_heap_dma_buf_begin_cpu_ac
 	}
 	mutex_unlock(&buffer->lock);
 
-	return ret;
+	return 0;
 }
 
 static int cma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,

[PATCH] dma-buf: heaps: fix returnvar.cocci warnings

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

From: kernel test robot <lkp@intel.com>

Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: John Stultz <john.stultz@linaro.org>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

url:    https://github.com/0day-ci/linux/commits/John-Stultz/dma-buf-Performance-improvements-for-system-heap/20200926-122541
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago

Minor issue...

 cma_heap.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/dma-buf/heaps/cma_heap.c
+++ b/drivers/dma-buf/heaps/cma_heap.c
@@ -116,7 +116,6 @@ static int cma_heap_dma_buf_begin_cpu_ac
 {
 	struct cma_heap_buffer *buffer = dmabuf->priv;
 	struct dma_heap_attachment *a;
-	int ret = 0;

 	if (buffer->vmap_cnt)
 		invalidate_kernel_vmap_range(buffer->vaddr, buffer->len);
@@ -128,7 +127,7 @@ static int cma_heap_dma_buf_begin_cpu_ac
 	}
 	mutex_unlock(&buffer->lock);

-	return ret;
+	return 0;
 }

 static int cma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,

Re: [PATCH] dma-buf: heaps: fix returnvar.cocci warnings

[John Stultz]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

On Sat, Sep 26, 2020 at 6:47 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> CC: John Stultz <john.stultz@linaro.org>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---

Thanks so much! I've integrated this into my series!
-john