From: Christoph Hellwig <hch@infradead.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs
Date: Tue, 29 Sep 2020 18:46:54 +0100 [thread overview]
Message-ID: <20200929174654.GA773@infradead.org> (raw)
In-Reply-To: <20200928215931.GA2499944@bjorn-Precision-5520>
On Mon, Sep 28, 2020 at 04:59:31PM -0500, Bjorn Helgaas wrote:
> [to: Christoph in case he has comments, since I think he wrote this code]
I think I actually suggested this a few iterations back.
> > + hk_cpus = housekeeping_num_online_cpus(HK_FLAG_MANAGED_IRQ);
> > +
> > + /*
> > + * If we have isolated CPUs for use by real-time tasks, to keep the
> > + * latency overhead to a minimum, device-specific IRQ vectors are moved
> > + * to the housekeeping CPUs from the userspace by changing their
> > + * affinity mask. Limit the vector usage to keep housekeeping CPUs from
> > + * running out of IRQ vectors.
> > + */
> > + if (hk_cpus < num_online_cpus()) {
I woukd have moved the assignment to hk_cpus below the comment and
just above the if, but that is really just a minor style preference.
Otherwise this looks good:
Acked-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Nitesh Narayan Lal <nitesh@redhat.com>,
hch@infradead.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, frederic@kernel.org,
mtosatti@redhat.com, sassmann@redhat.com,
jesse.brandeburg@intel.com, lihong.yang@intel.com,
jeffrey.t.kirsher@intel.com, jacob.e.keller@intel.com,
jlelli@redhat.com, bhelgaas@google.com,
mike.marciniszyn@intel.com, dennis.dalessandro@intel.com,
thomas.lendacky@amd.com, jiri@nvidia.com, mingo@redhat.com,
peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, lgoncalv@redhat.com
Subject: Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs
Date: Tue, 29 Sep 2020 18:46:54 +0100 [thread overview]
Message-ID: <20200929174654.GA773@infradead.org> (raw)
In-Reply-To: <20200928215931.GA2499944@bjorn-Precision-5520>
On Mon, Sep 28, 2020 at 04:59:31PM -0500, Bjorn Helgaas wrote:
> [to: Christoph in case he has comments, since I think he wrote this code]
I think I actually suggested this a few iterations back.
> > + hk_cpus = housekeeping_num_online_cpus(HK_FLAG_MANAGED_IRQ);
> > +
> > + /*
> > + * If we have isolated CPUs for use by real-time tasks, to keep the
> > + * latency overhead to a minimum, device-specific IRQ vectors are moved
> > + * to the housekeeping CPUs from the userspace by changing their
> > + * affinity mask. Limit the vector usage to keep housekeeping CPUs from
> > + * running out of IRQ vectors.
> > + */
> > + if (hk_cpus < num_online_cpus()) {
I woukd have moved the assignment to hk_cpus below the comment and
just above the if, but that is really just a minor style preference.
Otherwise this looks good:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-09-29 17:46 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 18:35 [Intel-wired-lan] [PATCH v4 0/4] isolation: limit msix vectors to housekeeping CPUs Nitesh Narayan Lal
2020-09-28 18:35 ` Nitesh Narayan Lal
2020-09-28 18:35 ` [Intel-wired-lan] [PATCH v4 1/4] sched/isolation: API to get number of " Nitesh Narayan Lal
2020-09-28 18:35 ` Nitesh Narayan Lal
2020-09-28 18:35 ` [Intel-wired-lan] [PATCH v4 2/4] sched/isolation: Extend nohz_full to isolate managed IRQs Nitesh Narayan Lal
2020-09-28 18:35 ` Nitesh Narayan Lal
2020-10-23 13:25 ` [Intel-wired-lan] " Peter Zijlstra
2020-10-23 13:25 ` Peter Zijlstra
2020-10-23 13:29 ` [Intel-wired-lan] " Frederic Weisbecker
2020-10-23 13:29 ` Frederic Weisbecker
2020-10-23 13:57 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-23 13:57 ` Nitesh Narayan Lal
2020-10-23 13:45 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-23 13:45 ` Nitesh Narayan Lal
2020-09-28 18:35 ` [Intel-wired-lan] [PATCH v4 3/4] i40e: Limit msix vectors to housekeeping CPUs Nitesh Narayan Lal
2020-09-28 18:35 ` Nitesh Narayan Lal
2020-09-28 18:35 ` [Intel-wired-lan] [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() " Nitesh Narayan Lal
2020-09-28 18:35 ` Nitesh Narayan Lal
2020-09-28 21:59 ` [Intel-wired-lan] " Bjorn Helgaas
2020-09-28 21:59 ` Bjorn Helgaas
2020-09-29 17:46 ` Christoph Hellwig [this message]
2020-09-29 17:46 ` Christoph Hellwig
2020-10-16 12:20 ` [Intel-wired-lan] " Peter Zijlstra
2020-10-16 12:20 ` Peter Zijlstra
2020-10-18 18:14 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-18 18:14 ` Nitesh Narayan Lal
2020-10-19 11:11 ` [Intel-wired-lan] " Peter Zijlstra
2020-10-19 11:11 ` Peter Zijlstra
2020-10-19 14:00 ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-19 14:00 ` Marcelo Tosatti
2020-10-19 14:25 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-19 14:25 ` Nitesh Narayan Lal
2020-10-20 7:30 ` [Intel-wired-lan] " Peter Zijlstra
2020-10-20 7:30 ` Peter Zijlstra
2020-10-20 13:00 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-20 13:00 ` Nitesh Narayan Lal
2020-10-20 13:41 ` [Intel-wired-lan] " Peter Zijlstra
2020-10-20 13:41 ` Peter Zijlstra
2020-10-20 14:39 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-20 14:39 ` Nitesh Narayan Lal
2020-10-22 17:47 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-22 17:47 ` Nitesh Narayan Lal
2020-10-23 8:58 ` [Intel-wired-lan] " Peter Zijlstra
2020-10-23 8:58 ` Peter Zijlstra
2020-10-23 13:10 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-23 13:10 ` Nitesh Narayan Lal
2020-10-23 21:00 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-23 21:00 ` Thomas Gleixner
2020-10-26 13:35 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-26 13:35 ` Nitesh Narayan Lal
2020-10-26 13:57 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 13:57 ` Thomas Gleixner
2020-10-26 17:30 ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-26 17:30 ` Marcelo Tosatti
2020-10-26 19:00 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 19:00 ` Thomas Gleixner
2020-10-26 19:11 ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-26 19:11 ` Marcelo Tosatti
2020-10-26 19:21 ` [Intel-wired-lan] " Jacob Keller
2020-10-26 19:21 ` Jacob Keller
2020-10-26 20:11 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 20:11 ` Thomas Gleixner
2020-10-26 21:11 ` [Intel-wired-lan] " Jacob Keller
2020-10-26 21:11 ` Jacob Keller
2020-10-26 21:50 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 21:50 ` Thomas Gleixner
2020-10-26 22:13 ` [Intel-wired-lan] " Jakub Kicinski
2020-10-26 22:13 ` Jakub Kicinski
2020-10-26 22:46 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 22:46 ` Thomas Gleixner
2020-10-26 22:52 ` [Intel-wired-lan] " Jacob Keller
2020-10-26 22:52 ` Jacob Keller
2020-10-26 22:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-26 22:22 ` Nitesh Narayan Lal
2020-10-26 22:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 22:49 ` Thomas Gleixner
2020-10-26 23:08 ` [Intel-wired-lan] " Jacob Keller
2020-10-26 23:08 ` Jacob Keller
2020-10-27 14:28 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-27 14:28 ` Thomas Gleixner
2020-10-27 11:47 ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-27 11:47 ` Marcelo Tosatti
2020-10-27 14:43 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-27 14:43 ` Thomas Gleixner
2020-10-19 14:21 ` [Intel-wired-lan] " Frederic Weisbecker
2020-10-19 14:21 ` Frederic Weisbecker
2020-10-20 14:16 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-20 14:16 ` Thomas Gleixner
2020-10-20 16:18 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-20 16:18 ` Nitesh Narayan Lal
2020-10-20 18:07 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-20 18:07 ` Thomas Gleixner
2020-10-21 20:25 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-21 20:25 ` Thomas Gleixner
2020-10-21 21:04 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-21 21:04 ` Nitesh Narayan Lal
2020-10-22 0:02 ` [Intel-wired-lan] " Jakub Kicinski
2020-10-22 0:02 ` Jakub Kicinski
2020-10-22 0:27 ` [Intel-wired-lan] " Jacob Keller
2020-10-22 0:27 ` Jacob Keller
2020-10-22 8:28 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-22 8:28 ` Thomas Gleixner
2020-10-22 12:28 ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-22 12:28 ` Marcelo Tosatti
2020-10-22 22:39 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-22 22:39 ` Thomas Gleixner
2020-10-01 15:49 ` [Intel-wired-lan] [PATCH v4 0/4] isolation: limit msix vectors " Frederic Weisbecker
2020-10-01 15:49 ` Frederic Weisbecker
2020-10-08 21:40 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-08 21:40 ` Nitesh Narayan Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929174654.GA773@infradead.org \
--to=hch@infradead.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.