All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v4 2/4] sched/isolation: Extend nohz_full to isolate managed IRQs
Date: Fri, 23 Oct 2020 15:29:50 +0200	[thread overview]
Message-ID: <20201023132950.GA47962@lothringen> (raw)
In-Reply-To: <20201023132505.GZ2628@hirez.programming.kicks-ass.net>

On Fri, Oct 23, 2020 at 03:25:05PM +0200, Peter Zijlstra wrote:
> On Mon, Sep 28, 2020 at 02:35:27PM -0400, Nitesh Narayan Lal wrote:
> > Extend nohz_full feature set to include isolation from managed IRQS. This
> 
> So you say it's for managed-irqs, the feature is actually called
> MANAGED_IRQ, but, AFAICT, it does *NOT* in fact affect managed IRQs.
> 
> Also, as per Thomas' earlier points, managed-irqs are in fact perfectly
> fine and don't need help at at...
> 
> > is required specifically for setups that only uses nohz_full and still
> > requires isolation for maintaining lower latency for the listed CPUs.
> > 
> > Suggested-by: Frederic Weisbecker <frederic@kernel.org>

Ah and yes there is this tag :-p

So that's my bad, I really thought this thing was about managed IRQ.
The problem is that I can't find a single documentation about them so I'm
too clueless on that matter.

Thanks.

> > Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
> > ---
> >  kernel/sched/isolation.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c
> > index 5a6ea03f9882..9df9598a9e39 100644
> > --- a/kernel/sched/isolation.c
> > +++ b/kernel/sched/isolation.c
> > @@ -141,7 +141,7 @@ static int __init housekeeping_nohz_full_setup(char *str)
> >  	unsigned int flags;
> >  
> >  	flags = HK_FLAG_TICK | HK_FLAG_WQ | HK_FLAG_TIMER | HK_FLAG_RCU |
> > -		HK_FLAG_MISC | HK_FLAG_KTHREAD;
> > +		HK_FLAG_MISC | HK_FLAG_KTHREAD | HK_FLAG_MANAGED_IRQ;
> >  
> >  	return housekeeping_setup(str, flags);
> >  }
> > -- 
> > 2.18.2
> > 

WARNING: multiple messages have this Message-ID (diff)
From: Frederic Weisbecker <frederic@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nitesh Narayan Lal <nitesh@redhat.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-pci@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	mtosatti@redhat.com, sassmann@redhat.com,
	jesse.brandeburg@intel.com, lihong.yang@intel.com,
	helgaas@kernel.org, jeffrey.t.kirsher@intel.com,
	jacob.e.keller@intel.com, jlelli@redhat.com, hch@infradead.org,
	bhelgaas@google.com, mike.marciniszyn@intel.com,
	dennis.dalessandro@intel.com, thomas.lendacky@amd.com,
	jiri@nvidia.com, mingo@redhat.com, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, lgoncalv@redhat.com,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 2/4] sched/isolation: Extend nohz_full to isolate managed IRQs
Date: Fri, 23 Oct 2020 15:29:50 +0200	[thread overview]
Message-ID: <20201023132950.GA47962@lothringen> (raw)
In-Reply-To: <20201023132505.GZ2628@hirez.programming.kicks-ass.net>

On Fri, Oct 23, 2020 at 03:25:05PM +0200, Peter Zijlstra wrote:
> On Mon, Sep 28, 2020 at 02:35:27PM -0400, Nitesh Narayan Lal wrote:
> > Extend nohz_full feature set to include isolation from managed IRQS. This
> 
> So you say it's for managed-irqs, the feature is actually called
> MANAGED_IRQ, but, AFAICT, it does *NOT* in fact affect managed IRQs.
> 
> Also, as per Thomas' earlier points, managed-irqs are in fact perfectly
> fine and don't need help at at...
> 
> > is required specifically for setups that only uses nohz_full and still
> > requires isolation for maintaining lower latency for the listed CPUs.
> > 
> > Suggested-by: Frederic Weisbecker <frederic@kernel.org>

Ah and yes there is this tag :-p

So that's my bad, I really thought this thing was about managed IRQ.
The problem is that I can't find a single documentation about them so I'm
too clueless on that matter.

Thanks.

> > Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
> > ---
> >  kernel/sched/isolation.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c
> > index 5a6ea03f9882..9df9598a9e39 100644
> > --- a/kernel/sched/isolation.c
> > +++ b/kernel/sched/isolation.c
> > @@ -141,7 +141,7 @@ static int __init housekeeping_nohz_full_setup(char *str)
> >  	unsigned int flags;
> >  
> >  	flags = HK_FLAG_TICK | HK_FLAG_WQ | HK_FLAG_TIMER | HK_FLAG_RCU |
> > -		HK_FLAG_MISC | HK_FLAG_KTHREAD;
> > +		HK_FLAG_MISC | HK_FLAG_KTHREAD | HK_FLAG_MANAGED_IRQ;
> >  
> >  	return housekeeping_setup(str, flags);
> >  }
> > -- 
> > 2.18.2
> > 

  reply	other threads:[~2020-10-23 13:29 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 18:35 [Intel-wired-lan] [PATCH v4 0/4] isolation: limit msix vectors to housekeeping CPUs Nitesh Narayan Lal
2020-09-28 18:35 ` Nitesh Narayan Lal
2020-09-28 18:35 ` [Intel-wired-lan] [PATCH v4 1/4] sched/isolation: API to get number of " Nitesh Narayan Lal
2020-09-28 18:35   ` Nitesh Narayan Lal
2020-09-28 18:35 ` [Intel-wired-lan] [PATCH v4 2/4] sched/isolation: Extend nohz_full to isolate managed IRQs Nitesh Narayan Lal
2020-09-28 18:35   ` Nitesh Narayan Lal
2020-10-23 13:25   ` [Intel-wired-lan] " Peter Zijlstra
2020-10-23 13:25     ` Peter Zijlstra
2020-10-23 13:29     ` Frederic Weisbecker [this message]
2020-10-23 13:29       ` Frederic Weisbecker
2020-10-23 13:57       ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-23 13:57         ` Nitesh Narayan Lal
2020-10-23 13:45     ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-23 13:45       ` Nitesh Narayan Lal
2020-09-28 18:35 ` [Intel-wired-lan] [PATCH v4 3/4] i40e: Limit msix vectors to housekeeping CPUs Nitesh Narayan Lal
2020-09-28 18:35   ` Nitesh Narayan Lal
2020-09-28 18:35 ` [Intel-wired-lan] [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() " Nitesh Narayan Lal
2020-09-28 18:35   ` Nitesh Narayan Lal
2020-09-28 21:59   ` [Intel-wired-lan] " Bjorn Helgaas
2020-09-28 21:59     ` Bjorn Helgaas
2020-09-29 17:46     ` [Intel-wired-lan] " Christoph Hellwig
2020-09-29 17:46       ` Christoph Hellwig
2020-10-16 12:20   ` [Intel-wired-lan] " Peter Zijlstra
2020-10-16 12:20     ` Peter Zijlstra
2020-10-18 18:14     ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-18 18:14       ` Nitesh Narayan Lal
2020-10-19 11:11       ` [Intel-wired-lan] " Peter Zijlstra
2020-10-19 11:11         ` Peter Zijlstra
2020-10-19 14:00         ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-19 14:00           ` Marcelo Tosatti
2020-10-19 14:25           ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-19 14:25             ` Nitesh Narayan Lal
2020-10-20  7:30           ` [Intel-wired-lan] " Peter Zijlstra
2020-10-20  7:30             ` Peter Zijlstra
2020-10-20 13:00             ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-20 13:00               ` Nitesh Narayan Lal
2020-10-20 13:41               ` [Intel-wired-lan] " Peter Zijlstra
2020-10-20 13:41                 ` Peter Zijlstra
2020-10-20 14:39                 ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-20 14:39                   ` Nitesh Narayan Lal
2020-10-22 17:47                   ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-22 17:47                     ` Nitesh Narayan Lal
2020-10-23  8:58                     ` [Intel-wired-lan] " Peter Zijlstra
2020-10-23  8:58                       ` Peter Zijlstra
2020-10-23 13:10                       ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-23 13:10                         ` Nitesh Narayan Lal
2020-10-23 21:00                         ` [Intel-wired-lan] " Thomas Gleixner
2020-10-23 21:00                           ` Thomas Gleixner
2020-10-26 13:35                           ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-26 13:35                             ` Nitesh Narayan Lal
2020-10-26 13:57                             ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 13:57                               ` Thomas Gleixner
2020-10-26 17:30                           ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-26 17:30                             ` Marcelo Tosatti
2020-10-26 19:00                             ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 19:00                               ` Thomas Gleixner
2020-10-26 19:11                               ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-26 19:11                                 ` Marcelo Tosatti
2020-10-26 19:21                               ` [Intel-wired-lan] " Jacob Keller
2020-10-26 19:21                                 ` Jacob Keller
2020-10-26 20:11                                 ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 20:11                                   ` Thomas Gleixner
2020-10-26 21:11                                   ` [Intel-wired-lan] " Jacob Keller
2020-10-26 21:11                                     ` Jacob Keller
2020-10-26 21:50                                     ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 21:50                                       ` Thomas Gleixner
2020-10-26 22:13                                       ` [Intel-wired-lan] " Jakub Kicinski
2020-10-26 22:13                                         ` Jakub Kicinski
2020-10-26 22:46                                         ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 22:46                                           ` Thomas Gleixner
2020-10-26 22:52                                         ` [Intel-wired-lan] " Jacob Keller
2020-10-26 22:52                                           ` Jacob Keller
2020-10-26 22:22                                       ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-26 22:22                                         ` Nitesh Narayan Lal
2020-10-26 22:49                                         ` [Intel-wired-lan] " Thomas Gleixner
2020-10-26 22:49                                           ` Thomas Gleixner
2020-10-26 23:08                                           ` [Intel-wired-lan] " Jacob Keller
2020-10-26 23:08                                             ` Jacob Keller
2020-10-27 14:28                                             ` [Intel-wired-lan] " Thomas Gleixner
2020-10-27 14:28                                               ` Thomas Gleixner
2020-10-27 11:47                                         ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-27 11:47                                           ` Marcelo Tosatti
2020-10-27 14:43                                           ` [Intel-wired-lan] " Thomas Gleixner
2020-10-27 14:43                                             ` Thomas Gleixner
2020-10-19 14:21         ` [Intel-wired-lan] " Frederic Weisbecker
2020-10-19 14:21           ` Frederic Weisbecker
2020-10-20 14:16   ` [Intel-wired-lan] " Thomas Gleixner
2020-10-20 14:16     ` Thomas Gleixner
2020-10-20 16:18     ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-20 16:18       ` Nitesh Narayan Lal
2020-10-20 18:07       ` [Intel-wired-lan] " Thomas Gleixner
2020-10-20 18:07         ` Thomas Gleixner
2020-10-21 20:25         ` [Intel-wired-lan] " Thomas Gleixner
2020-10-21 20:25           ` Thomas Gleixner
2020-10-21 21:04           ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-21 21:04             ` Nitesh Narayan Lal
2020-10-22  0:02           ` [Intel-wired-lan] " Jakub Kicinski
2020-10-22  0:02             ` Jakub Kicinski
2020-10-22  0:27             ` [Intel-wired-lan] " Jacob Keller
2020-10-22  0:27               ` Jacob Keller
2020-10-22  8:28             ` [Intel-wired-lan] " Thomas Gleixner
2020-10-22  8:28               ` Thomas Gleixner
2020-10-22 12:28           ` [Intel-wired-lan] " Marcelo Tosatti
2020-10-22 12:28             ` Marcelo Tosatti
2020-10-22 22:39             ` [Intel-wired-lan] " Thomas Gleixner
2020-10-22 22:39               ` Thomas Gleixner
2020-10-01 15:49 ` [Intel-wired-lan] [PATCH v4 0/4] isolation: limit msix vectors " Frederic Weisbecker
2020-10-01 15:49   ` Frederic Weisbecker
2020-10-08 21:40   ` [Intel-wired-lan] " Nitesh Narayan Lal
2020-10-08 21:40     ` Nitesh Narayan Lal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201023132950.GA47962@lothringen \
    --to=frederic@kernel.org \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.