All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	krzk@kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2 1/3] memory: tegra: Add helper function tegra_get_memory_controller
Date: Tue, 29 Sep 2020 23:38:20 -0700	[thread overview]
Message-ID: <20200930063820.GD16460@Asurada-Nvidia> (raw)
In-Reply-To: <2f752179-5ad3-c000-8794-494c79f7b21f@gmail.com>

On Wed, Sep 30, 2020 at 09:32:20AM +0300, Dmitry Osipenko wrote:
> 30.09.2020 08:44, Nicolin Chen пишет:
> > On Wed, Sep 30, 2020 at 08:12:10AM +0300, Dmitry Osipenko wrote:
> >> 30.09.2020 03:30, Nicolin Chen пишет:
> >> ...
> >>>  int tegra_mc_write_emem_configuration(struct tegra_mc *mc, unsigned long rate);
> >>>  unsigned int tegra_mc_get_emem_device_count(struct tegra_mc *mc);
> >>> +struct tegra_mc *tegra_get_memory_controller(void);
> >>>  
> >>>  #endif /* __SOC_TEGRA_MC_H__ */
> >>>
> >>
> >> This will conflict with the tegra20-devfreq driver, you should change it
> >> as well.
> > 
> > Will remove that in v3.
> > 
> > Thanks
> > 
> 
> Please also consider to add a resource-managed variant, similar to what
> I did here:
> 
> https://github.com/grate-driver/linux/commit/2105e7664063772d72fefe9696bdab0b688b9de2
> 
> I was going to use it in the next iteration of the memory interconnect
> series.
> 
> But now it also will be good if you could add the devm variant to yours
> SMMU patchset since you're already about to touch the tegra20-devfreq
> driver. I'll then rebase my patches on top of yours patch.

Just saw this reply. Yea, I think this'd be better. Thanks
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: thierry.reding@gmail.com, joro@8bytes.org, krzk@kernel.org,
	vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] memory: tegra: Add helper function tegra_get_memory_controller
Date: Tue, 29 Sep 2020 23:38:20 -0700	[thread overview]
Message-ID: <20200930063820.GD16460@Asurada-Nvidia> (raw)
In-Reply-To: <2f752179-5ad3-c000-8794-494c79f7b21f@gmail.com>

On Wed, Sep 30, 2020 at 09:32:20AM +0300, Dmitry Osipenko wrote:
> 30.09.2020 08:44, Nicolin Chen пишет:
> > On Wed, Sep 30, 2020 at 08:12:10AM +0300, Dmitry Osipenko wrote:
> >> 30.09.2020 03:30, Nicolin Chen пишет:
> >> ...
> >>>  int tegra_mc_write_emem_configuration(struct tegra_mc *mc, unsigned long rate);
> >>>  unsigned int tegra_mc_get_emem_device_count(struct tegra_mc *mc);
> >>> +struct tegra_mc *tegra_get_memory_controller(void);
> >>>  
> >>>  #endif /* __SOC_TEGRA_MC_H__ */
> >>>
> >>
> >> This will conflict with the tegra20-devfreq driver, you should change it
> >> as well.
> > 
> > Will remove that in v3.
> > 
> > Thanks
> > 
> 
> Please also consider to add a resource-managed variant, similar to what
> I did here:
> 
> https://github.com/grate-driver/linux/commit/2105e7664063772d72fefe9696bdab0b688b9de2
> 
> I was going to use it in the next iteration of the memory interconnect
> series.
> 
> But now it also will be good if you could add the devm variant to yours
> SMMU patchset since you're already about to touch the tegra20-devfreq
> driver. I'll then rebase my patches on top of yours patch.

Just saw this reply. Yea, I think this'd be better. Thanks

  reply	other threads:[~2020-09-30  6:43 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  0:30 [PATCH v2 0/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-09-30  0:30 ` Nicolin Chen
2020-09-30  0:30 ` [PATCH v2 1/3] memory: tegra: Add helper function tegra_get_memory_controller Nicolin Chen
2020-09-30  0:30   ` Nicolin Chen
2020-09-30  5:12   ` Dmitry Osipenko
2020-09-30  5:12     ` Dmitry Osipenko
2020-09-30  5:44     ` Nicolin Chen
2020-09-30  5:44       ` Nicolin Chen
2020-09-30  6:32       ` Dmitry Osipenko
2020-09-30  6:32         ` Dmitry Osipenko
2020-09-30  6:38         ` Nicolin Chen [this message]
2020-09-30  6:38           ` Nicolin Chen
2020-09-30  7:31           ` Dmitry Osipenko
2020-09-30  7:31             ` Dmitry Osipenko
2020-09-30  7:21   ` Krzysztof Kozlowski
2020-09-30  7:21     ` Krzysztof Kozlowski
2020-09-30  7:25     ` Nicolin Chen
2020-09-30  7:25       ` Nicolin Chen
2020-09-30  7:50       ` Krzysztof Kozlowski
2020-09-30  7:50         ` Krzysztof Kozlowski
2020-09-30  0:30 ` [PATCH v2 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev Nicolin Chen
2020-09-30  0:30   ` Nicolin Chen
2020-09-30  5:10   ` Dmitry Osipenko
2020-09-30  5:10     ` Dmitry Osipenko
2020-09-30  5:20     ` Dmitry Osipenko
2020-09-30  5:20       ` Dmitry Osipenko
2020-09-30  5:50       ` Nicolin Chen
2020-09-30  5:50         ` Nicolin Chen
2020-09-30  6:34       ` Nicolin Chen
2020-09-30  6:34         ` Nicolin Chen
2020-09-30  5:11   ` Dmitry Osipenko
2020-09-30  5:11     ` Dmitry Osipenko
2020-09-30  5:49     ` Nicolin Chen
2020-09-30  5:49       ` Nicolin Chen
2020-09-30  6:10       ` Dmitry Osipenko
2020-09-30  6:10         ` Dmitry Osipenko
2020-09-30  6:13         ` Nicolin Chen
2020-09-30  6:13           ` Nicolin Chen
2020-09-30  6:33           ` Dmitry Osipenko
2020-09-30  6:33             ` Dmitry Osipenko
2020-09-30  5:24   ` Dmitry Osipenko
2020-09-30  5:24     ` Dmitry Osipenko
2020-09-30  5:39     ` Nicolin Chen
2020-09-30  5:39       ` Nicolin Chen
2020-09-30  5:48       ` Dmitry Osipenko
2020-09-30  5:48         ` Dmitry Osipenko
2020-09-30  5:39   ` Dmitry Osipenko
2020-09-30  5:39     ` Dmitry Osipenko
2020-09-30  5:41     ` Nicolin Chen
2020-09-30  5:41       ` Nicolin Chen
2020-09-30  5:59       ` Dmitry Osipenko
2020-09-30  5:59         ` Dmitry Osipenko
2020-09-30  6:19         ` Nicolin Chen
2020-09-30  6:19           ` Nicolin Chen
2020-09-30  0:30 ` [PATCH v2 3/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-09-30  0:30   ` Nicolin Chen
2020-09-30  5:10   ` Dmitry Osipenko
2020-09-30  5:10     ` Dmitry Osipenko
2020-09-30  5:28     ` Nicolin Chen
2020-09-30  5:28       ` Nicolin Chen
2020-09-30  5:10   ` Dmitry Osipenko
2020-09-30  5:10     ` Dmitry Osipenko
2020-09-30  5:29     ` Nicolin Chen
2020-09-30  5:29       ` Nicolin Chen
2020-09-30  5:58       ` Dmitry Osipenko
2020-09-30  5:58         ` Dmitry Osipenko
2020-09-30  7:16         ` Nicolin Chen
2020-09-30  7:16           ` Nicolin Chen
2020-09-30  5:10   ` Dmitry Osipenko
2020-09-30  5:10     ` Dmitry Osipenko
2020-09-30  5:34     ` Nicolin Chen
2020-09-30  5:34       ` Nicolin Chen
2020-09-30  6:01       ` Dmitry Osipenko
2020-09-30  6:01         ` Dmitry Osipenko
2020-09-30  7:12         ` Nicolin Chen
2020-09-30  7:12           ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930063820.GD16460@Asurada-Nvidia \
    --to=nicoleotsuka@gmail.com \
    --cc=digetx@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.