All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	iommu@lists.linux-foundation.org, jonathanh@nvidia.com,
	thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
	digetx@gmail.com
Subject: Re: [PATCH v2 1/3] memory: tegra: Add helper function tegra_get_memory_controller
Date: Wed, 30 Sep 2020 00:25:43 -0700	[thread overview]
Message-ID: <20200930072542.GC13876@Asurada-Nvidia> (raw)
In-Reply-To: <CAJKOXPeye7b0j1oB21JmBwc277_1RYWQ0SC0Otf+F62HK=sjjA@mail.gmail.com>

Hi Krzysztof,

On Wed, Sep 30, 2020 at 09:21:39AM +0200, Krzysztof Kozlowski wrote:
> On Wed, 30 Sep 2020 at 02:35, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> >
> > This can be used by both tegra-smmu and tegra20-devfreq drivers.
> >
> > Suggested-by: Dmitry Osipenko <digetx@gmail.com>
> > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> > ---
> >
> > Changelog
> > v1->v2
> >  * N/A
> >
> >  drivers/memory/tegra/mc.c | 23 +++++++++++++++++++++++
> >  include/soc/tegra/mc.h    |  1 +
> >  2 files changed, 24 insertions(+)
> >
> > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
> > index ec8403557ed4..09352ad66dcc 100644
> > --- a/drivers/memory/tegra/mc.c
> > +++ b/drivers/memory/tegra/mc.c
> > @@ -42,6 +42,29 @@ static const struct of_device_id tegra_mc_of_match[] = {
> >  };
> >  MODULE_DEVICE_TABLE(of, tegra_mc_of_match);
> 
> > +struct tegra_mc *tegra_get_memory_controller(void)
> > +{
> 
> Add kerneldoc and mention dropping of reference to the device after use.

I am abort to use Dmitry's devm_ one in my next version:
https://github.com/grate-driver/linux/commit/2105e7664063772d72fefe9696bdab0b688b9de2

Could I just skip the kerneldoc part? Otherwise, would you please
tell me which kerneldoc file I should update?

Thanks
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: thierry.reding@gmail.com, joro@8bytes.org, digetx@gmail.com,
	vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] memory: tegra: Add helper function tegra_get_memory_controller
Date: Wed, 30 Sep 2020 00:25:43 -0700	[thread overview]
Message-ID: <20200930072542.GC13876@Asurada-Nvidia> (raw)
In-Reply-To: <CAJKOXPeye7b0j1oB21JmBwc277_1RYWQ0SC0Otf+F62HK=sjjA@mail.gmail.com>

Hi Krzysztof,

On Wed, Sep 30, 2020 at 09:21:39AM +0200, Krzysztof Kozlowski wrote:
> On Wed, 30 Sep 2020 at 02:35, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> >
> > This can be used by both tegra-smmu and tegra20-devfreq drivers.
> >
> > Suggested-by: Dmitry Osipenko <digetx@gmail.com>
> > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> > ---
> >
> > Changelog
> > v1->v2
> >  * N/A
> >
> >  drivers/memory/tegra/mc.c | 23 +++++++++++++++++++++++
> >  include/soc/tegra/mc.h    |  1 +
> >  2 files changed, 24 insertions(+)
> >
> > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
> > index ec8403557ed4..09352ad66dcc 100644
> > --- a/drivers/memory/tegra/mc.c
> > +++ b/drivers/memory/tegra/mc.c
> > @@ -42,6 +42,29 @@ static const struct of_device_id tegra_mc_of_match[] = {
> >  };
> >  MODULE_DEVICE_TABLE(of, tegra_mc_of_match);
> 
> > +struct tegra_mc *tegra_get_memory_controller(void)
> > +{
> 
> Add kerneldoc and mention dropping of reference to the device after use.

I am abort to use Dmitry's devm_ one in my next version:
https://github.com/grate-driver/linux/commit/2105e7664063772d72fefe9696bdab0b688b9de2

Could I just skip the kerneldoc part? Otherwise, would you please
tell me which kerneldoc file I should update?

Thanks

  reply	other threads:[~2020-09-30  7:31 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  0:30 [PATCH v2 0/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-09-30  0:30 ` Nicolin Chen
2020-09-30  0:30 ` [PATCH v2 1/3] memory: tegra: Add helper function tegra_get_memory_controller Nicolin Chen
2020-09-30  0:30   ` Nicolin Chen
2020-09-30  5:12   ` Dmitry Osipenko
2020-09-30  5:12     ` Dmitry Osipenko
2020-09-30  5:44     ` Nicolin Chen
2020-09-30  5:44       ` Nicolin Chen
2020-09-30  6:32       ` Dmitry Osipenko
2020-09-30  6:32         ` Dmitry Osipenko
2020-09-30  6:38         ` Nicolin Chen
2020-09-30  6:38           ` Nicolin Chen
2020-09-30  7:31           ` Dmitry Osipenko
2020-09-30  7:31             ` Dmitry Osipenko
2020-09-30  7:21   ` Krzysztof Kozlowski
2020-09-30  7:21     ` Krzysztof Kozlowski
2020-09-30  7:25     ` Nicolin Chen [this message]
2020-09-30  7:25       ` Nicolin Chen
2020-09-30  7:50       ` Krzysztof Kozlowski
2020-09-30  7:50         ` Krzysztof Kozlowski
2020-09-30  0:30 ` [PATCH v2 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev Nicolin Chen
2020-09-30  0:30   ` Nicolin Chen
2020-09-30  5:10   ` Dmitry Osipenko
2020-09-30  5:10     ` Dmitry Osipenko
2020-09-30  5:20     ` Dmitry Osipenko
2020-09-30  5:20       ` Dmitry Osipenko
2020-09-30  5:50       ` Nicolin Chen
2020-09-30  5:50         ` Nicolin Chen
2020-09-30  6:34       ` Nicolin Chen
2020-09-30  6:34         ` Nicolin Chen
2020-09-30  5:11   ` Dmitry Osipenko
2020-09-30  5:11     ` Dmitry Osipenko
2020-09-30  5:49     ` Nicolin Chen
2020-09-30  5:49       ` Nicolin Chen
2020-09-30  6:10       ` Dmitry Osipenko
2020-09-30  6:10         ` Dmitry Osipenko
2020-09-30  6:13         ` Nicolin Chen
2020-09-30  6:13           ` Nicolin Chen
2020-09-30  6:33           ` Dmitry Osipenko
2020-09-30  6:33             ` Dmitry Osipenko
2020-09-30  5:24   ` Dmitry Osipenko
2020-09-30  5:24     ` Dmitry Osipenko
2020-09-30  5:39     ` Nicolin Chen
2020-09-30  5:39       ` Nicolin Chen
2020-09-30  5:48       ` Dmitry Osipenko
2020-09-30  5:48         ` Dmitry Osipenko
2020-09-30  5:39   ` Dmitry Osipenko
2020-09-30  5:39     ` Dmitry Osipenko
2020-09-30  5:41     ` Nicolin Chen
2020-09-30  5:41       ` Nicolin Chen
2020-09-30  5:59       ` Dmitry Osipenko
2020-09-30  5:59         ` Dmitry Osipenko
2020-09-30  6:19         ` Nicolin Chen
2020-09-30  6:19           ` Nicolin Chen
2020-09-30  0:30 ` [PATCH v2 3/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-09-30  0:30   ` Nicolin Chen
2020-09-30  5:10   ` Dmitry Osipenko
2020-09-30  5:10     ` Dmitry Osipenko
2020-09-30  5:28     ` Nicolin Chen
2020-09-30  5:28       ` Nicolin Chen
2020-09-30  5:10   ` Dmitry Osipenko
2020-09-30  5:10     ` Dmitry Osipenko
2020-09-30  5:29     ` Nicolin Chen
2020-09-30  5:29       ` Nicolin Chen
2020-09-30  5:58       ` Dmitry Osipenko
2020-09-30  5:58         ` Dmitry Osipenko
2020-09-30  7:16         ` Nicolin Chen
2020-09-30  7:16           ` Nicolin Chen
2020-09-30  5:10   ` Dmitry Osipenko
2020-09-30  5:10     ` Dmitry Osipenko
2020-09-30  5:34     ` Nicolin Chen
2020-09-30  5:34       ` Nicolin Chen
2020-09-30  6:01       ` Dmitry Osipenko
2020-09-30  6:01         ` Dmitry Osipenko
2020-09-30  7:12         ` Nicolin Chen
2020-09-30  7:12           ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930072542.GC13876@Asurada-Nvidia \
    --to=nicoleotsuka@gmail.com \
    --cc=digetx@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.