* [PATCH] staging: gpio: 104-idi-48: improve code indentation
@ 2020-10-13 18:19 Deepak R Varma
2020-10-13 18:34 ` Greg KH
2020-10-13 18:52 ` William Breathitt Gray
0 siblings, 2 replies; 3+ messages in thread
From: Deepak R Varma @ 2020-10-13 18:19 UTC (permalink / raw)
To: outreachy-kernel, William Breathitt Gray, Linus Walleij,
Bartosz Golaszewski, gregkh
Address code indentation warning messages by checkpatch script. Combine
split function parameters on one line. This also resolves the "use tabs
instead of space" warning by checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
drivers/gpio/gpio-104-idi-48.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-104-idi-48.c b/drivers/gpio/gpio-104-idi-48.c
index 94c3a9bc4e75..b132afaf7d99 100644
--- a/drivers/gpio/gpio-104-idi-48.c
+++ b/drivers/gpio/gpio-104-idi-48.c
@@ -132,8 +132,7 @@ static void idi_48_irq_mask(struct irq_data *data)
outb(idi48gpio->cos_enb, idi48gpio->base + 7);
- raw_spin_unlock_irqrestore(&idi48gpio->lock,
- flags);
+ raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
}
return;
@@ -166,8 +165,7 @@ static void idi_48_irq_unmask(struct irq_data *data)
outb(idi48gpio->cos_enb, idi48gpio->base + 7);
- raw_spin_unlock_irqrestore(&idi48gpio->lock,
- flags);
+ raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
}
return;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: gpio: 104-idi-48: improve code indentation
2020-10-13 18:19 [PATCH] staging: gpio: 104-idi-48: improve code indentation Deepak R Varma
@ 2020-10-13 18:34 ` Greg KH
2020-10-13 18:52 ` William Breathitt Gray
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-10-13 18:34 UTC (permalink / raw)
To: Deepak R Varma
Cc: outreachy-kernel, William Breathitt Gray, Linus Walleij,
Bartosz Golaszewski
On Tue, Oct 13, 2020 at 11:49:03PM +0530, Deepak R Varma wrote:
> Address code indentation warning messages by checkpatch script. Combine
> split function parameters on one line. This also resolves the "use tabs
> instead of space" warning by checkpatch script.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
>
> ---
>
> drivers/gpio/gpio-104-idi-48.c | 6 ++----
Your subject line is incorrect based on the file you changed :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: gpio: 104-idi-48: improve code indentation
2020-10-13 18:19 [PATCH] staging: gpio: 104-idi-48: improve code indentation Deepak R Varma
2020-10-13 18:34 ` Greg KH
@ 2020-10-13 18:52 ` William Breathitt Gray
1 sibling, 0 replies; 3+ messages in thread
From: William Breathitt Gray @ 2020-10-13 18:52 UTC (permalink / raw)
To: Deepak R Varma, Linus Walleij
Cc: outreachy-kernel, Bartosz Golaszewski, gregkh
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
On Tue, Oct 13, 2020 at 11:49:03PM +0530, Deepak R Varma wrote:
> Address code indentation warning messages by checkpatch script. Combine
> split function parameters on one line. This also resolves the "use tabs
> instead of space" warning by checkpatch script.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
As Greg KH mentioned, the subject line should be fixed; as for the
change itself, it looks like pretty innocent whitespace adjustments, so
I'm okay with it. :-)
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>
> ---
>
> drivers/gpio/gpio-104-idi-48.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-104-idi-48.c b/drivers/gpio/gpio-104-idi-48.c
> index 94c3a9bc4e75..b132afaf7d99 100644
> --- a/drivers/gpio/gpio-104-idi-48.c
> +++ b/drivers/gpio/gpio-104-idi-48.c
> @@ -132,8 +132,7 @@ static void idi_48_irq_mask(struct irq_data *data)
>
> outb(idi48gpio->cos_enb, idi48gpio->base + 7);
>
> - raw_spin_unlock_irqrestore(&idi48gpio->lock,
> - flags);
> + raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
> }
>
> return;
> @@ -166,8 +165,7 @@ static void idi_48_irq_unmask(struct irq_data *data)
>
> outb(idi48gpio->cos_enb, idi48gpio->base + 7);
>
> - raw_spin_unlock_irqrestore(&idi48gpio->lock,
> - flags);
> + raw_spin_unlock_irqrestore(&idi48gpio->lock, flags);
> }
>
> return;
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-13 19:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-13 18:19 [PATCH] staging: gpio: 104-idi-48: improve code indentation Deepak R Varma
2020-10-13 18:34 ` Greg KH
2020-10-13 18:52 ` William Breathitt Gray
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.