All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Udo van den Heuvel <udovdh@xs4all.nl>
Cc: moderated for non-subscribers <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>,
	Randy Dunlap <rdunlap@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dan Murphy <dmurphy@ti.com>,
	linux-leds@vger.kernel.org
Subject: Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)
Date: Wed, 14 Oct 2020 10:37:58 +0200	[thread overview]
Message-ID: <20201014083758.GB31728@amd> (raw)
In-Reply-To: <9cf705b9-1fca-2445-43de-916b13b9103f@xs4all.nl>

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Wed 2020-10-14 10:34:21, Udo van den Heuvel wrote:
> On 14-10-2020 10:27, Pavel Machek wrote:
> >> One should have thought about stuff beforehand.
> > 
> > We did. And decided this is best solution.
> 
> Then the thought process went awry.
> 
> >> The non-selectability is not my fault.
> > 
> > It also does not affect you in any way.
> 
> It does.
> /boot fills up even sooner thanks to this unused code.
> Compiles last longer because of this unused code.

Have you measured how much slower and how much bigger it is? Do you
understand that you propose to make source code bigger and slower to
compile for everyone else?

You are filling my inbox.

> > Feel free to go to the mic LED discussion to see why we did it like
> > this. Then you can come up with better solution for problem at hand.
> 
> I did not think of forcing code onto somebody. Someone else did.
> This is effectively the effect of the LEDs thing.

Without understanding what was decided and why, this discussion is not
useful.


									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Udo van den Heuvel <udovdh@xs4all.nl>
Cc: Takashi Iwai <tiwai@suse.de>,
	Randy Dunlap <rdunlap@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-leds@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
	moderated for non-subscribers <alsa-devel@alsa-project.org>
Subject: Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)
Date: Wed, 14 Oct 2020 10:37:58 +0200	[thread overview]
Message-ID: <20201014083758.GB31728@amd> (raw)
In-Reply-To: <9cf705b9-1fca-2445-43de-916b13b9103f@xs4all.nl>

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Wed 2020-10-14 10:34:21, Udo van den Heuvel wrote:
> On 14-10-2020 10:27, Pavel Machek wrote:
> >> One should have thought about stuff beforehand.
> > 
> > We did. And decided this is best solution.
> 
> Then the thought process went awry.
> 
> >> The non-selectability is not my fault.
> > 
> > It also does not affect you in any way.
> 
> It does.
> /boot fills up even sooner thanks to this unused code.
> Compiles last longer because of this unused code.

Have you measured how much slower and how much bigger it is? Do you
understand that you propose to make source code bigger and slower to
compile for everyone else?

You are filling my inbox.

> > Feel free to go to the mic LED discussion to see why we did it like
> > this. Then you can come up with better solution for problem at hand.
> 
> I did not think of forcing code onto somebody. Someone else did.
> This is effectively the effect of the LEDs thing.

Without understanding what was decided and why, this discussion is not
useful.


									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2020-10-14  8:39 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  9:24 disabling CONFIG_LED_CLASS Udo van den Heuvel
2020-10-13 13:24 ` Udo van den Heuvel
2020-10-13 15:53   ` Randy Dunlap
2020-10-13 16:03     ` Randy Dunlap
2020-10-14  4:29       ` Udo van den Heuvel
2020-10-14  4:34         ` Randy Dunlap
2020-10-14  4:39           ` Udo van den Heuvel
2020-10-14  4:49             ` Randy Dunlap
2020-10-14  4:56               ` Udo van den Heuvel
2020-10-14  5:07                 ` Randy Dunlap
2020-10-14  5:16                   ` Udo van den Heuvel
2020-10-14  5:54                     ` disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK) Randy Dunlap
2020-10-14  7:49                       ` Takashi Iwai
2020-10-14  7:49                         ` Takashi Iwai
2020-10-14  7:51                         ` Takashi Iwai
2020-10-14  7:51                           ` Takashi Iwai
2020-10-14  7:58                           ` Pavel Machek
2020-10-14  7:58                             ` Pavel Machek
2020-10-14  8:05                             ` Udo van den Heuvel
2020-10-14  8:11                               ` Pavel Machek
2020-10-14  8:11                                 ` Pavel Machek
2020-10-14  8:22                                 ` Udo van den Heuvel
2020-10-14  8:27                                   ` Pavel Machek
2020-10-14  8:27                                     ` Pavel Machek
2020-10-14  8:34                                     ` Udo van den Heuvel
2020-10-14  8:37                                       ` Pavel Machek [this message]
2020-10-14  8:37                                         ` Pavel Machek
2020-10-19  8:35                                         ` Udo van den Heuvel
2020-10-19 10:58                                           ` Marek Behún
2020-10-19 10:58                                             ` Marek Behún
2020-10-14  8:06                             ` Takashi Iwai
2020-10-14  8:06                               ` Takashi Iwai
2020-10-14  7:54                       ` Pavel Machek
2020-10-14  7:54                         ` Pavel Machek
2020-10-14  8:08                         ` Takashi Iwai
2020-10-14  8:08                           ` Takashi Iwai
2020-10-14  8:13                           ` Pavel Machek
2020-10-14  8:13                             ` Pavel Machek
2020-10-14  8:17                             ` Takashi Iwai
2020-10-14  8:17                               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014083758.GB31728@amd \
    --to=pavel@ucw.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=dmurphy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=tiwai@suse.de \
    --cc=udovdh@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.