From: Pavel Machek <pavel@ucw.cz>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: moderated for non-subscribers <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Udo van den Heuvel <udovdh@xs4all.nl>,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org
Subject: Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)
Date: Wed, 14 Oct 2020 09:54:59 +0200 [thread overview]
Message-ID: <20201014075458.GA29881@amd> (raw)
In-Reply-To: <d7774b58-caf5-5bd8-845d-a5d45aaef4c6@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
Hi!
> >>> I.e.: it looks like I will lose some funcionality when I disable
> >>> SND_HDA_CODEC_REALTEK.
> >>
> >> OK. At present you can't have it both ways, i.e., SND_HDA_CODEC_REALTEK
> >> with no LEDS. That driver apparently wants LEDS.
> >
> > Thanks but why have I gone for years without LEDS?
> > I do not need LEDS, I do not want LEDS, I do not have LEDS (that are
> > visible, usable, etc).
> >
> > Please make this selectable instead of forcing more bulk into my
>> kernel.
LED core is not that big, and this avoided some rather "interesting"
hacks IIRC. If Udo wants more config complexity, lets first make him
measure the benefits, second submit a patch.
But I'd suggest to just live with it.
And yes, we should probably get rid of "CONFIG_NEW_LEDS" symbol. That
one is actually useless.
Best regards,
Pavel
> and this Kconfig entry:
>
> config SND_HDA_CODEC_REALTEK
> tristate "Build Realtek HD-audio codec support"
> select SND_HDA_GENERIC
> select SND_HDA_GENERIC_LEDS
>
> it seems that LED support is not always wanted (please see above).
> I.e., user(s) would like to build a kernel without LED support at all.
>
> Can you make it a build option?
>
> thanks.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Udo van den Heuvel <udovdh@xs4all.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
Takashi Iwai <tiwai@suse.de>,
moderated for non-subscribers <alsa-devel@alsa-project.org>
Subject: Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)
Date: Wed, 14 Oct 2020 09:54:59 +0200 [thread overview]
Message-ID: <20201014075458.GA29881@amd> (raw)
In-Reply-To: <d7774b58-caf5-5bd8-845d-a5d45aaef4c6@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
Hi!
> >>> I.e.: it looks like I will lose some funcionality when I disable
> >>> SND_HDA_CODEC_REALTEK.
> >>
> >> OK. At present you can't have it both ways, i.e., SND_HDA_CODEC_REALTEK
> >> with no LEDS. That driver apparently wants LEDS.
> >
> > Thanks but why have I gone for years without LEDS?
> > I do not need LEDS, I do not want LEDS, I do not have LEDS (that are
> > visible, usable, etc).
> >
> > Please make this selectable instead of forcing more bulk into my
>> kernel.
LED core is not that big, and this avoided some rather "interesting"
hacks IIRC. If Udo wants more config complexity, lets first make him
measure the benefits, second submit a patch.
But I'd suggest to just live with it.
And yes, we should probably get rid of "CONFIG_NEW_LEDS" symbol. That
one is actually useless.
Best regards,
Pavel
> and this Kconfig entry:
>
> config SND_HDA_CODEC_REALTEK
> tristate "Build Realtek HD-audio codec support"
> select SND_HDA_GENERIC
> select SND_HDA_GENERIC_LEDS
>
> it seems that LED support is not always wanted (please see above).
> I.e., user(s) would like to build a kernel without LED support at all.
>
> Can you make it a build option?
>
> thanks.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-10-14 7:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 9:24 disabling CONFIG_LED_CLASS Udo van den Heuvel
2020-10-13 13:24 ` Udo van den Heuvel
2020-10-13 15:53 ` Randy Dunlap
2020-10-13 16:03 ` Randy Dunlap
2020-10-14 4:29 ` Udo van den Heuvel
2020-10-14 4:34 ` Randy Dunlap
2020-10-14 4:39 ` Udo van den Heuvel
2020-10-14 4:49 ` Randy Dunlap
2020-10-14 4:56 ` Udo van den Heuvel
2020-10-14 5:07 ` Randy Dunlap
2020-10-14 5:16 ` Udo van den Heuvel
2020-10-14 5:54 ` disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK) Randy Dunlap
2020-10-14 7:49 ` Takashi Iwai
2020-10-14 7:49 ` Takashi Iwai
2020-10-14 7:51 ` Takashi Iwai
2020-10-14 7:51 ` Takashi Iwai
2020-10-14 7:58 ` Pavel Machek
2020-10-14 7:58 ` Pavel Machek
2020-10-14 8:05 ` Udo van den Heuvel
2020-10-14 8:11 ` Pavel Machek
2020-10-14 8:11 ` Pavel Machek
2020-10-14 8:22 ` Udo van den Heuvel
2020-10-14 8:27 ` Pavel Machek
2020-10-14 8:27 ` Pavel Machek
2020-10-14 8:34 ` Udo van den Heuvel
2020-10-14 8:37 ` Pavel Machek
2020-10-14 8:37 ` Pavel Machek
2020-10-19 8:35 ` Udo van den Heuvel
2020-10-19 10:58 ` Marek Behún
2020-10-19 10:58 ` Marek Behún
2020-10-14 8:06 ` Takashi Iwai
2020-10-14 8:06 ` Takashi Iwai
2020-10-14 7:54 ` Pavel Machek [this message]
2020-10-14 7:54 ` Pavel Machek
2020-10-14 8:08 ` Takashi Iwai
2020-10-14 8:08 ` Takashi Iwai
2020-10-14 8:13 ` Pavel Machek
2020-10-14 8:13 ` Pavel Machek
2020-10-14 8:17 ` Takashi Iwai
2020-10-14 8:17 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014075458.GA29881@amd \
--to=pavel@ucw.cz \
--cc=alsa-devel@alsa-project.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tiwai@suse.de \
--cc=udovdh@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.