[PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

[PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

[Khem Raj]

latest OE-core does not promote using trailing slash to make pseudo's
life easier

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
v2: Strip slash from S if it exists

 classes/ti-pdk-fetch.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/ti-pdk-fetch.bbclass b/classes/ti-pdk-fetch.bbclass
index 0c9879be..cacd71a4 100644
--- a/classes/ti-pdk-fetch.bbclass
+++ b/classes/ti-pdk-fetch.bbclass
@@ -15,7 +15,7 @@ TI_PDK_SOURCE_PN = "ti-pdk-source"
 TI_PDK_SOURCE_WORKDIR = "${TMPDIR}/work-shared/ti-pdk-${PV}"
 TI_PDK_SOURCE = "${TI_PDK_SOURCE_WORKDIR}/git"
 
-S = "${WORKDIR}/git/${TI_PDK_COMP_PATH}"
+S = "${@'${WORKDIR}/git/${TI_PDK_COMP_PATH}'.rstrip('/')}"
 
 # Hard-link only required sources from PDK
 python do_unpack_append() {
-- 
2.28.0

Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

[Denys Dmytriyenko]

On Tue, Oct 13, 2020 at 02:49:11PM -0700, Khem Raj wrote:
> latest OE-core does not promote using trailing slash to make pseudo's
> life easier

This should be fine.


> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Reviewed-by: Denys Dmytriyenko <denys@ti.com>


> ---
> v2: Strip slash from S if it exists
> 
>  classes/ti-pdk-fetch.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/classes/ti-pdk-fetch.bbclass b/classes/ti-pdk-fetch.bbclass
> index 0c9879be..cacd71a4 100644
> --- a/classes/ti-pdk-fetch.bbclass
> +++ b/classes/ti-pdk-fetch.bbclass
> @@ -15,7 +15,7 @@ TI_PDK_SOURCE_PN = "ti-pdk-source"
>  TI_PDK_SOURCE_WORKDIR = "${TMPDIR}/work-shared/ti-pdk-${PV}"
>  TI_PDK_SOURCE = "${TI_PDK_SOURCE_WORKDIR}/git"
>  
> -S = "${WORKDIR}/git/${TI_PDK_COMP_PATH}"
> +S = "${@'${WORKDIR}/git/${TI_PDK_COMP_PATH}'.rstrip('/')}"
>  
>  # Hard-link only required sources from PDK
>  python do_unpack_append() {
> -- 
> 2.28.0
> 

> 
> 
> 

Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

[Dan Murphy]

Khem

On 10/13/20 4:49 PM, Khem Raj wrote:
> latest OE-core does not promote using trailing slash to make pseudo's
> life easier
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> v2: Strip slash from S if it exists

There were 2 patches submitted with v1.  Do we just drop the RTOS patch now?

Dan

Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

[Denys Dmytriyenko]

On Wed, Oct 14, 2020 at 10:35:13AM -0500, Dan Murphy via lists.yoctoproject.org wrote:
> Khem
> 
> On 10/13/20 4:49 PM, Khem Raj wrote:
> >latest OE-core does not promote using trailing slash to make pseudo's
> >life easier
> >
> >Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >---
> >v2: Strip slash from S if it exists
> 
> There were 2 patches submitted with v1.  Do we just drop the RTOS patch now?

Dan,

I believe it is also needed.

Denys

Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

[Dan Murphy]

Denys

On 10/14/20 10:37 AM, Denys Dmytriyenko wrote:
> On Wed, Oct 14, 2020 at 10:35:13AM -0500, Dan Murphy via lists.yoctoproject.org wrote:
>> Khem
>>
>> On 10/13/20 4:49 PM, Khem Raj wrote:
>>> latest OE-core does not promote using trailing slash to make pseudo's
>>> life easier
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> v2: Strip slash from S if it exists
>> There were 2 patches submitted with v1.  Do we just drop the RTOS patch now?
> Dan,
>
> I believe it is also needed.

Yes I believe it is needed as well just need Khem to confirm or resubmit 
the series

Dan


> Denys

Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

[Khem Raj]

On Wed, Oct 14, 2020 at 8:35 AM Dan Murphy <dmurphy@ti.com> wrote:
>
> Khem
>
> On 10/13/20 4:49 PM, Khem Raj wrote:
> > latest OE-core does not promote using trailing slash to make pseudo's
> > life easier
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > v2: Strip slash from S if it exists
>
> There were 2 patches submitted with v1.  Do we just drop the RTOS patch now?
>

right you need v1 of one patch and v2 of the other. I usually update
the series with the resent patches. If you want whole series to be
resent I can do that.


> Dan
>

Re: [meta-ti] [PATCH v2] ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

[Dan Murphy]

Khem

On 10/14/20 10:51 AM, Khem Raj wrote:
> On Wed, Oct 14, 2020 at 8:35 AM Dan Murphy <dmurphy@ti.com> wrote:
>> Khem
>>
>> On 10/13/20 4:49 PM, Khem Raj wrote:
>>> latest OE-core does not promote using trailing slash to make pseudo's
>>> life easier
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> v2: Strip slash from S if it exists
>> There were 2 patches submitted with v1.  Do we just drop the RTOS patch now?
>>
> right you need v1 of one patch and v2 of the other. I usually update
> the series with the resent patches. If you want whole series to be
> resent I can do that.

OK.  I will apply them.  Generally when you promote a patch version in a 
series the full series should be promoted and re-sent.

Otherwise patches might be missed.

Dan