All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Bihong Yu <yubihong@huawei.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	quintela@redhat.com, alex.chen@huawei.com, wanghao232@huawei.com,
	zhengchuan@huawei.com
Subject: Re: [PATCH v2 5/8] migration: Add braces {} for if statement
Date: Wed, 14 Oct 2020 20:17:10 +0100	[thread overview]
Message-ID: <20201014191710.GK2996@work-vm> (raw)
In-Reply-To: <1602508140-11372-6-git-send-email-yubihong@huawei.com>

* Bihong Yu (yubihong@huawei.com) wrote:
> Signed-off-by: Bihong Yu <yubihong@huawei.com>
> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  migration/ram.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 0aea78f..09178cc 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -101,14 +101,16 @@ static struct {
>  
>  static void XBZRLE_cache_lock(void)
>  {
> -    if (migrate_use_xbzrle())
> +    if (migrate_use_xbzrle()) {
>          qemu_mutex_lock(&XBZRLE.lock);
> +    }
>  }
>  
>  static void XBZRLE_cache_unlock(void)
>  {
> -    if (migrate_use_xbzrle())
> +    if (migrate_use_xbzrle()) {
>          qemu_mutex_unlock(&XBZRLE.lock);
> +    }
>  }
>  
>  /**
> -- 
> 1.8.3.1
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Bihong Yu <yubihong@huawei.com>
Cc: zhengchuan@huawei.com, quintela@redhat.com,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	alex.chen@huawei.com, wanghao232@huawei.com
Subject: Re: [PATCH v2 5/8] migration: Add braces {} for if statement
Date: Wed, 14 Oct 2020 20:17:10 +0100	[thread overview]
Message-ID: <20201014191710.GK2996@work-vm> (raw)
In-Reply-To: <1602508140-11372-6-git-send-email-yubihong@huawei.com>

* Bihong Yu (yubihong@huawei.com) wrote:
> Signed-off-by: Bihong Yu <yubihong@huawei.com>
> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  migration/ram.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 0aea78f..09178cc 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -101,14 +101,16 @@ static struct {
>  
>  static void XBZRLE_cache_lock(void)
>  {
> -    if (migrate_use_xbzrle())
> +    if (migrate_use_xbzrle()) {
>          qemu_mutex_lock(&XBZRLE.lock);
> +    }
>  }
>  
>  static void XBZRLE_cache_unlock(void)
>  {
> -    if (migrate_use_xbzrle())
> +    if (migrate_use_xbzrle()) {
>          qemu_mutex_unlock(&XBZRLE.lock);
> +    }
>  }
>  
>  /**
> -- 
> 1.8.3.1
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



  reply	other threads:[~2020-10-14 19:17 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 13:08 [PATCH v2 0/8] Fix some style problems in migration Bihong Yu
2020-10-12 13:08 ` Bihong Yu
2020-10-12 13:08 ` [PATCH v2 1/8] migration: Do not use C99 // comments Bihong Yu
2020-10-12 13:08   ` Bihong Yu
2020-10-13  9:39   ` Dr. David Alan Gilbert
2020-10-13  9:39     ` Dr. David Alan Gilbert
2020-10-13 13:20     ` Bihong Yu
2020-10-13 13:20       ` Bihong Yu
2020-10-14  1:29       ` Zheng Chuan
2020-10-14  1:29         ` Zheng Chuan
2020-10-14  1:36         ` Bihong Yu
2020-10-14  1:36           ` Bihong Yu
2020-10-12 13:08 ` [PATCH v2 2/8] migration: Don't use '#' flag of printf format Bihong Yu
2020-10-12 13:08   ` Bihong Yu
2020-10-14 19:27   ` Dr. David Alan Gilbert
2020-10-14 19:27     ` Dr. David Alan Gilbert
2020-10-20  6:46   ` Philippe Mathieu-Daudé
2020-10-20  6:46     ` Philippe Mathieu-Daudé
2020-10-12 13:08 ` [PATCH v2 3/8] migration: Add spaces around operator Bihong Yu
2020-10-12 13:08   ` Bihong Yu
2020-10-13 10:10   ` Dr. David Alan Gilbert
2020-10-13 10:10     ` Dr. David Alan Gilbert
2020-10-19  8:24     ` Markus Armbruster
2020-10-19  8:24       ` Markus Armbruster
2020-10-19  9:43       ` Bihong Yu
2020-10-19  9:43         ` Bihong Yu
2020-10-19 11:59         ` Markus Armbruster
2020-10-19 11:59           ` Markus Armbruster
2020-10-20  2:47           ` Bihong Yu
2020-10-20  2:47             ` Bihong Yu
2020-10-12 13:08 ` [PATCH v2 4/8] migration: Open brace '{' following struct go on the same line Bihong Yu
2020-10-12 13:08   ` Bihong Yu
2020-10-13 13:33   ` Dr. David Alan Gilbert
2020-10-13 13:33     ` Dr. David Alan Gilbert
2020-10-12 13:08 ` [PATCH v2 5/8] migration: Add braces {} for if statement Bihong Yu
2020-10-12 13:08   ` Bihong Yu
2020-10-14 19:17   ` Dr. David Alan Gilbert [this message]
2020-10-14 19:17     ` Dr. David Alan Gilbert
2020-10-20  6:47   ` Philippe Mathieu-Daudé
2020-10-20  6:47     ` Philippe Mathieu-Daudé
2020-10-12 13:08 ` [PATCH v2 6/8] migration: Do not initialise statics and globals to 0 or NULL Bihong Yu
2020-10-12 13:08   ` Bihong Yu
2020-10-14 19:21   ` Dr. David Alan Gilbert
2020-10-14 19:21     ` Dr. David Alan Gilbert
2020-10-20  6:50     ` Philippe Mathieu-Daudé
2020-10-20  6:50       ` Philippe Mathieu-Daudé
2020-10-12 13:08 ` [PATCH v2 7/8] migration: Open brace '{' following function declarations go on the next line Bihong Yu
2020-10-12 13:08   ` Bihong Yu
2020-10-14 19:26   ` Dr. David Alan Gilbert
2020-10-14 19:26     ` Dr. David Alan Gilbert
2020-10-12 13:09 ` [PATCH v2 8/8] migration: Delete redundant spaces Bihong Yu
2020-10-12 13:09   ` Bihong Yu
2020-10-14 19:14   ` Dr. David Alan Gilbert
2020-10-14 19:14     ` Dr. David Alan Gilbert
2020-10-20  6:50   ` Philippe Mathieu-Daudé
2020-10-20  6:50     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014191710.GK2996@work-vm \
    --to=dgilbert@redhat.com \
    --cc=alex.chen@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=wanghao232@huawei.com \
    --cc=yubihong@huawei.com \
    --cc=zhengchuan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.