From: Markus Armbruster <armbru@redhat.com>
To: Bihong Yu <yubihong@huawei.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
alex.chen@huawei.com, quintela@redhat.com,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
zhengchuan@huawei.com, wanghao232@huawei.com
Subject: Re: [PATCH v2 3/8] migration: Add spaces around operator
Date: Mon, 19 Oct 2020 13:59:47 +0200 [thread overview]
Message-ID: <87h7qq4ea4.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <90d55347-0f39-1ac7-f1a1-3982684b2213@huawei.com> (Bihong Yu's message of "Mon, 19 Oct 2020 17:43:36 +0800")
Bihong Yu <yubihong@huawei.com> writes:
> Yes, I used to think "const VMStateDescription *[]" was right, but when I search
> similar expressions, most of all are "xxx * []". Such as:
> fsdev/qemu-fsdev.c:54: .opts = (const char * [])
> hw/intc/s390_flic_kvm.c:567: .subsections = (const VMStateDescription * [])
> ...
All three variations occur in the code: no space, space on both sides,
space only on the left.
> So, I keep the same style. Should I change it to "const VMStateDescription *[]"?
Dropping the change to savevm.c should be fine.
Changing it to "VMStateDescription *[]" should be also fine.
I figure you can keep David's R-by in both cases.
[...]
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Bihong Yu <yubihong@huawei.com>
Cc: zhengchuan@huawei.com, quintela@redhat.com,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
alex.chen@huawei.com, wanghao232@huawei.com
Subject: Re: [PATCH v2 3/8] migration: Add spaces around operator
Date: Mon, 19 Oct 2020 13:59:47 +0200 [thread overview]
Message-ID: <87h7qq4ea4.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <90d55347-0f39-1ac7-f1a1-3982684b2213@huawei.com> (Bihong Yu's message of "Mon, 19 Oct 2020 17:43:36 +0800")
Bihong Yu <yubihong@huawei.com> writes:
> Yes, I used to think "const VMStateDescription *[]" was right, but when I search
> similar expressions, most of all are "xxx * []". Such as:
> fsdev/qemu-fsdev.c:54: .opts = (const char * [])
> hw/intc/s390_flic_kvm.c:567: .subsections = (const VMStateDescription * [])
> ...
All three variations occur in the code: no space, space on both sides,
space only on the left.
> So, I keep the same style. Should I change it to "const VMStateDescription *[]"?
Dropping the change to savevm.c should be fine.
Changing it to "VMStateDescription *[]" should be also fine.
I figure you can keep David's R-by in both cases.
[...]
next prev parent reply other threads:[~2020-10-19 11:59 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 13:08 [PATCH v2 0/8] Fix some style problems in migration Bihong Yu
2020-10-12 13:08 ` Bihong Yu
2020-10-12 13:08 ` [PATCH v2 1/8] migration: Do not use C99 // comments Bihong Yu
2020-10-12 13:08 ` Bihong Yu
2020-10-13 9:39 ` Dr. David Alan Gilbert
2020-10-13 9:39 ` Dr. David Alan Gilbert
2020-10-13 13:20 ` Bihong Yu
2020-10-13 13:20 ` Bihong Yu
2020-10-14 1:29 ` Zheng Chuan
2020-10-14 1:29 ` Zheng Chuan
2020-10-14 1:36 ` Bihong Yu
2020-10-14 1:36 ` Bihong Yu
2020-10-12 13:08 ` [PATCH v2 2/8] migration: Don't use '#' flag of printf format Bihong Yu
2020-10-12 13:08 ` Bihong Yu
2020-10-14 19:27 ` Dr. David Alan Gilbert
2020-10-14 19:27 ` Dr. David Alan Gilbert
2020-10-20 6:46 ` Philippe Mathieu-Daudé
2020-10-20 6:46 ` Philippe Mathieu-Daudé
2020-10-12 13:08 ` [PATCH v2 3/8] migration: Add spaces around operator Bihong Yu
2020-10-12 13:08 ` Bihong Yu
2020-10-13 10:10 ` Dr. David Alan Gilbert
2020-10-13 10:10 ` Dr. David Alan Gilbert
2020-10-19 8:24 ` Markus Armbruster
2020-10-19 8:24 ` Markus Armbruster
2020-10-19 9:43 ` Bihong Yu
2020-10-19 9:43 ` Bihong Yu
2020-10-19 11:59 ` Markus Armbruster [this message]
2020-10-19 11:59 ` Markus Armbruster
2020-10-20 2:47 ` Bihong Yu
2020-10-20 2:47 ` Bihong Yu
2020-10-12 13:08 ` [PATCH v2 4/8] migration: Open brace '{' following struct go on the same line Bihong Yu
2020-10-12 13:08 ` Bihong Yu
2020-10-13 13:33 ` Dr. David Alan Gilbert
2020-10-13 13:33 ` Dr. David Alan Gilbert
2020-10-12 13:08 ` [PATCH v2 5/8] migration: Add braces {} for if statement Bihong Yu
2020-10-12 13:08 ` Bihong Yu
2020-10-14 19:17 ` Dr. David Alan Gilbert
2020-10-14 19:17 ` Dr. David Alan Gilbert
2020-10-20 6:47 ` Philippe Mathieu-Daudé
2020-10-20 6:47 ` Philippe Mathieu-Daudé
2020-10-12 13:08 ` [PATCH v2 6/8] migration: Do not initialise statics and globals to 0 or NULL Bihong Yu
2020-10-12 13:08 ` Bihong Yu
2020-10-14 19:21 ` Dr. David Alan Gilbert
2020-10-14 19:21 ` Dr. David Alan Gilbert
2020-10-20 6:50 ` Philippe Mathieu-Daudé
2020-10-20 6:50 ` Philippe Mathieu-Daudé
2020-10-12 13:08 ` [PATCH v2 7/8] migration: Open brace '{' following function declarations go on the next line Bihong Yu
2020-10-12 13:08 ` Bihong Yu
2020-10-14 19:26 ` Dr. David Alan Gilbert
2020-10-14 19:26 ` Dr. David Alan Gilbert
2020-10-12 13:09 ` [PATCH v2 8/8] migration: Delete redundant spaces Bihong Yu
2020-10-12 13:09 ` Bihong Yu
2020-10-14 19:14 ` Dr. David Alan Gilbert
2020-10-14 19:14 ` Dr. David Alan Gilbert
2020-10-20 6:50 ` Philippe Mathieu-Daudé
2020-10-20 6:50 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7qq4ea4.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.chen@huawei.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=wanghao232@huawei.com \
--cc=yubihong@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.