From: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
idosch@mellanox.com, jiri@mellanox.com, nikolay@nvidia.com,
roopa@nvidia.com, Horatiu Vultur <horatiu.vultur@microchip.com>,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.
Date: Thu, 15 Oct 2020 11:28:22 +0000 [thread overview]
Message-ID: <20201015112822.adfl5kpgffgzi3wg@soft-test08> (raw)
In-Reply-To: <20201014161610.46dd5785@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Thanks for your review. Comments below.
Regards
Henrik
The 10/14/2020 16:16, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Mon, 12 Oct 2020 14:04:24 +0000 Henrik Bjoernlund wrote:
> > +struct br_cfm_status_tlv {
> > + __u8 type;
> > + __be16 length;
> > + __u8 value;
> > +};
>
> This structure is unused (and likely not what you want, since it will
> have 2 1 byte while unless you mark length as __packed).
I have changed as requested.
--
/Henrik
WARNING: multiple messages have this Message-ID (diff)
From: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <roopa@nvidia.com>, <nikolay@nvidia.com>,
<jiri@mellanox.com>, <idosch@mellanox.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<bridge@lists.linux-foundation.org>,
<UNGLinuxDriver@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.
Date: Thu, 15 Oct 2020 11:28:22 +0000 [thread overview]
Message-ID: <20201015112822.adfl5kpgffgzi3wg@soft-test08> (raw)
In-Reply-To: <20201014161610.46dd5785@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Thanks for your review. Comments below.
Regards
Henrik
The 10/14/2020 16:16, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Mon, 12 Oct 2020 14:04:24 +0000 Henrik Bjoernlund wrote:
> > +struct br_cfm_status_tlv {
> > + __u8 type;
> > + __be16 length;
> > + __u8 value;
> > +};
>
> This structure is unused (and likely not what you want, since it will
> have 2 1 byte while unless you mark length as __packed).
I have changed as requested.
--
/Henrik
next prev parent reply other threads:[~2020-10-15 11:28 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 14:04 [Bridge] [PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM) Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 01/10] net: bridge: extend the process of special frames Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 10:50 ` [Bridge] " Nikolay Aleksandrov
2020-10-14 10:50 ` Nikolay Aleksandrov
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 23:00 ` [Bridge] " Jakub Kicinski
2020-10-14 23:00 ` Jakub Kicinski
2020-10-15 11:26 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:26 ` Henrik Bjoernlund
2020-10-14 23:30 ` [Bridge] " Jakub Kicinski
2020-10-14 23:30 ` Jakub Kicinski
2020-10-15 11:26 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:26 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 22:59 ` [Bridge] " Jakub Kicinski
2020-10-14 22:59 ` Jakub Kicinski
2020-10-15 11:28 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:28 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 23:16 ` [Bridge] " Jakub Kicinski
2020-10-14 23:16 ` Jakub Kicinski
2020-10-15 11:28 ` Henrik Bjoernlund [this message]
2020-10-15 11:28 ` Henrik Bjoernlund
2020-10-14 23:26 ` [Bridge] " Jakub Kicinski
2020-10-14 23:26 ` Jakub Kicinski
2020-10-15 11:27 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:27 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 07/10] bridge: cfm: Netlink SET configuration Interface Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 08/10] bridge: cfm: Netlink GET " Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 10:54 ` [Bridge] " Nikolay Aleksandrov
2020-10-14 10:54 ` Nikolay Aleksandrov
2020-10-15 11:24 ` [Bridge] " henrik.bjoernlund
2020-10-15 11:24 ` henrik.bjoernlund
2020-10-14 23:33 ` [Bridge] " Jakub Kicinski
2020-10-14 23:33 ` Jakub Kicinski
2020-10-15 11:24 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:24 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 09/10] bridge: cfm: Netlink GET status Interface Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 11:24 ` [Bridge] " Nikolay Aleksandrov
2020-10-14 11:24 ` Nikolay Aleksandrov
2020-10-15 11:33 ` [Bridge] " henrik.bjoernlund
2020-10-15 11:33 ` henrik.bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 10/10] bridge: cfm: Netlink Notifications Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 22:58 ` [Bridge] [PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM) Jakub Kicinski
2020-10-14 22:58 ` Jakub Kicinski
2020-10-15 11:32 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:32 ` Henrik Bjoernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015112822.adfl5kpgffgzi3wg@soft-test08 \
--to=henrik.bjoernlund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=horatiu.vultur@microchip.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.