From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: "bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
"henrik.bjoernlund@microchip.com"
<henrik.bjoernlund@microchip.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jiri@mellanox.com" <jiri@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Roopa Prabhu <roopa@nvidia.com>,
"idosch@mellanox.com" <idosch@mellanox.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>
Cc: "horatiu.vultur@microchip.com" <horatiu.vultur@microchip.com>
Subject: Re: [Bridge] [PATCH net-next v5 01/10] net: bridge: extend the process of special frames
Date: Wed, 14 Oct 2020 10:50:38 +0000 [thread overview]
Message-ID: <8804be4ea95ea61eabd030eff51ca5116512d184.camel@nvidia.com> (raw)
In-Reply-To: <20201012140428.2549163-2-henrik.bjoernlund@microchip.com>
On Mon, 2020-10-12 at 14:04 +0000, Henrik Bjoernlund wrote:
> This patch extends the processing of frames in the bridge. Currently MRP
> frames needs special processing and the current implementation doesn't
> allow a nice way to process different frame types. Therefore try to
> improve this by adding a list that contains frame types that need
> special processing. This list is iterated for each input frame and if
> there is a match based on frame type then these functions will be called
> and decide what to do with the frame. It can process the frame then the
> bridge doesn't need to do anything or don't process so then the bridge
> will do normal forwarding.
>
> Signed-off-by: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> net/bridge/br_device.c | 1 +
> net/bridge/br_input.c | 33 ++++++++++++++++++++++++++++++++-
> net/bridge/br_mrp.c | 19 +++++++++++++++----
> net/bridge/br_private.h | 19 ++++++++++++-------
> 4 files changed, 60 insertions(+), 12 deletions(-)
>
Looks good.
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: "bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
"henrik.bjoernlund@microchip.com"
<henrik.bjoernlund@microchip.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jiri@mellanox.com" <jiri@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Roopa Prabhu <roopa@nvidia.com>,
"idosch@mellanox.com" <idosch@mellanox.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>
Cc: "horatiu.vultur@microchip.com" <horatiu.vultur@microchip.com>
Subject: Re: [PATCH net-next v5 01/10] net: bridge: extend the process of special frames
Date: Wed, 14 Oct 2020 10:50:38 +0000 [thread overview]
Message-ID: <8804be4ea95ea61eabd030eff51ca5116512d184.camel@nvidia.com> (raw)
In-Reply-To: <20201012140428.2549163-2-henrik.bjoernlund@microchip.com>
On Mon, 2020-10-12 at 14:04 +0000, Henrik Bjoernlund wrote:
> This patch extends the processing of frames in the bridge. Currently MRP
> frames needs special processing and the current implementation doesn't
> allow a nice way to process different frame types. Therefore try to
> improve this by adding a list that contains frame types that need
> special processing. This list is iterated for each input frame and if
> there is a match based on frame type then these functions will be called
> and decide what to do with the frame. It can process the frame then the
> bridge doesn't need to do anything or don't process so then the bridge
> will do normal forwarding.
>
> Signed-off-by: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> net/bridge/br_device.c | 1 +
> net/bridge/br_input.c | 33 ++++++++++++++++++++++++++++++++-
> net/bridge/br_mrp.c | 19 +++++++++++++++----
> net/bridge/br_private.h | 19 ++++++++++++-------
> 4 files changed, 60 insertions(+), 12 deletions(-)
>
Looks good.
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
next prev parent reply other threads:[~2020-10-14 10:50 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 14:04 [Bridge] [PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM) Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 01/10] net: bridge: extend the process of special frames Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 10:50 ` Nikolay Aleksandrov [this message]
2020-10-14 10:50 ` Nikolay Aleksandrov
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 23:00 ` [Bridge] " Jakub Kicinski
2020-10-14 23:00 ` Jakub Kicinski
2020-10-15 11:26 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:26 ` Henrik Bjoernlund
2020-10-14 23:30 ` [Bridge] " Jakub Kicinski
2020-10-14 23:30 ` Jakub Kicinski
2020-10-15 11:26 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:26 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 22:59 ` [Bridge] " Jakub Kicinski
2020-10-14 22:59 ` Jakub Kicinski
2020-10-15 11:28 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:28 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 23:16 ` [Bridge] " Jakub Kicinski
2020-10-14 23:16 ` Jakub Kicinski
2020-10-15 11:28 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:28 ` Henrik Bjoernlund
2020-10-14 23:26 ` [Bridge] " Jakub Kicinski
2020-10-14 23:26 ` Jakub Kicinski
2020-10-15 11:27 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:27 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 07/10] bridge: cfm: Netlink SET configuration Interface Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 08/10] bridge: cfm: Netlink GET " Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 10:54 ` [Bridge] " Nikolay Aleksandrov
2020-10-14 10:54 ` Nikolay Aleksandrov
2020-10-15 11:24 ` [Bridge] " henrik.bjoernlund
2020-10-15 11:24 ` henrik.bjoernlund
2020-10-14 23:33 ` [Bridge] " Jakub Kicinski
2020-10-14 23:33 ` Jakub Kicinski
2020-10-15 11:24 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:24 ` Henrik Bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 09/10] bridge: cfm: Netlink GET status Interface Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 11:24 ` [Bridge] " Nikolay Aleksandrov
2020-10-14 11:24 ` Nikolay Aleksandrov
2020-10-15 11:33 ` [Bridge] " henrik.bjoernlund
2020-10-15 11:33 ` henrik.bjoernlund
2020-10-12 14:04 ` [Bridge] [PATCH net-next v5 10/10] bridge: cfm: Netlink Notifications Henrik Bjoernlund
2020-10-12 14:04 ` Henrik Bjoernlund
2020-10-14 22:58 ` [Bridge] [PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM) Jakub Kicinski
2020-10-14 22:58 ` Jakub Kicinski
2020-10-15 11:32 ` [Bridge] " Henrik Bjoernlund
2020-10-15 11:32 ` Henrik Bjoernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8804be4ea95ea61eabd030eff51ca5116512d184.camel@nvidia.com \
--to=nikolay@nvidia.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=henrik.bjoernlund@microchip.com \
--cc=horatiu.vultur@microchip.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.