From: Billy Tsai <billy_tsai@aspeedtech.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] gpio: aspeed: fix ast2600 bank properties
Date: Mon, 19 Oct 2020 12:50:26 +0800 [thread overview]
Message-ID: <20201019045026.10732-1-billy_tsai@aspeedtech.com> (raw)
GPIO_T is mapped to the most significant byte of input/output mask, and
the byte in "output" mask should be 0 because GPIO_T is input only. All
the other bits need to be 1 because GPIO_Q/R/S support both input and
output modes.
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
drivers/gpio/gpio-aspeed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index d07bf2c3f136..f24754b3f6d1 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =
static const struct aspeed_bank_props ast2600_bank_props[] = {
/* input output */
+ {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */
{5, 0xffffffff, 0xffffff00}, /* U/V/W/X */
{6, 0x0000ffff, 0x0000ffff}, /* Y/Z */
{ },
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Billy Tsai <billy_tsai@aspeedtech.com>
To: <linus.walleij@linaro.org>, <rentao.bupt@gmail.com>,
<bgolaszewski@baylibre.com>, <joel@jms.id.au>, <andrew@aj.id.au>,
<linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-aspeed@lists.ozlabs.org>
Cc: <BMC-SW@aspeedtech.com>
Subject: [PATCH] gpio: aspeed: fix ast2600 bank properties
Date: Mon, 19 Oct 2020 12:50:26 +0800 [thread overview]
Message-ID: <20201019045026.10732-1-billy_tsai@aspeedtech.com> (raw)
GPIO_T is mapped to the most significant byte of input/output mask, and
the byte in "output" mask should be 0 because GPIO_T is input only. All
the other bits need to be 1 because GPIO_Q/R/S support both input and
output modes.
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
drivers/gpio/gpio-aspeed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index d07bf2c3f136..f24754b3f6d1 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =
static const struct aspeed_bank_props ast2600_bank_props[] = {
/* input output */
+ {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */
{5, 0xffffffff, 0xffffff00}, /* U/V/W/X */
{6, 0x0000ffff, 0x0000ffff}, /* Y/Z */
{ },
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Billy Tsai <billy_tsai@aspeedtech.com>
To: <linus.walleij@linaro.org>, <rentao.bupt@gmail.com>,
<bgolaszewski@baylibre.com>, <joel@jms.id.au>, <andrew@aj.id.au>,
<linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-aspeed@lists.ozlabs.org>
Cc: BMC-SW@aspeedtech.com
Subject: [PATCH] gpio: aspeed: fix ast2600 bank properties
Date: Mon, 19 Oct 2020 12:50:26 +0800 [thread overview]
Message-ID: <20201019045026.10732-1-billy_tsai@aspeedtech.com> (raw)
GPIO_T is mapped to the most significant byte of input/output mask, and
the byte in "output" mask should be 0 because GPIO_T is input only. All
the other bits need to be 1 because GPIO_Q/R/S support both input and
output modes.
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
drivers/gpio/gpio-aspeed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index d07bf2c3f136..f24754b3f6d1 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =
static const struct aspeed_bank_props ast2600_bank_props[] = {
/* input output */
+ {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */
{5, 0xffffffff, 0xffffff00}, /* U/V/W/X */
{6, 0x0000ffff, 0x0000ffff}, /* Y/Z */
{ },
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-10-19 4:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 4:50 Billy Tsai [this message]
2020-10-19 4:50 ` [PATCH] gpio: aspeed: fix ast2600 bank properties Billy Tsai
2020-10-19 4:50 ` Billy Tsai
2020-10-19 5:33 ` Tao Ren
2020-10-19 5:33 ` Tao Ren
2020-10-19 5:33 ` Tao Ren
2020-10-19 7:29 ` Joel Stanley
2020-10-19 7:29 ` Joel Stanley
2020-10-19 7:29 ` Joel Stanley
2020-10-21 23:38 ` Andrew Jeffery
2020-10-21 23:38 ` Andrew Jeffery
2020-10-21 23:38 ` Andrew Jeffery
2020-10-26 14:53 ` Bartosz Golaszewski
2020-10-26 14:53 ` Bartosz Golaszewski
2020-10-26 14:53 ` Bartosz Golaszewski
-- strict thread matches above, loose matches on Subject: below --
2020-09-16 20:42 rentao.bupt
2020-09-16 20:42 ` rentao.bupt
2020-09-16 20:42 ` rentao.bupt
2020-09-16 23:12 ` Andrew Jeffery
2020-09-16 23:12 ` Andrew Jeffery
2020-09-16 23:12 ` Andrew Jeffery
2020-09-18 4:18 ` Tao Ren
2020-09-18 4:18 ` Tao Ren
2020-09-18 4:18 ` Tao Ren
2020-09-24 13:37 ` Bartosz Golaszewski
2020-09-24 13:37 ` Bartosz Golaszewski
2020-09-24 13:37 ` Bartosz Golaszewski
2020-09-24 13:37 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019045026.10732-1-billy_tsai@aspeedtech.com \
--to=billy_tsai@aspeedtech.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.