From: Andrew Jeffery <andrew@aj.id.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] gpio: aspeed: fix ast2600 bank properties
Date: Thu, 17 Sep 2020 08:42:27 +0930 [thread overview]
Message-ID: <60f9f14a-c9be-45ac-b3a8-516ab73d9bee@www.fastmail.com> (raw)
In-Reply-To: <20200916204216.9423-1-rentao.bupt@gmail.com>
On Thu, 17 Sep 2020, at 06:12, rentao.bupt at gmail.com wrote:
> From: Tao Ren <rentao.bupt@gmail.com>
>
> GPIO_U is mapped to the least significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_U is input only. All
> the other bits need to be 1 because GPIO_V/W/X support both input and
> output modes.
>
> Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
> according bits need to be 1 because GPIO_Y/Z support both input and
> output modes.
>
> Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
> Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
Thanks Tao,
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Tao Ren" <rentao.bupt@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Joel Stanley" <joel@jms.id.au>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, "Tao Ren" <taoren@fb.com>
Subject: Re: [PATCH] gpio: aspeed: fix ast2600 bank properties
Date: Thu, 17 Sep 2020 08:42:27 +0930 [thread overview]
Message-ID: <60f9f14a-c9be-45ac-b3a8-516ab73d9bee@www.fastmail.com> (raw)
In-Reply-To: <20200916204216.9423-1-rentao.bupt@gmail.com>
On Thu, 17 Sep 2020, at 06:12, rentao.bupt@gmail.com wrote:
> From: Tao Ren <rentao.bupt@gmail.com>
>
> GPIO_U is mapped to the least significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_U is input only. All
> the other bits need to be 1 because GPIO_V/W/X support both input and
> output modes.
>
> Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
> according bits need to be 1 because GPIO_Y/Z support both input and
> output modes.
>
> Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
> Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
Thanks Tao,
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Tao Ren" <rentao.bupt@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Joel Stanley" <joel@jms.id.au>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, "Tao Ren" <taoren@fb.com>
Subject: Re: [PATCH] gpio: aspeed: fix ast2600 bank properties
Date: Thu, 17 Sep 2020 08:42:27 +0930 [thread overview]
Message-ID: <60f9f14a-c9be-45ac-b3a8-516ab73d9bee@www.fastmail.com> (raw)
In-Reply-To: <20200916204216.9423-1-rentao.bupt@gmail.com>
On Thu, 17 Sep 2020, at 06:12, rentao.bupt@gmail.com wrote:
> From: Tao Ren <rentao.bupt@gmail.com>
>
> GPIO_U is mapped to the least significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_U is input only. All
> the other bits need to be 1 because GPIO_V/W/X support both input and
> output modes.
>
> Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
> according bits need to be 1 because GPIO_Y/Z support both input and
> output modes.
>
> Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
> Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
Thanks Tao,
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-16 23:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 20:42 [PATCH] gpio: aspeed: fix ast2600 bank properties rentao.bupt
2020-09-16 20:42 ` rentao.bupt
2020-09-16 20:42 ` rentao.bupt
2020-09-16 23:12 ` Andrew Jeffery [this message]
2020-09-16 23:12 ` Andrew Jeffery
2020-09-16 23:12 ` Andrew Jeffery
2020-09-18 4:18 ` Tao Ren
2020-09-18 4:18 ` Tao Ren
2020-09-18 4:18 ` Tao Ren
2020-09-24 13:37 ` Bartosz Golaszewski
2020-09-24 13:37 ` Bartosz Golaszewski
2020-09-24 13:37 ` Bartosz Golaszewski
2020-09-24 13:37 ` Bartosz Golaszewski
-- strict thread matches above, loose matches on Subject: below --
2020-10-19 4:50 Billy Tsai
2020-10-19 4:50 ` Billy Tsai
2020-10-19 4:50 ` Billy Tsai
2020-10-19 5:33 ` Tao Ren
2020-10-19 5:33 ` Tao Ren
2020-10-19 5:33 ` Tao Ren
2020-10-19 7:29 ` Joel Stanley
2020-10-19 7:29 ` Joel Stanley
2020-10-19 7:29 ` Joel Stanley
2020-10-21 23:38 ` Andrew Jeffery
2020-10-21 23:38 ` Andrew Jeffery
2020-10-21 23:38 ` Andrew Jeffery
2020-10-26 14:53 ` Bartosz Golaszewski
2020-10-26 14:53 ` Bartosz Golaszewski
2020-10-26 14:53 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f9f14a-c9be-45ac-b3a8-516ab73d9bee@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.