* [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined
@ 2020-06-21 20:43 Paul Barker
2020-06-29 22:43 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: Paul Barker @ 2020-06-21 20:43 UTC (permalink / raw)
To: meta-arago
Signed-off-by: Paul Barker <pbarker@konsulko.com>
---
.../recipes-kernel/linux/copy-defconfig.inc | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
index 10ecf8ea..65b615cb 100644
--- a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
+++ b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
@@ -17,6 +17,9 @@ do_configure_append() {
fi
}
-# Move create_srcipk task so that the release defconfig is included.
-deltask do_create_srcipk
-addtask create_srcipk after do_configure before do_compile
+python __anonymous() {
+ # Move create_srcipk task so that the release defconfig is included.
+ if d.getVarFlag('do_create_srcipk', "task"):
+ bb.build.deltask('do_create_srcipk', d)
+ bb.build.addtask('do_create_srcipk', 'do_configure', 'do_compile', d)
+}
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined
2020-06-21 20:43 [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined Paul Barker
@ 2020-06-29 22:43 ` Denys Dmytriyenko
2020-06-30 21:30 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2020-06-29 22:43 UTC (permalink / raw)
To: Paul Barker; +Cc: meta-arago
Thanks, will merge it shortly.
On Sun, Jun 21, 2020 at 09:43:49PM +0100, Paul Barker wrote:
> Signed-off-by: Paul Barker <pbarker@konsulko.com>
> ---
> .../recipes-kernel/linux/copy-defconfig.inc | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> index 10ecf8ea..65b615cb 100644
> --- a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> +++ b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> @@ -17,6 +17,9 @@ do_configure_append() {
> fi
> }
>
> -# Move create_srcipk task so that the release defconfig is included.
> -deltask do_create_srcipk
> -addtask create_srcipk after do_configure before do_compile
> +python __anonymous() {
> + # Move create_srcipk task so that the release defconfig is included.
> + if d.getVarFlag('do_create_srcipk', "task"):
> + bb.build.deltask('do_create_srcipk', d)
> + bb.build.addtask('do_create_srcipk', 'do_configure', 'do_compile', d)
> +}
> --
> 2.27.0
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined
2020-06-29 22:43 ` Denys Dmytriyenko
@ 2020-06-30 21:30 ` Denys Dmytriyenko
2020-08-14 22:30 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2020-06-30 21:30 UTC (permalink / raw)
To: Paul Barker; +Cc: meta-arago
That doesn't work:
ERROR: 351 unbuildable tasks were found.
These are usually caused by circular dependencies and any circular dependency chains found will be printed below. Increase the debug level to see a list of unbuildable tasks.
Identifying dependency loops (this may take a short while)...
ERROR:
Dependency loop #1 found:
Task /OE/arago-dunfell/sources/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:do_compile (dependent Tasks ['linux-ti-staging_5.4.bb:do_configure'])
Task /OE/arago-dunfell/sources/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:do_create_srcipk (dependent Tasks ['external-arm-toolchain.bb:do_patch', 'bc_1.07.1.bb:do_patch', 'bison_3.5.3.bb:do_patch', 'kmod-native_git.bb:do_patch', 'lzop_1.04.bb:do_patch', 'linux-ti-staging_5.4.bb:do_compile'])
Task /OE/arago-dunfell/sources/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:do_configure (dependent Tasks ['linux-ti-staging_5.4.bb:do_prepare_recipe_sysroot', 'linux-ti-staging_5.4.bb:do_patch', 'linux-ti-staging_5.4.bb:do_symlink_kernsrc', 'linux-ti-staging_5.4.bb:do_unpack', 'linux-ti-staging_5.4.bb:do_create_srcipk'])
ERROR: Command execution failed: 1
On Mon, Jun 29, 2020 at 06:43:51PM -0400, Denys Dmytriyenko wrote:
> Thanks, will merge it shortly.
>
> On Sun, Jun 21, 2020 at 09:43:49PM +0100, Paul Barker wrote:
> > Signed-off-by: Paul Barker <pbarker@konsulko.com>
> > ---
> > .../recipes-kernel/linux/copy-defconfig.inc | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> > index 10ecf8ea..65b615cb 100644
> > --- a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> > +++ b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> > @@ -17,6 +17,9 @@ do_configure_append() {
> > fi
> > }
> >
> > -# Move create_srcipk task so that the release defconfig is included.
> > -deltask do_create_srcipk
> > -addtask create_srcipk after do_configure before do_compile
> > +python __anonymous() {
> > + # Move create_srcipk task so that the release defconfig is included.
> > + if d.getVarFlag('do_create_srcipk', "task"):
> > + bb.build.deltask('do_create_srcipk', d)
> > + bb.build.addtask('do_create_srcipk', 'do_configure', 'do_compile', d)
> > +}
> > --
> > 2.27.0
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined
2020-06-30 21:30 ` Denys Dmytriyenko
@ 2020-08-14 22:30 ` Denys Dmytriyenko
2020-10-19 19:12 ` Paul Barker
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2020-08-14 22:30 UTC (permalink / raw)
To: Paul Barker; +Cc: meta-arago
Ping.
In case this was missed - the submitted patch was causing a breakage and was
not merged. Thanks.
On Tue, Jun 30, 2020 at 05:30:41PM -0400, Denys Dmytriyenko wrote:
> That doesn't work:
>
> ERROR: 351 unbuildable tasks were found.
> These are usually caused by circular dependencies and any circular dependency chains found will be printed below. Increase the debug level to see a list of unbuildable tasks.
>
> Identifying dependency loops (this may take a short while)...
>
> ERROR:
> Dependency loop #1 found:
> Task /OE/arago-dunfell/sources/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:do_compile (dependent Tasks ['linux-ti-staging_5.4.bb:do_configure'])
> Task /OE/arago-dunfell/sources/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:do_create_srcipk (dependent Tasks ['external-arm-toolchain.bb:do_patch', 'bc_1.07.1.bb:do_patch', 'bison_3.5.3.bb:do_patch', 'kmod-native_git.bb:do_patch', 'lzop_1.04.bb:do_patch', 'linux-ti-staging_5.4.bb:do_compile'])
> Task /OE/arago-dunfell/sources/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:do_configure (dependent Tasks ['linux-ti-staging_5.4.bb:do_prepare_recipe_sysroot', 'linux-ti-staging_5.4.bb:do_patch', 'linux-ti-staging_5.4.bb:do_symlink_kernsrc', 'linux-ti-staging_5.4.bb:do_unpack', 'linux-ti-staging_5.4.bb:do_create_srcipk'])
>
>
> ERROR: Command execution failed: 1
>
>
> On Mon, Jun 29, 2020 at 06:43:51PM -0400, Denys Dmytriyenko wrote:
> > Thanks, will merge it shortly.
> >
> > On Sun, Jun 21, 2020 at 09:43:49PM +0100, Paul Barker wrote:
> > > Signed-off-by: Paul Barker <pbarker@konsulko.com>
> > > ---
> > > .../recipes-kernel/linux/copy-defconfig.inc | 9 ++++++---
> > > 1 file changed, 6 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> > > index 10ecf8ea..65b615cb 100644
> > > --- a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> > > +++ b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> > > @@ -17,6 +17,9 @@ do_configure_append() {
> > > fi
> > > }
> > >
> > > -# Move create_srcipk task so that the release defconfig is included.
> > > -deltask do_create_srcipk
> > > -addtask create_srcipk after do_configure before do_compile
> > > +python __anonymous() {
> > > + # Move create_srcipk task so that the release defconfig is included.
> > > + if d.getVarFlag('do_create_srcipk', "task"):
> > > + bb.build.deltask('do_create_srcipk', d)
> > > + bb.build.addtask('do_create_srcipk', 'do_configure', 'do_compile', d)
> > > +}
> > > --
> > > 2.27.0
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined
2020-08-14 22:30 ` Denys Dmytriyenko
@ 2020-10-19 19:12 ` Paul Barker
2020-10-19 19:56 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: Paul Barker @ 2020-10-19 19:12 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-arago
On Fri, 14 Aug 2020 at 23:30, Denys Dmytriyenko <denys@ti.com> wrote:
>
> Ping.
>
> In case this was missed - the submitted patch was causing a breakage and was
> not merged. Thanks.
Hi Denys, I've not had a chance to get back to this one for a long
time due to illness and other priorities coming up. I've finally taken
a long look at it to find out why my builds were failing without this
patch back in June but seem to be fine without it now. I somehow ended
up with my CI system populating local.conf incorrectly so DISTRO was
set to poky but all the arago layers were included. The resulting
error messages were:
ERROR: /w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:
Task do_create_srcipk from
/w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb seems
to be empty?!
ERROR: /w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging-systest_5.4.bb:
Task do_create_srcipk from
/w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging-systest_5.4.bb
seems to be empty?!
ERROR: /w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging-rt_5.4.bb:
Task do_create_srcipk from
/w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging-rt_5.4.bb
seems to be empty?!
Should we support the case where the meta-arago-distro layer is
included but a different DISTRO is chosen? If so I can resubmit this,
the patch was broken as I mixed up the arguments to bb.build.addtask()
so it's easy to fix.
Thanks,
--
Paul Barker
Konsulko Group
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined
2020-10-19 19:12 ` Paul Barker
@ 2020-10-19 19:56 ` Denys Dmytriyenko
0 siblings, 0 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2020-10-19 19:56 UTC (permalink / raw)
To: Paul Barker; +Cc: meta-arago
On Mon, Oct 19, 2020 at 08:12:05PM +0100, Paul Barker wrote:
> On Fri, 14 Aug 2020 at 23:30, Denys Dmytriyenko <denys@ti.com> wrote:
> >
> > Ping.
> >
> > In case this was missed - the submitted patch was causing a breakage and was
> > not merged. Thanks.
>
> Hi Denys, I've not had a chance to get back to this one for a long
> time due to illness and other priorities coming up. I've finally taken
> a long look at it to find out why my builds were failing without this
> patch back in June but seem to be fine without it now. I somehow ended
> up with my CI system populating local.conf incorrectly so DISTRO was
> set to poky but all the arago layers were included. The resulting
> error messages were:
>
> ERROR: /w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:
> Task do_create_srcipk from
> /w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb seems
> to be empty?!
> ERROR: /w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging-systest_5.4.bb:
> Task do_create_srcipk from
> /w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging-systest_5.4.bb
> seems to be empty?!
> ERROR: /w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging-rt_5.4.bb:
> Task do_create_srcipk from
> /w/layers/meta-ti/recipes-kernel/linux/linux-ti-staging-rt_5.4.bb
> seems to be empty?!
>
> Should we support the case where the meta-arago-distro layer is
> included but a different DISTRO is chosen? If so I can resubmit this,
> the patch was broken as I mixed up the arguments to bb.build.addtask()
> so it's easy to fix.
Thanks, Paul.
Ultimately, it might be possible to support multi-distro setup and ensure that
distro-specific changes only get applied if corresponding DISTRO is selected.
But, this hasn't been a priority when developing Arago distro - it started
before Yocto Project came out, since OE Classic/Angstrom days.
On the other hand, meta-ti BSP does support usage in multi-BSP setups and
extra care has been taken to ensure that. Not so much for meta-arago,
unfortunately. So, right now including Arago distro with a different
DISTRO setting is not officially support and is probably not something to
be resolved in the near future.
--
Denys
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-19 19:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-21 20:43 [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined Paul Barker
2020-06-29 22:43 ` Denys Dmytriyenko
2020-06-30 21:30 ` Denys Dmytriyenko
2020-08-14 22:30 ` Denys Dmytriyenko
2020-10-19 19:12 ` Paul Barker
2020-10-19 19:56 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.