From: Rob Herring <robh@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs
Date: Mon, 19 Oct 2020 15:48:21 -0500 [thread overview]
Message-ID: <20201019204821.GA3569507@bogus> (raw)
In-Reply-To: <b3376cd4-010f-cf72-8c81-1f5d22cb6454@opensource.cirrus.com>
On Fri, Oct 16, 2020 at 02:30:08PM +0100, Richard Fitzgerald wrote:
> On 14/10/2020 19:56, Mark Brown wrote:
> > On Wed, Oct 14, 2020 at 03:54:11PM +0100, Richard Fitzgerald wrote:
> > > This set of patches provides support for using the Cirrus Logic
> > > Lochnagar audio development platform plus Cirrus Logic Madera/Arizona
> > > codecs with the simple-card machine driver and a Raspberry Pi4. The
> > > ultimate aim is to provide the dts file but some updates are needed to
> > > the simple-card machine driver.
> >
> > Why extend simple-card and not the more modern and flexible
> > audio-graph-card?
> >
>
> I'm struggling to understand how to use audio-graph-card where there are
> multiple alternative codecs. The host I2S endpoint has to point back to
> the codec endpoint, like this:
>
> cpu_i2s_ep_cs47l15: endpoint {
> remote-endpoint = <&cs47l15_aif1>;
> };
>
> But obviously that depends on which codec node was enabled. Listing
> multiple endpoints makes the whole port node disabled if any remote
> endpoint is in a disabled node. I've tried adding status="disabled"
> to endpoints or multiple port definitions with status="disabled" but
> I haven't figured out a solution.
Multiple endpoints is what you should do. And 'status' goes in the
device nodes (not the graph nodes).
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs
Date: Mon, 19 Oct 2020 15:48:21 -0500 [thread overview]
Message-ID: <20201019204821.GA3569507@bogus> (raw)
In-Reply-To: <b3376cd4-010f-cf72-8c81-1f5d22cb6454@opensource.cirrus.com>
On Fri, Oct 16, 2020 at 02:30:08PM +0100, Richard Fitzgerald wrote:
> On 14/10/2020 19:56, Mark Brown wrote:
> > On Wed, Oct 14, 2020 at 03:54:11PM +0100, Richard Fitzgerald wrote:
> > > This set of patches provides support for using the Cirrus Logic
> > > Lochnagar audio development platform plus Cirrus Logic Madera/Arizona
> > > codecs with the simple-card machine driver and a Raspberry Pi4. The
> > > ultimate aim is to provide the dts file but some updates are needed to
> > > the simple-card machine driver.
> >
> > Why extend simple-card and not the more modern and flexible
> > audio-graph-card?
> >
>
> I'm struggling to understand how to use audio-graph-card where there are
> multiple alternative codecs. The host I2S endpoint has to point back to
> the codec endpoint, like this:
>
> cpu_i2s_ep_cs47l15: endpoint {
> remote-endpoint = <&cs47l15_aif1>;
> };
>
> But obviously that depends on which codec node was enabled. Listing
> multiple endpoints makes the whole port node disabled if any remote
> endpoint is in a disabled node. I've tried adding status="disabled"
> to endpoints or multiple port definitions with status="disabled" but
> I haven't figured out a solution.
Multiple endpoints is what you should do. And 'status' goes in the
device nodes (not the graph nodes).
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>,
nsaenzjulienne@suse.de, patches@opensource.cirrus.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs
Date: Mon, 19 Oct 2020 15:48:21 -0500 [thread overview]
Message-ID: <20201019204821.GA3569507@bogus> (raw)
In-Reply-To: <b3376cd4-010f-cf72-8c81-1f5d22cb6454@opensource.cirrus.com>
On Fri, Oct 16, 2020 at 02:30:08PM +0100, Richard Fitzgerald wrote:
> On 14/10/2020 19:56, Mark Brown wrote:
> > On Wed, Oct 14, 2020 at 03:54:11PM +0100, Richard Fitzgerald wrote:
> > > This set of patches provides support for using the Cirrus Logic
> > > Lochnagar audio development platform plus Cirrus Logic Madera/Arizona
> > > codecs with the simple-card machine driver and a Raspberry Pi4. The
> > > ultimate aim is to provide the dts file but some updates are needed to
> > > the simple-card machine driver.
> >
> > Why extend simple-card and not the more modern and flexible
> > audio-graph-card?
> >
>
> I'm struggling to understand how to use audio-graph-card where there are
> multiple alternative codecs. The host I2S endpoint has to point back to
> the codec endpoint, like this:
>
> cpu_i2s_ep_cs47l15: endpoint {
> remote-endpoint = <&cs47l15_aif1>;
> };
>
> But obviously that depends on which codec node was enabled. Listing
> multiple endpoints makes the whole port node disabled if any remote
> endpoint is in a disabled node. I've tried adding status="disabled"
> to endpoints or multiple port definitions with status="disabled" but
> I haven't figured out a solution.
Multiple endpoints is what you should do. And 'status' goes in the
device nodes (not the graph nodes).
Rob
next prev parent reply other threads:[~2020-10-19 20:49 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 14:54 [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 1/7] of: base: Add of_count_phandle_with_fixed_args() Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 18:39 ` Rob Herring
2020-10-14 18:39 ` Rob Herring
2020-10-14 18:39 ` Rob Herring
2020-10-15 16:52 ` Robin Murphy
2020-10-15 16:52 ` Robin Murphy
2020-10-15 16:52 ` Robin Murphy
2020-10-16 9:10 ` Richard Fitzgerald
2020-10-16 9:10 ` Richard Fitzgerald
2020-10-16 9:10 ` Richard Fitzgerald
2020-10-16 13:31 ` Rob Herring
2020-10-16 13:31 ` Rob Herring
2020-10-16 13:31 ` Rob Herring
2020-10-16 15:14 ` Richard Fitzgerald
2020-10-16 15:14 ` Richard Fitzgerald
2020-10-16 15:14 ` Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 2/7] ASoC: simple-card: Add plls and sysclks DT schema Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 3/7] ASoC: simple-card: Support setting component plls and sysclks Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 4/7] ASoC: arizona: Allow codecs to be selected from kernel config Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-15 0:19 ` kernel test robot
2020-10-15 0:19 ` kernel test robot
2020-10-15 0:19 ` kernel test robot
2020-10-15 0:19 ` kernel test robot
2020-10-14 14:54 ` [PATCH 5/7] ASoC: madera: " Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 6/7] ARM: dts: Add dts for Raspberry Pi 4 + Cirrus Logic Lochnagar2 Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-15 10:25 ` Nicolas Saenz Julienne
2020-10-15 10:25 ` Nicolas Saenz Julienne
2020-10-15 10:25 ` Nicolas Saenz Julienne
2020-10-15 11:14 ` Richard Fitzgerald
2020-10-15 11:14 ` Richard Fitzgerald
2020-10-15 11:14 ` Richard Fitzgerald
2020-10-15 15:12 ` Nicolas Saenz Julienne
2020-10-15 15:12 ` Nicolas Saenz Julienne
2020-10-15 15:12 ` Nicolas Saenz Julienne
2020-10-15 17:32 ` Mark Brown
2020-10-15 17:32 ` Mark Brown
2020-10-15 17:32 ` Mark Brown
2020-10-16 9:01 ` Richard Fitzgerald
2020-10-16 9:01 ` Richard Fitzgerald
2020-10-16 9:01 ` Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 7/7] MAINTAINERS: Add dts for Cirrus Logic Lochnagar on RPi4 Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 14:54 ` Richard Fitzgerald
2020-10-14 18:56 ` [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs Mark Brown
2020-10-14 18:56 ` Mark Brown
2020-10-14 18:56 ` Mark Brown
2020-10-16 13:30 ` Richard Fitzgerald
2020-10-16 13:30 ` Richard Fitzgerald
2020-10-16 13:30 ` Richard Fitzgerald
2020-10-16 15:18 ` Mark Brown
2020-10-16 15:18 ` Mark Brown
2020-10-16 15:18 ` Mark Brown
2020-10-19 20:48 ` Rob Herring [this message]
2020-10-19 20:48 ` Rob Herring
2020-10-19 20:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019204821.GA3569507@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.