From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>,
"Bradley M. Kuhn" <bkuhn@sfconservancy.org>,
git@vger.kernel.org
Subject: Re: [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by:
Date: Mon, 19 Oct 2020 22:31:38 -0400 [thread overview]
Message-ID: <20201020023138.GA54484@nand.local> (raw)
In-Reply-To: <xmqqy2k1dfoh.fsf@gitster.c.googlers.com>
On Mon, Oct 19, 2020 at 03:17:02PM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> > I think that the 3-patch series that Junio was talking about in [1] is
> > actually this one [2].
> > ...
> > [1]: https://lore.kernel.org/git/xmqqmu0it6ls.fsf@gitster.c.googlers.com/
> > [2]: https://lore.kernel.org/git/20201018194912.2716372-1-gitster@pobox.com/
>
> True.
>
> I actually think it is a bad idea to add ":" after every mention of
> "Signed-off-by"; it only looks clarifying because we use a boring
> and generic word "line" to refer to where that three-word token
> appears.
>
> We can say "a 'Signed-off-by' trailer" and it becomes plenty clear
> that we are not talking about any random line in the log message,
> and we do not need ":" everywhere, I suspect.
Mm. I may be in the minority that I think having ":" after
"Signed-off-by" is helpful, but I'm happy to go whichever way others
find most clear.
> Thanks.
Thanks,
Taylor
next prev parent reply other threads:[~2020-10-20 2:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 21:59 [PATCH 0/1] Clarify and expand description of --signoff Bradley M. Kuhn
2020-10-15 21:59 ` [PATCH 1/1] Documentation: " Bradley M. Kuhn
2020-10-16 0:46 ` Jeff King
2020-10-18 15:13 ` Theodore Y. Ts'o
2020-10-16 1:49 ` [PATCH 0/1] " Philippe Blain
2020-10-16 1:54 ` Junio C Hamano
2020-10-16 1:59 ` Jeff King
2020-10-16 2:30 ` Junio C Hamano
2020-10-16 19:53 ` Junio C Hamano
2020-10-16 20:11 ` Jeff King
2020-10-17 3:00 ` Bradley M. Kuhn
2020-10-18 19:08 ` Junio C Hamano
2020-10-19 15:53 ` Theodore Y. Ts'o
2020-10-19 18:26 ` Junio C Hamano
2020-10-19 21:25 ` [PATCH v2 0/3] clarify and expand description of --signoff & related fixes Bradley M. Kuhn
2020-10-19 21:25 ` [PATCH v2 1/3] Documentation: clarify and expand description of --signoff Bradley M. Kuhn
2020-10-19 21:25 ` [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn
2020-10-19 22:02 ` Taylor Blau
2020-10-19 22:17 ` Junio C Hamano
2020-10-20 1:03 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 1/4] doc: preparatory clean-up of description on the sign-off option Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 2/4] Documentation: clarify and expand description of --signoff Bradley M. Kuhn
2020-10-20 21:44 ` Bradley M. Kuhn
2020-10-20 21:48 ` Taylor Blau
2020-10-20 1:03 ` [PATCH v3 3/4] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 4/4] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn
2020-10-20 18:52 ` Junio C Hamano
2020-10-20 21:33 ` Bradley M. Kuhn
2020-10-20 2:34 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Taylor Blau
2020-10-20 21:28 ` Bradley M. Kuhn
2020-10-20 21:48 ` Taylor Blau
2020-10-20 22:06 ` Junio C Hamano
2020-10-20 23:02 ` Bradley M. Kuhn
2020-10-20 2:31 ` Taylor Blau [this message]
2020-10-19 21:25 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn
-- strict thread matches above, loose matches on Subject: below --
2020-10-18 19:49 [PATCH v2 0/3] Claryfing the meaning of the sign-off Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 1/3] doc: preparatory clean-up of description on the sign-off option Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 2/3] Documentation: clarify and expand description of --signoff Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Junio C Hamano
2020-10-18 23:31 ` [PATCH v2 0/3] Claryfing the meaning of the sign-off Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020023138.GA54484@nand.local \
--to=me@ttaylorr.com \
--cc=bkuhn@sfconservancy.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.