From: "Bradley M. Kuhn" <bkuhn@sfconservancy.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by
Date: Tue, 20 Oct 2020 16:02:15 -0700 [thread overview]
Message-ID: <20201020230215.GA1404613@ebb.org> (raw)
In-Reply-To: <xmqq7drka6ya.fsf@gitster.c.googlers.com>
> "Bradley M. Kuhn" <bkuhn@sfconservancy.org> writes:
> > I wasn't sure what I should be doing with the patch set once it was already
> > in 'seen'.
Junio C Hamano wrote:
> Being 'seen' is an indication that it has been seen and does not mean
> anything more than that.
Documentation/SubmittingPatches says:
> >>> `git pull --rebase` will automatically skip already-applied patches, and
> >>> will let you know. This works only if you rebase on top of the branch in
> >>> which your patch has been merged (i.e. it will not tell you if your patch
> >>> is merged in `seen` if you rebase on top of master).
> This is talking about a fairly mature topic that has already been in 'next'
> and was on the course to graduate to 'master'. The topic would eventually
> be in 'master', and at that point "pull --rebase" would notice that the
> patches are no longer needed (or were merged in a different form). But
> that does not apply to topics that are not in 'master' yet.
Junio, thanks for your detailed reply. I have a couple ideas of some
minor changes to SubmittingPatches that would have made what you said clearer
to me when I was doing my first patch. I'll think about it some and send
something along, but probably won't get to it until next month (but it
doesn't seem urgent).
Taylor wrote:
>>> Since 'seen' is a convenience branch that contains the current state
>>> of the in-flight topics, it is subject to be changed and rebuilt
>>> multiple times (c.f., link:howto/maintain-git) so the presence of your
>>> patches in 'seen' (but not 'next' or 'master') should not affect your
>>> workflow.
I'll hold on to this text as a possibility, to start from when I dig
into the proposals above. Thanks!
--
Bradley M. Kuhn - he/him
Policy Fellow & Hacker-in-Residence at Software Freedom Conservancy
========================================================================
Become a Conservancy Supporter today: https://sfconservancy.org/supporter
next prev parent reply other threads:[~2020-10-20 23:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 21:59 [PATCH 0/1] Clarify and expand description of --signoff Bradley M. Kuhn
2020-10-15 21:59 ` [PATCH 1/1] Documentation: " Bradley M. Kuhn
2020-10-16 0:46 ` Jeff King
2020-10-18 15:13 ` Theodore Y. Ts'o
2020-10-16 1:49 ` [PATCH 0/1] " Philippe Blain
2020-10-16 1:54 ` Junio C Hamano
2020-10-16 1:59 ` Jeff King
2020-10-16 2:30 ` Junio C Hamano
2020-10-16 19:53 ` Junio C Hamano
2020-10-16 20:11 ` Jeff King
2020-10-17 3:00 ` Bradley M. Kuhn
2020-10-18 19:08 ` Junio C Hamano
2020-10-19 15:53 ` Theodore Y. Ts'o
2020-10-19 18:26 ` Junio C Hamano
2020-10-19 21:25 ` [PATCH v2 0/3] clarify and expand description of --signoff & related fixes Bradley M. Kuhn
2020-10-19 21:25 ` [PATCH v2 1/3] Documentation: clarify and expand description of --signoff Bradley M. Kuhn
2020-10-19 21:25 ` [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn
2020-10-19 22:02 ` Taylor Blau
2020-10-19 22:17 ` Junio C Hamano
2020-10-20 1:03 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 1/4] doc: preparatory clean-up of description on the sign-off option Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 2/4] Documentation: clarify and expand description of --signoff Bradley M. Kuhn
2020-10-20 21:44 ` Bradley M. Kuhn
2020-10-20 21:48 ` Taylor Blau
2020-10-20 1:03 ` [PATCH v3 3/4] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 4/4] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn
2020-10-20 18:52 ` Junio C Hamano
2020-10-20 21:33 ` Bradley M. Kuhn
2020-10-20 2:34 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Taylor Blau
2020-10-20 21:28 ` Bradley M. Kuhn
2020-10-20 21:48 ` Taylor Blau
2020-10-20 22:06 ` Junio C Hamano
2020-10-20 23:02 ` Bradley M. Kuhn [this message]
2020-10-20 2:31 ` [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by: Taylor Blau
2020-10-19 21:25 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn
-- strict thread matches above, loose matches on Subject: below --
2020-10-18 19:49 [PATCH v2 0/3] Claryfing the meaning of the sign-off Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 1/3] doc: preparatory clean-up of description on the sign-off option Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 2/3] Documentation: clarify and expand description of --signoff Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Junio C Hamano
2020-10-18 23:31 ` [PATCH v2 0/3] Claryfing the meaning of the sign-off Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020230215.GA1404613@ebb.org \
--to=bkuhn@sfconservancy.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.