From: "Bradley M. Kuhn" <bkuhn@sfconservancy.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v3 2/4] Documentation: clarify and expand description of --signoff
Date: Tue, 20 Oct 2020 14:44:31 -0700 [thread overview]
Message-ID: <20201020214431.GA1398231@ebb.org> (raw)
In-Reply-To: <418d15c53268f947e11dac2f22d1f8c3c8c60997.1603155607.git.bkuhn@sfconservancy.org>
Junio,
Junio wrote in the sub-thread about [PATCH v3 4/4]:
>> It seems the patches [1-3/4] are identical to what has been queued
>> in 'seen', which is a good sign.
One change I made in v3 patchset was to add Peff's Signed-off-by, as it
is *not* there in commit 04c2b9ebd0 in seen:
I wrote in [PATCH v3 2/4]:
> Signed-off-by: Jeff King <peff@peff.net>
… given that Peff made edits to this before it was posted, I think we want to
be sure Peff's Signed-off-by is included. It just seems like the "right
thing" to get the Signed-off-by trailers 100% correct on a commit that
changes the description of Signed-off-by. 😆
I wrote in [PATCH v3 2/4]:
> Reviewed-by: Taylor Blau <me@ttaylorr.com>
I doubt Taylor cares whether this Reviewed-by trailer makes it in,
but I did add that too based on Taylor providing it earlier in the
discussion of this patch. ☺
--
Bradley M. Kuhn - he/him
Policy Fellow & Hacker-in-Residence at Software Freedom Conservancy
========================================================================
Become a Conservancy Supporter today: https://sfconservancy.org/supporter
next prev parent reply other threads:[~2020-10-20 21:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 21:59 [PATCH 0/1] Clarify and expand description of --signoff Bradley M. Kuhn
2020-10-15 21:59 ` [PATCH 1/1] Documentation: " Bradley M. Kuhn
2020-10-16 0:46 ` Jeff King
2020-10-18 15:13 ` Theodore Y. Ts'o
2020-10-16 1:49 ` [PATCH 0/1] " Philippe Blain
2020-10-16 1:54 ` Junio C Hamano
2020-10-16 1:59 ` Jeff King
2020-10-16 2:30 ` Junio C Hamano
2020-10-16 19:53 ` Junio C Hamano
2020-10-16 20:11 ` Jeff King
2020-10-17 3:00 ` Bradley M. Kuhn
2020-10-18 19:08 ` Junio C Hamano
2020-10-19 15:53 ` Theodore Y. Ts'o
2020-10-19 18:26 ` Junio C Hamano
2020-10-19 21:25 ` [PATCH v2 0/3] clarify and expand description of --signoff & related fixes Bradley M. Kuhn
2020-10-19 21:25 ` [PATCH v2 1/3] Documentation: clarify and expand description of --signoff Bradley M. Kuhn
2020-10-19 21:25 ` [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn
2020-10-19 22:02 ` Taylor Blau
2020-10-19 22:17 ` Junio C Hamano
2020-10-20 1:03 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 1/4] doc: preparatory clean-up of description on the sign-off option Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 2/4] Documentation: clarify and expand description of --signoff Bradley M. Kuhn
2020-10-20 21:44 ` Bradley M. Kuhn [this message]
2020-10-20 21:48 ` Taylor Blau
2020-10-20 1:03 ` [PATCH v3 3/4] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 4/4] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn
2020-10-20 18:52 ` Junio C Hamano
2020-10-20 21:33 ` Bradley M. Kuhn
2020-10-20 2:34 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Taylor Blau
2020-10-20 21:28 ` Bradley M. Kuhn
2020-10-20 21:48 ` Taylor Blau
2020-10-20 22:06 ` Junio C Hamano
2020-10-20 23:02 ` Bradley M. Kuhn
2020-10-20 2:31 ` [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by: Taylor Blau
2020-10-19 21:25 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn
-- strict thread matches above, loose matches on Subject: below --
2020-10-18 19:49 [PATCH v2 0/3] Claryfing the meaning of the sign-off Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 1/3] doc: preparatory clean-up of description on the sign-off option Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 2/3] Documentation: clarify and expand description of --signoff Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Junio C Hamano
2020-10-18 23:31 ` [PATCH v2 0/3] Claryfing the meaning of the sign-off Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020214431.GA1398231@ebb.org \
--to=bkuhn@sfconservancy.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.