From: Greg KH <gregkh@linuxfoundation.org>
To: Amarjargal Gundjalam <amarjargal16@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: most: fix empty /* line in block comments
Date: Sun, 25 Oct 2020 10:09:24 +0100 [thread overview]
Message-ID: <20201025090924.GA99582@kroah.com> (raw)
In-Reply-To: <20201024183134.GA15771@AJ-T14>
On Sun, Oct 25, 2020 at 02:31:34AM +0800, Amarjargal Gundjalam wrote:
> fix the following warning generated by checkpatch:
> networking block comments don't use an empty /* line, use /* Comment.
>
> Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
> ---
> drivers/staging/most/net/net.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
> index b6fecb06a0e6..bc0aefe804b6 100644
> --- a/drivers/staging/most/net/net.c
> +++ b/drivers/staging/most/net/net.c
> @@ -171,8 +171,7 @@ static int most_nd_set_mac_address(struct net_device *dev, void *p)
> (dev->dev_addr[0] == 0 && dev->dev_addr[1] == 0 &&
> dev->dev_addr[2] == 0 && dev->dev_addr[3] == 0);
>
> - /*
> - * Set default MTU for the given packet type.
> + /* Set default MTU for the given packet type.
This is a networking driver, so no, the comment style is correct, sorry
for the confusion.
greg k-h
next prev parent reply other threads:[~2020-10-25 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 18:31 [PATCH] staging: most: fix empty /* line in block comments Amarjargal Gundjalam
2020-10-25 9:09 ` Greg KH [this message]
2020-10-26 2:52 ` Amarjargal Gundjalam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201025090924.GA99582@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amarjargal16@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.