[PATCH] staging: most: fix empty /* line in block comments

[PATCH] staging: most: fix empty /* line in block comments

[Amarjargal Gundjalam]

fix the following warning generated by checkpatch:
networking block comments don't use an empty /* line, use /* Comment.

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
---
 drivers/staging/most/net/net.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
index b6fecb06a0e6..bc0aefe804b6 100644
--- a/drivers/staging/most/net/net.c
+++ b/drivers/staging/most/net/net.c
@@ -171,8 +171,7 @@ static int most_nd_set_mac_address(struct net_device *dev, void *p)
 		(dev->dev_addr[0] == 0 && dev->dev_addr[1] == 0 &&
 		 dev->dev_addr[2] == 0 && dev->dev_addr[3] == 0);
 
-	/*
-	 * Set default MTU for the given packet type.
+	/* Set default MTU for the given packet type.
 	 * It is still possible to change MTU using ip tools afterwards.
 	 */
 	dev->mtu = nd->is_mamac ? MAMAC_DATA_LEN : ETH_DATA_LEN;
@@ -388,8 +387,7 @@ static int comp_disconnect_channel(struct most_interface *iface,
 		ch->linked = false;
 		spin_unlock_irqrestore(&list_lock, flags);
 
-		/*
-		 * do not call most_stop_channel() here, because channels are
+		/* do not call most_stop_channel() here, because channels are
 		 * going to be closed in ndo_stop() after unregister_netdev()
 		 */
 		unregister_netdev(nd->dev);
-- 
2.25.1

Re: [PATCH] staging: most: fix empty /* line in block comments

[Greg KH]

On Sun, Oct 25, 2020 at 02:31:34AM +0800, Amarjargal Gundjalam wrote:
> fix the following warning generated by checkpatch:
> networking block comments don't use an empty /* line, use /* Comment.
> 
> Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
> ---
>  drivers/staging/most/net/net.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c
> index b6fecb06a0e6..bc0aefe804b6 100644
> --- a/drivers/staging/most/net/net.c
> +++ b/drivers/staging/most/net/net.c
> @@ -171,8 +171,7 @@ static int most_nd_set_mac_address(struct net_device *dev, void *p)
>  		(dev->dev_addr[0] == 0 && dev->dev_addr[1] == 0 &&
>  		 dev->dev_addr[2] == 0 && dev->dev_addr[3] == 0);
>  
> -	/*
> -	 * Set default MTU for the given packet type.
> +	/* Set default MTU for the given packet type.

This is a networking driver, so no, the comment style is correct, sorry
for the confusion.

greg k-h

Re: [PATCH] staging: most: fix empty /* line in block comments

[Amarjargal Gundjalam]

On Sun, 2020-10-25 at 10:09 +0100, Greg KH wrote:
> On Sun, Oct 25, 2020 at 02:31:34AM +0800, Amarjargal Gundjalam wrote:
> > fix the following warning generated by checkpatch:
> > networking block comments don't use an empty /* line, use /*
> > Comment.
> > 
> > Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
> > ---
> >  drivers/staging/most/net/net.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/most/net/net.c
> > b/drivers/staging/most/net/net.c
> > index b6fecb06a0e6..bc0aefe804b6 100644
> > --- a/drivers/staging/most/net/net.c
> > +++ b/drivers/staging/most/net/net.c
> > @@ -171,8 +171,7 @@ static int most_nd_set_mac_address(struct
> > net_device *dev, void *p)
> >  		(dev->dev_addr[0] == 0 && dev->dev_addr[1] == 0 &&
> >  		 dev->dev_addr[2] == 0 && dev->dev_addr[3] == 0);
> >  
> > -	/*
> > -	 * Set default MTU for the given packet type.
> > +	/* Set default MTU for the given packet type.
> 
> This is a networking driver, so no, the comment style is correct,
> sorry
> for the confusion.
> 
> greg k-h

Oh ok. Got it.