Re: [PATCH 08/12] ARM: dts: exynos: adjust node names to DT spec in Exynos542x boards

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH 08/12] ARM: dts: exynos: adjust node names to DT spec in Exynos542x boards
Date: Tue, 27 Oct 2020 11:37:32 +0100	[thread overview]
Message-ID: <20201027103732.GA20429@kozik-lap> (raw)
In-Reply-To: <f14a69bc-bd8f-b0d7-2967-1e7582562d5e@samsung.com>

On Mon, Oct 26, 2020 at 10:47:47PM +0100, Marek Szyprowski wrote:
> Hi Krzysztof,
> 
> On 26.10.2020 19:15, Krzysztof Kozlowski wrote:
> > The Devicetree specification expects device node names to have a generic
> > name, representing the class of a device.  Also the convention for node
> > names is to use hyphens, not underscores.
> >
> > No functional changes.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >   arch/arm/boot/dts/exynos5420-arndale-octa.dts      | 4 ++--
> >   arch/arm/boot/dts/exynos5420-peach-pit.dts         | 4 ++--
> >   arch/arm/boot/dts/exynos5420-smdk5420.dts          | 2 +-
> >   arch/arm/boot/dts/exynos5422-odroid-core.dtsi      | 2 +-
> >   arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi  | 2 +-
> >   arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 ++--
> >   arch/arm/boot/dts/exynos5422-odroidxu3.dts         | 8 ++++----
> >   arch/arm/boot/dts/exynos5800-peach-pi.dts          | 4 ++--
> >   8 files changed, 15 insertions(+), 15 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
> > index dd7f8385d81e..bf457d0c02eb 100644
> > --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
> > +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
> > @@ -39,7 +39,7 @@ oscclk {
> >   		};
> >   	};
> >   
> > -	gpio_keys {
> > +	gpio-keys {
> >   		compatible = "gpio-keys";
> >   
> >   		wakeup {
> > @@ -344,7 +344,7 @@ &hdmi {
> >   &hsi2c_4 {
> >   	status = "okay";
> >   
> > -	s2mps11_pmic@66 {
> > +	pmic@66 {
> >   		compatible = "samsung,s2mps11-pmic";
> >   		reg = <0x66>;
> >   
> > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> > index 2bcbdf8a39bf..d54392fe6260 100644
> > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> > @@ -138,7 +138,7 @@ panel_in: endpoint {
> >   		};
> >   	};
> >   
> > -	mmc1_pwrseq: mmc1_pwrseq {
> > +	mmc1_pwrseq: mmc1-pwrseq {
> >   		compatible = "mmc-pwrseq-simple";
> >   		reset-gpios = <&gpx0 0 GPIO_ACTIVE_LOW>; /* WIFI_EN */
> >   		clocks = <&max77802 MAX77802_CLK_32K_CP>;
> > @@ -205,7 +205,7 @@ &hsi2c_4 {
> >   	status = "okay";
> >   	clock-frequency = <400000>;
> >   
> > -	max77802: max77802-pmic@9 {
> > +	max77802: pmic@9 {
> >   		compatible = "maxim,max77802";
> >   		interrupt-parent = <&gpx3>;
> >   		interrupts = <1 IRQ_TYPE_NONE>;
> > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> > index 4e49d8095b29..d506da9fa661 100644
> > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> > @@ -129,7 +129,7 @@ &hdmi {
> >   &hsi2c_4 {
> >   	status = "okay";
> >   
> > -	s2mps11_pmic@66 {
> > +	pmic@66 {
> >   		compatible = "samsung,s2mps11-pmic";
> >   		reg = <0x66>;
> >   
> > diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> > index b1cf9414ce17..25fb6331c75e 100644
> > --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> > +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> > @@ -503,7 +503,7 @@ &dmc {
> >   &hsi2c_4 {
> >   	status = "okay";
> >   
> > -	s2mps11_pmic@66 {
> > +	pmic@66 {
> >   		compatible = "samsung,s2mps11-pmic";
> >   		reg = <0x66>;
> >   		samsung,s2mps11-acokb-ground;
> > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi
> > index b5ec4f47eb3a..f5f9c077df74 100644
> > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi
> > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi
> > @@ -40,7 +40,7 @@ codec {
> >   
> >   &hsi2c_5 {
> >   	status = "okay";
> > -	max98090: max98090@10 {
> > +	max98090: codec@10 {
> >   		compatible = "maxim,max98090";
> >   		reg = <0x10>;
> >   		interrupt-parent = <&gpx3>;
> > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> > index 5da2d81e3be2..e35af40a55cb 100644
> > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> > @@ -13,12 +13,12 @@
> >   #include "exynos5422-odroid-core.dtsi"
> >   
> >   / {
> > -	gpio_keys {
> > +	gpio-keys {
> >   		compatible = "gpio-keys";
> >   		pinctrl-names = "default";
> >   		pinctrl-0 = <&power_key>;
> >   
> > -		power_key {
> > +		power-key {
> >   			/*
> >   			 * The power button (SW2) is connected to the PWRON
> >   			 * pin (active high) of the S2MPS11 PMIC, which acts
> > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> > index d0f6ac5fa79d..5ff493ecb6ff 100644
> > --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> > @@ -21,28 +21,28 @@ &i2c_0 {
> >   	status = "okay";
> >   
> >   	/* A15 cluster: VDD_ARM */
> > -	ina231@40 {
> > +	sensor@40 {
> power-sensor?

Good point, thanks!

Best regards,
Krzysztof