From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH 04/12] ARM: dts: exynos: adjust node names to DT spec in Exynos4412 boards
Date: Tue, 27 Oct 2020 11:38:27 +0100 [thread overview]
Message-ID: <20201027103827.GB20429@kozik-lap> (raw)
In-Reply-To: <7832e031-81b0-c77e-57fa-cf122cd989d4@samsung.com>
On Mon, Oct 26, 2020 at 10:02:10PM +0100, Marek Szyprowski wrote:
>
> On 26.10.2020 19:15, Krzysztof Kozlowski wrote:
> > The Devicetree specification expects device node names to have a generic
> > name, representing the class of a device. Also the convention for node
> > names is to use hyphens, not underscores.
> >
> > No functional changes.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 8 ++++----
> > arch/arm/boot/dts/exynos4412-itop-elite.dts | 2 +-
> > .../boot/dts/exynos4412-itop-scp-core.dtsi | 2 +-
> > arch/arm/boot/dts/exynos4412-midas.dtsi | 12 +++++------
> > arch/arm/boot/dts/exynos4412-n710x.dts | 2 +-
> > .../boot/dts/exynos4412-odroid-common.dtsi | 8 ++++----
> > arch/arm/boot/dts/exynos4412-odroidx.dts | 4 ++--
> > arch/arm/boot/dts/exynos4412-origen.dts | 14 ++++++-------
> > arch/arm/boot/dts/exynos4412-smdk4412.dts | 20 +++++++++----------
> > 9 files changed, 36 insertions(+), 36 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > index 89ed81fb348d..db91678f5648 100644
> > --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > @@ -15,7 +15,7 @@ aliases {
> > i2c10 = &i2c_cm36651;
> > };
> >
> > - aat1290 {
> > + led-controller {
> > compatible = "skyworks,aat1290";
> > flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> > enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>;
> > @@ -60,7 +60,7 @@ i2c_ak8975: i2c-gpio-0 {
> > #size-cells = <0>;
> > status = "okay";
> >
> > - ak8975@c {
> > + magnetometer@c {
> > compatible = "asahi-kasei,ak8975";
> > reg = <0x0c>;
> > gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
> > @@ -75,7 +75,7 @@ i2c_cm36651: i2c-gpio-2 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > - cm36651@18 {
> > + sensor@18 {
> light-sensor?
Ack, to this and all following. Thanks.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/12] ARM: dts: exynos: adjust node names to DT spec in Exynos4412 boards
Date: Tue, 27 Oct 2020 11:38:27 +0100 [thread overview]
Message-ID: <20201027103827.GB20429@kozik-lap> (raw)
In-Reply-To: <7832e031-81b0-c77e-57fa-cf122cd989d4@samsung.com>
On Mon, Oct 26, 2020 at 10:02:10PM +0100, Marek Szyprowski wrote:
>
> On 26.10.2020 19:15, Krzysztof Kozlowski wrote:
> > The Devicetree specification expects device node names to have a generic
> > name, representing the class of a device. Also the convention for node
> > names is to use hyphens, not underscores.
> >
> > No functional changes.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 8 ++++----
> > arch/arm/boot/dts/exynos4412-itop-elite.dts | 2 +-
> > .../boot/dts/exynos4412-itop-scp-core.dtsi | 2 +-
> > arch/arm/boot/dts/exynos4412-midas.dtsi | 12 +++++------
> > arch/arm/boot/dts/exynos4412-n710x.dts | 2 +-
> > .../boot/dts/exynos4412-odroid-common.dtsi | 8 ++++----
> > arch/arm/boot/dts/exynos4412-odroidx.dts | 4 ++--
> > arch/arm/boot/dts/exynos4412-origen.dts | 14 ++++++-------
> > arch/arm/boot/dts/exynos4412-smdk4412.dts | 20 +++++++++----------
> > 9 files changed, 36 insertions(+), 36 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > index 89ed81fb348d..db91678f5648 100644
> > --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > @@ -15,7 +15,7 @@ aliases {
> > i2c10 = &i2c_cm36651;
> > };
> >
> > - aat1290 {
> > + led-controller {
> > compatible = "skyworks,aat1290";
> > flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> > enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>;
> > @@ -60,7 +60,7 @@ i2c_ak8975: i2c-gpio-0 {
> > #size-cells = <0>;
> > status = "okay";
> >
> > - ak8975@c {
> > + magnetometer@c {
> > compatible = "asahi-kasei,ak8975";
> > reg = <0x0c>;
> > gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
> > @@ -75,7 +75,7 @@ i2c_cm36651: i2c-gpio-2 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > - cm36651@18 {
> > + sensor@18 {
> light-sensor?
Ack, to this and all following. Thanks.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-27 10:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 18:15 [PATCH 00/12] ARM: dts: samsung: minor node name cleanups Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 01/12] ARM: dts: exynos: adjust node names to DT spec in Exynos3250 boards Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 02/12] ARM: dts: exynos: adjust node names to DT spec in Exynos4210 boards Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 03/12] ARM: dts: exynos: override GPIO keys node by label in Exynos4412 Odroid family Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 04/12] ARM: dts: exynos: adjust node names to DT spec in Exynos4412 boards Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 21:02 ` Marek Szyprowski
2020-10-26 21:02 ` Marek Szyprowski
2020-10-27 10:38 ` Krzysztof Kozlowski [this message]
2020-10-27 10:38 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 05/12] ARM: dts: exynos: remove redundant status=okay " Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 06/12] ARM: dts: exynos: adjust node names to DT spec in Exynos5250 boards Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 07/12] ARM: dts: exynos: adjust node names to DT spec in Odroid XU Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 08/12] ARM: dts: exynos: adjust node names to DT spec in Exynos542x boards Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 21:47 ` Marek Szyprowski
2020-10-26 21:47 ` Marek Szyprowski
2020-10-27 10:37 ` Krzysztof Kozlowski
2020-10-27 10:37 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 09/12] ARM: dts: s5pv210: adjust node names to DT spec Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 10/12] arm64: dts: exynos: adjust node names to DT spec in Exynos5433 TM2 Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 11/12] arm64: dts: exynos: adjust node names to DT spec in Exynos7 Espresso Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
2020-10-26 18:15 ` [PATCH 12/12] arm64: dts: exynos: remove redundant status=okay in Exynos5433 TM2 Krzysztof Kozlowski
2020-10-26 18:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027103827.GB20429@kozik-lap \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.