From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [RFC PATCH 3/4] net: dsa: mv88e6xxx: link aggregation support
Date: Thu, 29 Oct 2020 14:54:21 +0300 [thread overview]
Message-ID: <20201029115421.GA12347@kadam> (raw)
In-Reply-To: <20201027105117.23052-4-tobias@waldekranz.com>
[-- Attachment #1: Type: text/plain, Size: 2615 bytes --]
Hi Tobias,
url: https://github.com/0day-ci/linux/commits/Tobias-Waldekranz/net-dsa-link-aggregation-support/20201027-185322
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4525c8781ec0701ce824e8bd379ae1b129e26568
config: parisc-randconfig-m031-20201028 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/dsa/mv88e6xxx/chip.c:5488 mv88e6xxx_port_lag_join() warn: inconsistent returns 'chip->reg_lock'.
Old smatch warnings:
drivers/net/dsa/mv88e6xxx/chip.c:2475 mv88e6xxx_serdes_irq_request() warn: 'irq' not released on lines: 2475.
vim +5488 drivers/net/dsa/mv88e6xxx/chip.c
79cd23f00678afd Tobias Waldekranz 2020-10-27 5470 static int mv88e6xxx_port_lag_join(struct dsa_switch *ds, int port,
79cd23f00678afd Tobias Waldekranz 2020-10-27 5471 struct net_device *lag_dev)
79cd23f00678afd Tobias Waldekranz 2020-10-27 5472 {
79cd23f00678afd Tobias Waldekranz 2020-10-27 5473 struct dsa_lag *lag = dsa_to_port(ds, port)->lag;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5474 struct mv88e6xxx_chip *chip = ds->priv;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5475 int err;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5476
79cd23f00678afd Tobias Waldekranz 2020-10-27 5477 mv88e6xxx_reg_lock(chip);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5478
79cd23f00678afd Tobias Waldekranz 2020-10-27 5479 err = mv88e6xxx_port_set_trunk(chip, port, true, lag->id);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5480 if (err)
79cd23f00678afd Tobias Waldekranz 2020-10-27 5481 return err;
^^^^^^^^^^^
Call mv88e6xxx_reg_unlock() unlock before returning.
79cd23f00678afd Tobias Waldekranz 2020-10-27 5482
79cd23f00678afd Tobias Waldekranz 2020-10-27 5483 err = mv88e6xxx_lag_sync_map(ds, lag);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5484 if (err)
79cd23f00678afd Tobias Waldekranz 2020-10-27 5485 mv88e6xxx_port_set_trunk(chip, port, false, 0);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5486
79cd23f00678afd Tobias Waldekranz 2020-10-27 5487 mv88e6xxx_reg_unlock(chip);
79cd23f00678afd Tobias Waldekranz 2020-10-27 @5488 return err;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5489 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36544 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH 3/4] net: dsa: mv88e6xxx: link aggregation support
Date: Thu, 29 Oct 2020 14:54:21 +0300 [thread overview]
Message-ID: <20201029115421.GA12347@kadam> (raw)
In-Reply-To: <20201027105117.23052-4-tobias@waldekranz.com>
[-- Attachment #1: Type: text/plain, Size: 2615 bytes --]
Hi Tobias,
url: https://github.com/0day-ci/linux/commits/Tobias-Waldekranz/net-dsa-link-aggregation-support/20201027-185322
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4525c8781ec0701ce824e8bd379ae1b129e26568
config: parisc-randconfig-m031-20201028 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/dsa/mv88e6xxx/chip.c:5488 mv88e6xxx_port_lag_join() warn: inconsistent returns 'chip->reg_lock'.
Old smatch warnings:
drivers/net/dsa/mv88e6xxx/chip.c:2475 mv88e6xxx_serdes_irq_request() warn: 'irq' not released on lines: 2475.
vim +5488 drivers/net/dsa/mv88e6xxx/chip.c
79cd23f00678afd Tobias Waldekranz 2020-10-27 5470 static int mv88e6xxx_port_lag_join(struct dsa_switch *ds, int port,
79cd23f00678afd Tobias Waldekranz 2020-10-27 5471 struct net_device *lag_dev)
79cd23f00678afd Tobias Waldekranz 2020-10-27 5472 {
79cd23f00678afd Tobias Waldekranz 2020-10-27 5473 struct dsa_lag *lag = dsa_to_port(ds, port)->lag;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5474 struct mv88e6xxx_chip *chip = ds->priv;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5475 int err;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5476
79cd23f00678afd Tobias Waldekranz 2020-10-27 5477 mv88e6xxx_reg_lock(chip);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5478
79cd23f00678afd Tobias Waldekranz 2020-10-27 5479 err = mv88e6xxx_port_set_trunk(chip, port, true, lag->id);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5480 if (err)
79cd23f00678afd Tobias Waldekranz 2020-10-27 5481 return err;
^^^^^^^^^^^
Call mv88e6xxx_reg_unlock() unlock before returning.
79cd23f00678afd Tobias Waldekranz 2020-10-27 5482
79cd23f00678afd Tobias Waldekranz 2020-10-27 5483 err = mv88e6xxx_lag_sync_map(ds, lag);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5484 if (err)
79cd23f00678afd Tobias Waldekranz 2020-10-27 5485 mv88e6xxx_port_set_trunk(chip, port, false, 0);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5486
79cd23f00678afd Tobias Waldekranz 2020-10-27 5487 mv88e6xxx_reg_unlock(chip);
79cd23f00678afd Tobias Waldekranz 2020-10-27 @5488 return err;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5489 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36544 bytes --]
next prev parent reply other threads:[~2020-10-29 11:54 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 10:51 [RFC PATCH 0/4] net: dsa: link aggregation support Tobias Waldekranz
2020-10-27 10:51 ` [RFC PATCH 1/4] net: dsa: mv88e6xxx: use ethertyped dsa for 6390/6390X Tobias Waldekranz
2020-10-27 14:52 ` Marek Behun
2020-10-27 14:54 ` Marek Behun
2020-10-27 14:58 ` Marek Behun
2020-10-27 10:51 ` [RFC PATCH 2/4] net: dsa: link aggregation support Tobias Waldekranz
2020-10-28 0:58 ` Vladimir Oltean
2020-10-28 14:03 ` Tobias Waldekranz
2020-10-27 10:51 ` [RFC PATCH 3/4] net: dsa: mv88e6xxx: " Tobias Waldekranz
2020-10-29 5:28 ` kernel test robot
2020-10-29 11:54 ` Dan Carpenter [this message]
2020-10-29 11:54 ` Dan Carpenter
2020-10-27 10:51 ` [RFC PATCH 4/4] net: dsa: tag_edsa: support reception of packets from lag devices Tobias Waldekranz
2020-10-28 12:05 ` Vladimir Oltean
2020-10-28 15:28 ` Tobias Waldekranz
2020-10-28 18:18 ` Vladimir Oltean
2020-10-28 22:31 ` Tobias Waldekranz
2020-10-28 23:08 ` Vladimir Oltean
2020-10-29 7:47 ` Tobias Waldekranz
2020-10-30 9:21 ` Vladimir Oltean
2020-11-01 11:31 ` Ido Schimmel
2020-10-27 12:27 ` [RFC PATCH 0/4] net: dsa: link aggregation support Vladimir Oltean
2020-10-27 14:29 ` Andrew Lunn
2020-10-27 14:59 ` Tobias Waldekranz
2020-10-27 14:00 ` Andrew Lunn
2020-10-27 15:09 ` Tobias Waldekranz
2020-10-27 15:05 ` Marek Behun
2020-10-27 15:23 ` Andrew Lunn
2020-10-27 18:25 ` Tobias Waldekranz
2020-10-27 18:33 ` Marek Behun
2020-10-27 19:04 ` Vladimir Oltean
2020-10-27 19:21 ` Tobias Waldekranz
2020-10-27 19:00 ` Vladimir Oltean
2020-10-27 19:37 ` Tobias Waldekranz
2020-10-27 20:02 ` Vladimir Oltean
2020-10-27 20:53 ` Tobias Waldekranz
2020-10-27 22:32 ` Vladimir Oltean
2020-10-28 0:27 ` Tobias Waldekranz
2020-10-28 22:35 ` Marek Behun
2020-10-27 22:36 ` Andrew Lunn
2020-10-28 0:45 ` Tobias Waldekranz
2020-10-28 1:03 ` Andrew Lunn
2020-11-11 4:28 ` Florian Fainelli
2020-11-19 10:51 ` Vladimir Oltean
2020-11-19 11:52 ` Tobias Waldekranz
2020-11-19 18:12 ` Vladimir Oltean
-- strict thread matches above, loose matches on Subject: below --
2020-10-29 1:53 [RFC PATCH 3/4] net: dsa: mv88e6xxx: " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029115421.GA12347@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.