* [PATCH] tools/python: pass more -rpath-link options to ld
@ 2020-10-19 8:31 Jan Beulich
2020-10-29 13:48 ` Ping: " Jan Beulich
2020-10-30 3:28 ` Marek Marczykowski
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2020-10-19 8:31 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org; +Cc: Marek Marczykowski
With the split of libraries, I've observed a number of warnings from
(old?) ld.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
It's unclear to me whether this is ld version dependent - the pattern
of where I've seen such warnings doesn't suggest a clear version
dependency.
--- a/tools/python/setup.py
+++ b/tools/python/setup.py
@@ -7,10 +7,15 @@ XEN_ROOT = "../.."
extra_compile_args = [ "-fno-strict-aliasing", "-Werror" ]
PATH_XEN = XEN_ROOT + "/tools/include"
+PATH_LIBXENTOOLCORE = XEN_ROOT + "/tools/libs/toolcore"
PATH_LIBXENTOOLLOG = XEN_ROOT + "/tools/libs/toollog"
+PATH_LIBXENCALL = XEN_ROOT + "/tools/libs/call"
PATH_LIBXENEVTCHN = XEN_ROOT + "/tools/libs/evtchn"
+PATH_LIBXENGNTTAB = XEN_ROOT + "/tools/libs/gnttab"
PATH_LIBXENCTRL = XEN_ROOT + "/tools/libs/ctrl"
PATH_LIBXENGUEST = XEN_ROOT + "/tools/libs/guest"
+PATH_LIBXENDEVICEMODEL = XEN_ROOT + "/tools/libs/devicemodel"
+PATH_LIBXENFOREIGNMEMORY = XEN_ROOT + "/tools/libs/foreignmemory"
PATH_XENSTORE = XEN_ROOT + "/tools/libs/store"
xc = Extension("xc",
@@ -24,7 +29,13 @@ xc = Extension("xc",
library_dirs = [ PATH_LIBXENCTRL, PATH_LIBXENGUEST ],
libraries = [ "xenctrl", "xenguest" ],
depends = [ PATH_LIBXENCTRL + "/libxenctrl.so", PATH_LIBXENGUEST + "/libxenguest.so" ],
- extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENTOOLLOG ],
+ extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENCALL,
+ "-Wl,-rpath-link="+PATH_LIBXENDEVICEMODEL,
+ "-Wl,-rpath-link="+PATH_LIBXENEVTCHN,
+ "-Wl,-rpath-link="+PATH_LIBXENFOREIGNMEMORY,
+ "-Wl,-rpath-link="+PATH_LIBXENGNTTAB,
+ "-Wl,-rpath-link="+PATH_LIBXENTOOLCORE,
+ "-Wl,-rpath-link="+PATH_LIBXENTOOLLOG ],
sources = [ "xen/lowlevel/xc/xc.c" ])
xs = Extension("xs",
@@ -33,6 +44,7 @@ xs = Extension("xs",
library_dirs = [ PATH_XENSTORE ],
libraries = [ "xenstore" ],
depends = [ PATH_XENSTORE + "/libxenstore.so" ],
+ extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENTOOLCORE ],
sources = [ "xen/lowlevel/xs/xs.c" ])
plat = os.uname()[0]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Ping: [PATCH] tools/python: pass more -rpath-link options to ld
2020-10-19 8:31 [PATCH] tools/python: pass more -rpath-link options to ld Jan Beulich
@ 2020-10-29 13:48 ` Jan Beulich
2020-10-30 3:28 ` Marek Marczykowski
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2020-10-29 13:48 UTC (permalink / raw)
To: Marek Marczykowski; +Cc: xen-devel@lists.xenproject.org
On 19.10.2020 10:31, Jan Beulich wrote:
> With the split of libraries, I've observed a number of warnings from
> (old?) ld.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Marek?
> ---
> It's unclear to me whether this is ld version dependent - the pattern
> of where I've seen such warnings doesn't suggest a clear version
> dependency.
>
> --- a/tools/python/setup.py
> +++ b/tools/python/setup.py
> @@ -7,10 +7,15 @@ XEN_ROOT = "../.."
> extra_compile_args = [ "-fno-strict-aliasing", "-Werror" ]
>
> PATH_XEN = XEN_ROOT + "/tools/include"
> +PATH_LIBXENTOOLCORE = XEN_ROOT + "/tools/libs/toolcore"
> PATH_LIBXENTOOLLOG = XEN_ROOT + "/tools/libs/toollog"
> +PATH_LIBXENCALL = XEN_ROOT + "/tools/libs/call"
> PATH_LIBXENEVTCHN = XEN_ROOT + "/tools/libs/evtchn"
> +PATH_LIBXENGNTTAB = XEN_ROOT + "/tools/libs/gnttab"
> PATH_LIBXENCTRL = XEN_ROOT + "/tools/libs/ctrl"
> PATH_LIBXENGUEST = XEN_ROOT + "/tools/libs/guest"
> +PATH_LIBXENDEVICEMODEL = XEN_ROOT + "/tools/libs/devicemodel"
> +PATH_LIBXENFOREIGNMEMORY = XEN_ROOT + "/tools/libs/foreignmemory"
> PATH_XENSTORE = XEN_ROOT + "/tools/libs/store"
>
> xc = Extension("xc",
> @@ -24,7 +29,13 @@ xc = Extension("xc",
> library_dirs = [ PATH_LIBXENCTRL, PATH_LIBXENGUEST ],
> libraries = [ "xenctrl", "xenguest" ],
> depends = [ PATH_LIBXENCTRL + "/libxenctrl.so", PATH_LIBXENGUEST + "/libxenguest.so" ],
> - extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENTOOLLOG ],
> + extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENCALL,
> + "-Wl,-rpath-link="+PATH_LIBXENDEVICEMODEL,
> + "-Wl,-rpath-link="+PATH_LIBXENEVTCHN,
> + "-Wl,-rpath-link="+PATH_LIBXENFOREIGNMEMORY,
> + "-Wl,-rpath-link="+PATH_LIBXENGNTTAB,
> + "-Wl,-rpath-link="+PATH_LIBXENTOOLCORE,
> + "-Wl,-rpath-link="+PATH_LIBXENTOOLLOG ],
> sources = [ "xen/lowlevel/xc/xc.c" ])
>
> xs = Extension("xs",
> @@ -33,6 +44,7 @@ xs = Extension("xs",
> library_dirs = [ PATH_XENSTORE ],
> libraries = [ "xenstore" ],
> depends = [ PATH_XENSTORE + "/libxenstore.so" ],
> + extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENTOOLCORE ],
> sources = [ "xen/lowlevel/xs/xs.c" ])
>
> plat = os.uname()[0]
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/python: pass more -rpath-link options to ld
2020-10-19 8:31 [PATCH] tools/python: pass more -rpath-link options to ld Jan Beulich
2020-10-29 13:48 ` Ping: " Jan Beulich
@ 2020-10-30 3:28 ` Marek Marczykowski
1 sibling, 0 replies; 3+ messages in thread
From: Marek Marczykowski @ 2020-10-30 3:28 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel@lists.xenproject.org
[-- Attachment #1: Type: text/plain, Size: 3015 bytes --]
On Mon, Oct 19, 2020 at 10:31:37AM +0200, Jan Beulich wrote:
> With the split of libraries, I've observed a number of warnings from
> (old?) ld.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> It's unclear to me whether this is ld version dependent - the pattern
> of where I've seen such warnings doesn't suggest a clear version
> dependency.
>
> --- a/tools/python/setup.py
> +++ b/tools/python/setup.py
> @@ -7,10 +7,15 @@ XEN_ROOT = "../.."
> extra_compile_args = [ "-fno-strict-aliasing", "-Werror" ]
>
> PATH_XEN = XEN_ROOT + "/tools/include"
> +PATH_LIBXENTOOLCORE = XEN_ROOT + "/tools/libs/toolcore"
> PATH_LIBXENTOOLLOG = XEN_ROOT + "/tools/libs/toollog"
> +PATH_LIBXENCALL = XEN_ROOT + "/tools/libs/call"
> PATH_LIBXENEVTCHN = XEN_ROOT + "/tools/libs/evtchn"
> +PATH_LIBXENGNTTAB = XEN_ROOT + "/tools/libs/gnttab"
> PATH_LIBXENCTRL = XEN_ROOT + "/tools/libs/ctrl"
> PATH_LIBXENGUEST = XEN_ROOT + "/tools/libs/guest"
> +PATH_LIBXENDEVICEMODEL = XEN_ROOT + "/tools/libs/devicemodel"
> +PATH_LIBXENFOREIGNMEMORY = XEN_ROOT + "/tools/libs/foreignmemory"
> PATH_XENSTORE = XEN_ROOT + "/tools/libs/store"
>
> xc = Extension("xc",
> @@ -24,7 +29,13 @@ xc = Extension("xc",
> library_dirs = [ PATH_LIBXENCTRL, PATH_LIBXENGUEST ],
> libraries = [ "xenctrl", "xenguest" ],
> depends = [ PATH_LIBXENCTRL + "/libxenctrl.so", PATH_LIBXENGUEST + "/libxenguest.so" ],
> - extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENTOOLLOG ],
> + extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENCALL,
> + "-Wl,-rpath-link="+PATH_LIBXENDEVICEMODEL,
> + "-Wl,-rpath-link="+PATH_LIBXENEVTCHN,
> + "-Wl,-rpath-link="+PATH_LIBXENFOREIGNMEMORY,
> + "-Wl,-rpath-link="+PATH_LIBXENGNTTAB,
> + "-Wl,-rpath-link="+PATH_LIBXENTOOLCORE,
> + "-Wl,-rpath-link="+PATH_LIBXENTOOLLOG ],
This basically open-codes SHLIB_libxenctrl + SHLIB_libxenguest. Isn't it
better to pass it from make that already has all the dependencies
resolved?
> sources = [ "xen/lowlevel/xc/xc.c" ])
>
> xs = Extension("xs",
> @@ -33,6 +44,7 @@ xs = Extension("xs",
> library_dirs = [ PATH_XENSTORE ],
> libraries = [ "xenstore" ],
> depends = [ PATH_XENSTORE + "/libxenstore.so" ],
> + extra_link_args = [ "-Wl,-rpath-link="+PATH_LIBXENTOOLCORE ],
> sources = [ "xen/lowlevel/xs/xs.c" ])
>
> plat = os.uname()[0]
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-30 3:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-19 8:31 [PATCH] tools/python: pass more -rpath-link options to ld Jan Beulich
2020-10-29 13:48 ` Ping: " Jan Beulich
2020-10-30 3:28 ` Marek Marczykowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.