From: Shawn Guo <shawnguo@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o
Date: Tue, 3 Nov 2020 07:52:19 +0800 [thread overview]
Message-ID: <20201102235218.GY31601@dragon> (raw)
In-Reply-To: <0b61c4f4-b389-c853-6e09-ee603455e583@infradead.org>
On Mon, Nov 02, 2020 at 01:31:59PM -0800, Randy Dunlap wrote:
> On 11/2/20 1:01 PM, Valdis Klētnieks wrote:
> > On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said:
> >
> >> also
> >> Reported-by: kernel test robot <lkp@intel.com>
> >>
> >> However, this driver does not directly use <linux/module.h>.
> >
> > Just my luck - I looked at 3 or 4 other things that include of_platform.h
> > and they all *did* include module.h.
> >
> >> platform_device.h #includes <linux/device.h>, which is where the
> >> problem lies:
> >>
> >> <linux/device.h> uses macros that are provided by <linux/module.h>
> >> so <linux/device.h> should #include <linux/module.h>.
> >>
> >> and that fixes this commit:
> >>
> >> commit 4c002c978b7f2f2306d53de051c054504af920a9
> >> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> Date: Mon Dec 9 20:33:03 2019 +0100
> >>
> >> device.h: move 'struct driver' stuff out to device/driver.h
> >
> > OK.. who's going to do that? Me, or Randy, or Greg?
>
> You could go ahead... I began on it yesterday but didn't finish
> testing, although I did see the same build error that the 0day
> bot reported, so I don't know what it's going to take to fix that.
It's a driver problem which is being addressed by Dong's patch[1].
Shawn
[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201030153733.30160-1-aisheng.dong@nxp.com/
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "Dong Aisheng" <aisheng.dong@nxp.com>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Stephen Boyd" <sboyd@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Michael Turquette" <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o
Date: Tue, 3 Nov 2020 07:52:19 +0800 [thread overview]
Message-ID: <20201102235218.GY31601@dragon> (raw)
In-Reply-To: <0b61c4f4-b389-c853-6e09-ee603455e583@infradead.org>
On Mon, Nov 02, 2020 at 01:31:59PM -0800, Randy Dunlap wrote:
> On 11/2/20 1:01 PM, Valdis Klētnieks wrote:
> > On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said:
> >
> >> also
> >> Reported-by: kernel test robot <lkp@intel.com>
> >>
> >> However, this driver does not directly use <linux/module.h>.
> >
> > Just my luck - I looked at 3 or 4 other things that include of_platform.h
> > and they all *did* include module.h.
> >
> >> platform_device.h #includes <linux/device.h>, which is where the
> >> problem lies:
> >>
> >> <linux/device.h> uses macros that are provided by <linux/module.h>
> >> so <linux/device.h> should #include <linux/module.h>.
> >>
> >> and that fixes this commit:
> >>
> >> commit 4c002c978b7f2f2306d53de051c054504af920a9
> >> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> Date: Mon Dec 9 20:33:03 2019 +0100
> >>
> >> device.h: move 'struct driver' stuff out to device/driver.h
> >
> > OK.. who's going to do that? Me, or Randy, or Greg?
>
> You could go ahead... I began on it yesterday but didn't finish
> testing, although I did see the same build error that the 0day
> bot reported, so I don't know what it's going to take to fix that.
It's a driver problem which is being addressed by Dong's patch[1].
Shawn
[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201030153733.30160-1-aisheng.dong@nxp.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-02 23:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 12:02 [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o Valdis Klētnieks
2020-11-02 12:02 ` Valdis Klētnieks
2020-11-02 17:15 ` Randy Dunlap
2020-11-02 17:15 ` Randy Dunlap
2020-11-02 21:01 ` Valdis Klētnieks
2020-11-02 21:01 ` Valdis Klētnieks
2020-11-02 21:31 ` Randy Dunlap
2020-11-02 21:31 ` Randy Dunlap
2020-11-02 23:52 ` Shawn Guo [this message]
2020-11-02 23:52 ` Shawn Guo
2020-11-02 23:59 ` Randy Dunlap
2020-11-02 23:59 ` Randy Dunlap
2020-11-03 1:45 ` Valdis Klētnieks
2020-11-03 1:45 ` Valdis Klētnieks
2020-11-02 20:17 ` kernel test robot
2020-11-02 20:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102235218.GY31601@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rdunlap@infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.