All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o
Date: Mon, 02 Nov 2020 16:01:39 -0500	[thread overview]
Message-ID: <238534.1604350899@turing-police> (raw)
In-Reply-To: <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said:

> also
> Reported-by: kernel test robot <lkp@intel.com>
>
> However, this driver does not directly use <linux/module.h>.

Just my luck - I looked at 3 or 4 other things that include of_platform.h
and they all *did* include module.h.

> platform_device.h #includes <linux/device.h>, which is where the
> problem lies:
>
> <linux/device.h> uses macros that are provided by <linux/module.h>
> so <linux/device.h> should #include <linux/module.h>.
>
> and that fixes this commit:
>
> commit 4c002c978b7f2f2306d53de051c054504af920a9
> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Date:   Mon Dec 9 20:33:03 2019 +0100
>
>     device.h: move 'struct driver' stuff out to device/driver.h

OK.. who's going to do that? Me, or Randy, or Greg?


[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o
Date: Mon, 02 Nov 2020 16:01:39 -0500	[thread overview]
Message-ID: <238534.1604350899@turing-police> (raw)
In-Reply-To: <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org>


[-- Attachment #1.1: Type: text/plain, Size: 804 bytes --]

On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said:

> also
> Reported-by: kernel test robot <lkp@intel.com>
>
> However, this driver does not directly use <linux/module.h>.

Just my luck - I looked at 3 or 4 other things that include of_platform.h
and they all *did* include module.h.

> platform_device.h #includes <linux/device.h>, which is where the
> problem lies:
>
> <linux/device.h> uses macros that are provided by <linux/module.h>
> so <linux/device.h> should #include <linux/module.h>.
>
> and that fixes this commit:
>
> commit 4c002c978b7f2f2306d53de051c054504af920a9
> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Date:   Mon Dec 9 20:33:03 2019 +0100
>
>     device.h: move 'struct driver' stuff out to device/driver.h

OK.. who's going to do that? Me, or Randy, or Greg?


[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-02 21:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 12:02 [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o Valdis Klētnieks
2020-11-02 12:02 ` Valdis Klētnieks
2020-11-02 17:15 ` Randy Dunlap
2020-11-02 17:15   ` Randy Dunlap
2020-11-02 21:01   ` Valdis Klētnieks [this message]
2020-11-02 21:01     ` Valdis Klētnieks
2020-11-02 21:31     ` Randy Dunlap
2020-11-02 21:31       ` Randy Dunlap
2020-11-02 23:52       ` Shawn Guo
2020-11-02 23:52         ` Shawn Guo
2020-11-02 23:59         ` Randy Dunlap
2020-11-02 23:59           ` Randy Dunlap
2020-11-03  1:45         ` Valdis Klētnieks
2020-11-03  1:45           ` Valdis Klētnieks
2020-11-02 20:17 ` kernel test robot
2020-11-02 20:17   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=238534.1604350899@turing-police \
    --to=valdis.kletnieks@vt.edu \
    --cc=aisheng.dong@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rdunlap@infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.