* Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
@ 2020-11-04 13:44 ` Marek Szyprowski
0 siblings, 0 replies; 20+ messages in thread
From: Marek Szyprowski @ 2020-11-04 13:44 UTC (permalink / raw)
To: Markus Reichl, Rob Herring, Kukjin Kim, Krzysztof Kozlowski
Cc: devicetree, linux-samsung-soc, linux-kernel, linux-arm-kernel
On 04.11.2020 14:13, Marek Szyprowski wrote:
> On 04.11.2020 14:06, Markus Reichl wrote:
>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>>> On 04.11.2020 11:25, Markus Reichl wrote:
>>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>>> Pin them to fixed values to ease booting in evironments where UUIDs
>>>> ar not practical.
>>>> Use newly introduced aliases for mmcblk devices from [1].
>>>>
>>>> [1]
>>>> https://patchwork.kernel.org/patch/11747669/
>>>>
>>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>>>> ---
>>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>> @@ -13,6 +13,11 @@
>>>> #include "exynos-mfc-reserved-memory.dtsi"
>>>> / {
>>>> + aliases {
>>>> + mmc0 = &sdhci_2;
>>>> + mmc1 = &mshc_0;
>>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0)
>>> and 2 for the SD-card (sdhci_2).
>> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
>> exynos4412.dts)?
> sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
> is not an issue. They cannot be used simultaneously. The latter is just
> faster, the first one has been left there mainly for the software
> compatibility.
I've thought a bit more on this and I would simply prefer to add generic
MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
bus numbers on all boards.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
2020-11-04 13:44 ` Marek Szyprowski
@ 2020-11-04 13:50 ` Markus Reichl
-1 siblings, 0 replies; 20+ messages in thread
From: Markus Reichl @ 2020-11-04 13:50 UTC (permalink / raw)
To: Marek Szyprowski, Rob Herring, Kukjin Kim, Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Hi Marek,
Am 04.11.20 um 14:44 schrieb Marek Szyprowski:
> On 04.11.2020 14:13, Marek Szyprowski wrote:
>> On 04.11.2020 14:06, Markus Reichl wrote:
>>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>>>> On 04.11.2020 11:25, Markus Reichl wrote:
>>>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>>>> Pin them to fixed values to ease booting in evironments where UUIDs
>>>>> ar not practical.
>>>>> Use newly introduced aliases for mmcblk devices from [1].
>>>>>
>>>>> [1]
>>>>> https://patchwork.kernel.org/patch/11747669/
>>>>>
>>>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>> ---
>>>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
>>>>> 1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
>>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> @@ -13,6 +13,11 @@
>>>>> #include "exynos-mfc-reserved-memory.dtsi"
>>>>> / {
>>>>> + aliases {
>>>>> + mmc0 = &sdhci_2;
>>>>> + mmc1 = &mshc_0;
>>>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0)
>>>> and 2 for the SD-card (sdhci_2).
>>> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
>>> exynos4412.dts)?
>> sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
>> is not an issue. They cannot be used simultaneously. The latter is just
>> faster, the first one has been left there mainly for the software
>> compatibility.
>
> I've thought a bit more on this and I would simply prefer to add generic
> MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
> 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
> bus numbers on all boards.
Ok, fine with me.
As this is beyond my knowledge I would like leave this task with you.
>
> Best regards
>
Gruß,
--
Markus Reichl
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
@ 2020-11-04 13:50 ` Markus Reichl
0 siblings, 0 replies; 20+ messages in thread
From: Markus Reichl @ 2020-11-04 13:50 UTC (permalink / raw)
To: Marek Szyprowski, Rob Herring, Kukjin Kim, Krzysztof Kozlowski
Cc: devicetree, linux-samsung-soc, linux-kernel, linux-arm-kernel
Hi Marek,
Am 04.11.20 um 14:44 schrieb Marek Szyprowski:
> On 04.11.2020 14:13, Marek Szyprowski wrote:
>> On 04.11.2020 14:06, Markus Reichl wrote:
>>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>>>> On 04.11.2020 11:25, Markus Reichl wrote:
>>>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>>>> Pin them to fixed values to ease booting in evironments where UUIDs
>>>>> ar not practical.
>>>>> Use newly introduced aliases for mmcblk devices from [1].
>>>>>
>>>>> [1]
>>>>> https://patchwork.kernel.org/patch/11747669/
>>>>>
>>>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>> ---
>>>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
>>>>> 1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
>>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> @@ -13,6 +13,11 @@
>>>>> #include "exynos-mfc-reserved-memory.dtsi"
>>>>> / {
>>>>> + aliases {
>>>>> + mmc0 = &sdhci_2;
>>>>> + mmc1 = &mshc_0;
>>>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0)
>>>> and 2 for the SD-card (sdhci_2).
>>> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
>>> exynos4412.dts)?
>> sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
>> is not an issue. They cannot be used simultaneously. The latter is just
>> faster, the first one has been left there mainly for the software
>> compatibility.
>
> I've thought a bit more on this and I would simply prefer to add generic
> MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
> 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
> bus numbers on all boards.
Ok, fine with me.
As this is beyond my knowledge I would like leave this task with you.
>
> Best regards
>
Gruß,
--
Markus Reichl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
2020-11-04 13:44 ` Marek Szyprowski
@ 2020-11-05 8:22 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-05 8:22 UTC (permalink / raw)
To: Marek Szyprowski
Cc: Markus Reichl, Rob Herring, Kukjin Kim, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
On Wed, Nov 04, 2020 at 02:44:10PM +0100, Marek Szyprowski wrote:
> On 04.11.2020 14:13, Marek Szyprowski wrote:
> > On 04.11.2020 14:06, Markus Reichl wrote:
> >> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
> >>> On 04.11.2020 11:25, Markus Reichl wrote:
> >>>> Recently introduced async probe on mmc devices can shuffle block IDs.
> >>>> Pin them to fixed values to ease booting in evironments where UUIDs
> >>>> ar not practical.
> >>>> Use newly introduced aliases for mmcblk devices from [1].
> >>>>
> >>>> [1]
> >>>> https://patchwork.kernel.org/patch/11747669/
> >>>>
> >>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> >>>> ---
> >>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
> >>>> 1 file changed, 5 insertions(+)
> >>>>
> >>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
> >>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >>>> @@ -13,6 +13,11 @@
> >>>> #include "exynos-mfc-reserved-memory.dtsi"
> >>>> / {
> >>>> + aliases {
> >>>> + mmc0 = &sdhci_2;
> >>>> + mmc1 = &mshc_0;
> >>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0)
> >>> and 2 for the SD-card (sdhci_2).
> >> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
> >> exynos4412.dts)?
> > sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
> > is not an issue. They cannot be used simultaneously. The latter is just
> > faster, the first one has been left there mainly for the software
> > compatibility.
>
> I've thought a bit more on this and I would simply prefer to add generic
> MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
> 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
> bus numbers on all boards.
I like this approach - I don't see much benefit of having different
numbering between boards of the same SoC.
Let's match old U-Boot behavior (I assume that people switch to PARTUUID
around the v4.0 mixup, so they should not be affected).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
@ 2020-11-05 8:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 20+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-05 8:22 UTC (permalink / raw)
To: Marek Szyprowski
Cc: devicetree, linux-samsung-soc, linux-kernel, Markus Reichl,
Rob Herring, Kukjin Kim, linux-arm-kernel
On Wed, Nov 04, 2020 at 02:44:10PM +0100, Marek Szyprowski wrote:
> On 04.11.2020 14:13, Marek Szyprowski wrote:
> > On 04.11.2020 14:06, Markus Reichl wrote:
> >> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
> >>> On 04.11.2020 11:25, Markus Reichl wrote:
> >>>> Recently introduced async probe on mmc devices can shuffle block IDs.
> >>>> Pin them to fixed values to ease booting in evironments where UUIDs
> >>>> ar not practical.
> >>>> Use newly introduced aliases for mmcblk devices from [1].
> >>>>
> >>>> [1]
> >>>> https://patchwork.kernel.org/patch/11747669/
> >>>>
> >>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> >>>> ---
> >>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
> >>>> 1 file changed, 5 insertions(+)
> >>>>
> >>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
> >>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >>>> @@ -13,6 +13,11 @@
> >>>> #include "exynos-mfc-reserved-memory.dtsi"
> >>>> / {
> >>>> + aliases {
> >>>> + mmc0 = &sdhci_2;
> >>>> + mmc1 = &mshc_0;
> >>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0)
> >>> and 2 for the SD-card (sdhci_2).
> >> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
> >> exynos4412.dts)?
> > sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
> > is not an issue. They cannot be used simultaneously. The latter is just
> > faster, the first one has been left there mainly for the software
> > compatibility.
>
> I've thought a bit more on this and I would simply prefer to add generic
> MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
> 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
> bus numbers on all boards.
I like this approach - I don't see much benefit of having different
numbering between boards of the same SoC.
Let's match old U-Boot behavior (I assume that people switch to PARTUUID
around the v4.0 mixup, so they should not be affected).
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
2020-11-04 13:44 ` Marek Szyprowski
@ 2020-11-05 8:31 ` Markus Reichl
-1 siblings, 0 replies; 20+ messages in thread
From: Markus Reichl @ 2020-11-05 8:31 UTC (permalink / raw)
To: Marek Szyprowski, Rob Herring, Kukjin Kim, Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 2151 bytes --]
Hi Marek,
on rk3399 the proposed ordering [1] is according to base address in DT.
[1]
https://patchwork.kernel.org/patch/11881427
Am 04.11.20 um 14:44 schrieb Marek Szyprowski:
> On 04.11.2020 14:13, Marek Szyprowski wrote:
>> On 04.11.2020 14:06, Markus Reichl wrote:
>>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>>>> On 04.11.2020 11:25, Markus Reichl wrote:
>>>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>>>> Pin them to fixed values to ease booting in evironments where UUIDs
>>>>> ar not practical.
>>>>> Use newly introduced aliases for mmcblk devices from [1].
>>>>>
>>>>> [1]
>>>>> https://patchwork.kernel.org/patch/11747669/
>>>>>
>>>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>> ---
>>>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
>>>>> 1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
>>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> @@ -13,6 +13,11 @@
>>>>> #include "exynos-mfc-reserved-memory.dtsi"
>>>>> / {
>>>>> + aliases {
>>>>> + mmc0 = &sdhci_2;
>>>>> + mmc1 = &mshc_0;
>>>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0)
>>>> and 2 for the SD-card (sdhci_2).
>>> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
>>> exynos4412.dts)?
>> sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
>> is not an issue. They cannot be used simultaneously. The latter is just
>> faster, the first one has been left there mainly for the software
>> compatibility.
>
> I've thought a bit more on this and I would simply prefer to add generic
> MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
> 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
> bus numbers on all boards.
>
> Best regards
>
Gruß,
--
Markus Reichl
[-- Attachment #1.1.2: OpenPGP_0x3A25DE0E6B1AFDB2.asc --]
[-- Type: application/pgp-keys, Size: 3047 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 665 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
@ 2020-11-05 8:31 ` Markus Reichl
0 siblings, 0 replies; 20+ messages in thread
From: Markus Reichl @ 2020-11-05 8:31 UTC (permalink / raw)
To: Marek Szyprowski, Rob Herring, Kukjin Kim, Krzysztof Kozlowski
Cc: devicetree, linux-samsung-soc, linux-kernel, linux-arm-kernel
[-- Attachment #1.1.1.1: Type: text/plain, Size: 2151 bytes --]
Hi Marek,
on rk3399 the proposed ordering [1] is according to base address in DT.
[1]
https://patchwork.kernel.org/patch/11881427
Am 04.11.20 um 14:44 schrieb Marek Szyprowski:
> On 04.11.2020 14:13, Marek Szyprowski wrote:
>> On 04.11.2020 14:06, Markus Reichl wrote:
>>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>>>> On 04.11.2020 11:25, Markus Reichl wrote:
>>>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>>>> Pin them to fixed values to ease booting in evironments where UUIDs
>>>>> ar not practical.
>>>>> Use newly introduced aliases for mmcblk devices from [1].
>>>>>
>>>>> [1]
>>>>> https://patchwork.kernel.org/patch/11747669/
>>>>>
>>>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>> ---
>>>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
>>>>> 1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
>>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>> @@ -13,6 +13,11 @@
>>>>> #include "exynos-mfc-reserved-memory.dtsi"
>>>>> / {
>>>>> + aliases {
>>>>> + mmc0 = &sdhci_2;
>>>>> + mmc1 = &mshc_0;
>>>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0)
>>>> and 2 for the SD-card (sdhci_2).
>>> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
>>> exynos4412.dts)?
>> sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
>> is not an issue. They cannot be used simultaneously. The latter is just
>> faster, the first one has been left there mainly for the software
>> compatibility.
>
> I've thought a bit more on this and I would simply prefer to add generic
> MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
> 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
> bus numbers on all boards.
>
> Best regards
>
Gruß,
--
Markus Reichl
[-- Attachment #1.1.1.2: OpenPGP_0x3A25DE0E6B1AFDB2.asc --]
[-- Type: application/pgp-keys, Size: 3047 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 665 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
2020-11-05 8:31 ` Markus Reichl
@ 2020-11-05 11:26 ` Robin Murphy
-1 siblings, 0 replies; 20+ messages in thread
From: Robin Murphy @ 2020-11-05 11:26 UTC (permalink / raw)
To: Markus Reichl, Marek Szyprowski, Rob Herring, Kukjin Kim,
Krzysztof Kozlowski
Cc: devicetree, linux-samsung-soc, linux-kernel, linux-arm-kernel
On 2020-11-05 08:31, Markus Reichl wrote:
> Hi Marek,
>
> on rk3399 the proposed ordering [1] is according to base address in DT.
FWIW, note that in RK3399's case the SoC itself provides no logical
numbering to follow - the pin groups are named "EMMC", "SDIO0" and
"SDMMC0" in the datasheet, while the TRM uses "emmc", "sdio" and "sdmmc"
in signal and register names.
If the SoC *does* have an inherent notion of numbered interfaces, I
would agree that following that numbering is the most logical thing to do.
Robin.
>
> [1]
> https://patchwork.kernel.org/patch/11881427
>
> Am 04.11.20 um 14:44 schrieb Marek Szyprowski:
>> On 04.11.2020 14:13, Marek Szyprowski wrote:
>>> On 04.11.2020 14:06, Markus Reichl wrote:
>>>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>>>>> On 04.11.2020 11:25, Markus Reichl wrote:
>>>>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>>>>> Pin them to fixed values to ease booting in evironments where UUIDs
>>>>>> ar not practical.
>>>>>> Use newly introduced aliases for mmcblk devices from [1].
>>>>>>
>>>>>> [1]
>>>>>> https://patchwork.kernel.org/patch/11747669/
>>>>>>
>>>>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>> ---
>>>>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
>>>>>> 1 file changed, 5 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
>>>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> @@ -13,6 +13,11 @@
>>>>>> #include "exynos-mfc-reserved-memory.dtsi"
>>>>>> / {
>>>>>> + aliases {
>>>>>> + mmc0 = &sdhci_2;
>>>>>> + mmc1 = &mshc_0;
>>>>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC
>>>>> (mshc_0)
>>>>> and 2 for the SD-card (sdhci_2).
>>>> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
>>>> exynos4412.dts)?
>>> sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
>>> is not an issue. They cannot be used simultaneously. The latter is just
>>> faster, the first one has been left there mainly for the software
>>> compatibility.
>>
>> I've thought a bit more on this and I would simply prefer to add generic
>> MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
>> 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
>> bus numbers on all boards.
>>
>> Best regards
>>
>
> Gruß,
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
@ 2020-11-05 11:26 ` Robin Murphy
0 siblings, 0 replies; 20+ messages in thread
From: Robin Murphy @ 2020-11-05 11:26 UTC (permalink / raw)
To: Markus Reichl, Marek Szyprowski, Rob Herring, Kukjin Kim,
Krzysztof Kozlowski
Cc: devicetree, linux-samsung-soc, linux-kernel, linux-arm-kernel
On 2020-11-05 08:31, Markus Reichl wrote:
> Hi Marek,
>
> on rk3399 the proposed ordering [1] is according to base address in DT.
FWIW, note that in RK3399's case the SoC itself provides no logical
numbering to follow - the pin groups are named "EMMC", "SDIO0" and
"SDMMC0" in the datasheet, while the TRM uses "emmc", "sdio" and "sdmmc"
in signal and register names.
If the SoC *does* have an inherent notion of numbered interfaces, I
would agree that following that numbering is the most logical thing to do.
Robin.
>
> [1]
> https://patchwork.kernel.org/patch/11881427
>
> Am 04.11.20 um 14:44 schrieb Marek Szyprowski:
>> On 04.11.2020 14:13, Marek Szyprowski wrote:
>>> On 04.11.2020 14:06, Markus Reichl wrote:
>>>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>>>>> On 04.11.2020 11:25, Markus Reichl wrote:
>>>>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>>>>> Pin them to fixed values to ease booting in evironments where UUIDs
>>>>>> ar not practical.
>>>>>> Use newly introduced aliases for mmcblk devices from [1].
>>>>>>
>>>>>> [1]
>>>>>> https://patchwork.kernel.org/patch/11747669/
>>>>>>
>>>>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>> ---
>>>>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
>>>>>> 1 file changed, 5 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
>>>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> @@ -13,6 +13,11 @@
>>>>>> #include "exynos-mfc-reserved-memory.dtsi"
>>>>>> / {
>>>>>> + aliases {
>>>>>> + mmc0 = &sdhci_2;
>>>>>> + mmc1 = &mshc_0;
>>>>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC
>>>>> (mshc_0)
>>>>> and 2 for the SD-card (sdhci_2).
>>>> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
>>>> exynos4412.dts)?
>>> sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
>>> is not an issue. They cannot be used simultaneously. The latter is just
>>> faster, the first one has been left there mainly for the software
>>> compatibility.
>>
>> I've thought a bit more on this and I would simply prefer to add generic
>> MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
>> 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
>> bus numbers on all boards.
>>
>> Best regards
>>
>
> Gruß,
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread