All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alice Guo <alice.guo@nxp.com>
Cc: devicetree@vger.kernel.org, peng.fan@nxp.com,
	s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, linux-imx@nxp.com, shawnguo@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID
Date: Sat, 14 Nov 2020 17:49:36 +0100	[thread overview]
Message-ID: <20201114164936.GA32552@kozik-lap> (raw)
In-Reply-To: <20201113110409.13546-1-alice.guo@nxp.com>

On Fri, Nov 13, 2020 at 07:04:06PM +0800, Alice Guo wrote:
> Add DT Binding doc for the Unique ID of i.MX 8M series.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
>  .../devicetree/bindings/arm/fsl.yaml          | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index e4db0f9ed664..f4faebbb57da 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -901,6 +901,31 @@ properties:
>                - fsl,s32v234-evb           # S32V234-EVB2 Customer Evaluation Board
>            - const: fsl,s32v234
> 
> +  soc:
> +    type: object
> +    properties:
> +      compatible:
> +        oneOf:
> +          - description: i.MX8M SoCs
> +            items:
> +              - enum:
> +                  - fsl,imx8mm-soc
> +                  - fsl,imx8mn-soc
> +                  - fsl,imx8mp-soc
> +                  - fsl,imx8mq-soc
> +              - const: simple-bus
> +
> +          - description: Other SoCs
> +            items:
> +              - const: simple-bus
> +
> +      nvmem-cells:
> +        maxItems: 1
> +        description: Phandle to the SOC Unique ID provided by a nvmem node
> +
> +      nvmem-cells-names:
> +        const: soc_unique_id
> +
>  additionalProperties: true

The "soc" node should be required for these compatibles. Otherwise you
will have to stay with this
backwards-compatible-DTB-device-initcall-glue for many years... I think
you can achieve it with allOf.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alice Guo <alice.guo@nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	linux-imx@nxp.com, peng.fan@nxp.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID
Date: Sat, 14 Nov 2020 17:49:36 +0100	[thread overview]
Message-ID: <20201114164936.GA32552@kozik-lap> (raw)
In-Reply-To: <20201113110409.13546-1-alice.guo@nxp.com>

On Fri, Nov 13, 2020 at 07:04:06PM +0800, Alice Guo wrote:
> Add DT Binding doc for the Unique ID of i.MX 8M series.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
>  .../devicetree/bindings/arm/fsl.yaml          | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index e4db0f9ed664..f4faebbb57da 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -901,6 +901,31 @@ properties:
>                - fsl,s32v234-evb           # S32V234-EVB2 Customer Evaluation Board
>            - const: fsl,s32v234
> 
> +  soc:
> +    type: object
> +    properties:
> +      compatible:
> +        oneOf:
> +          - description: i.MX8M SoCs
> +            items:
> +              - enum:
> +                  - fsl,imx8mm-soc
> +                  - fsl,imx8mn-soc
> +                  - fsl,imx8mp-soc
> +                  - fsl,imx8mq-soc
> +              - const: simple-bus
> +
> +          - description: Other SoCs
> +            items:
> +              - const: simple-bus
> +
> +      nvmem-cells:
> +        maxItems: 1
> +        description: Phandle to the SOC Unique ID provided by a nvmem node
> +
> +      nvmem-cells-names:
> +        const: soc_unique_id
> +
>  additionalProperties: true

The "soc" node should be required for these compatibles. Otherwise you
will have to stay with this
backwards-compatible-DTB-device-initcall-glue for many years... I think
you can achieve it with allOf.

Best regards,
Krzysztof


  parent reply	other threads:[~2020-11-14 16:50 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 11:04 [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo
2020-11-13 11:04 ` Alice Guo
2020-11-13 11:04 ` [PATCH v3 2/4] arm64: dts: imx8m: add compatible string to .dtsi file Alice Guo
2020-11-13 11:04   ` Alice Guo
2020-11-14 15:57   ` Krzysztof Kozlowski
2020-11-14 15:57     ` Krzysztof Kozlowski
2020-11-16  7:12     ` [EXT] " Alice Guo
2020-11-16  7:12       ` Alice Guo
2020-11-13 11:04 ` [PATCH v3 3/4] arm64: dts: imx8m: add nvmem-cell related stuff Alice Guo
2020-11-13 11:04   ` Alice Guo
2020-11-14 16:00   ` Krzysztof Kozlowski
2020-11-14 16:00     ` Krzysztof Kozlowski
2020-11-16  7:16     ` [EXT] " Alice Guo
2020-11-16  7:16       ` Alice Guo
2020-11-13 11:04 ` [PATCH v3 4/4] soc: imx8m: change to use platform driver Alice Guo
2020-11-13 11:04   ` Alice Guo
2020-11-14 16:41   ` Krzysztof Kozlowski
2020-11-14 16:41     ` Krzysztof Kozlowski
2020-11-16  8:18     ` [EXT] " Alice Guo
2020-11-16  8:18       ` Alice Guo
2020-11-16 16:13       ` Krzysztof Kozlowski
2020-11-16 16:13         ` Krzysztof Kozlowski
2020-11-18 10:28         ` Alice Guo
2020-11-18 10:28           ` Alice Guo
2020-11-18 10:42           ` Krzysztof Kozlowski
2020-11-18 10:42             ` Krzysztof Kozlowski
2020-11-18 14:07             ` Alice Guo
2020-11-18 14:07               ` Alice Guo
2020-11-18 14:10               ` Krzysztof Kozlowski
2020-11-18 14:10                 ` Krzysztof Kozlowski
2020-11-19  7:32                 ` Alice Guo
2020-11-19  7:32                   ` Alice Guo
2020-11-19  9:42                   ` Krzysztof Kozlowski
2020-11-19  9:42                     ` Krzysztof Kozlowski
2020-11-14 15:55 ` [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Krzysztof Kozlowski
2020-11-14 15:55   ` Krzysztof Kozlowski
2020-11-14 16:49 ` Krzysztof Kozlowski [this message]
2020-11-14 16:49   ` Krzysztof Kozlowski
2020-11-16  7:04   ` [EXT] " Alice Guo
2020-11-16  7:04     ` Alice Guo
2020-11-16 16:03     ` Krzysztof Kozlowski
2020-11-16 16:03       ` Krzysztof Kozlowski
2020-11-17  7:12       ` Alice Guo
2020-11-17  7:12         ` Alice Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201114164936.GA32552@kozik-lap \
    --to=krzk@kernel.org \
    --cc=alice.guo@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.