All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alice Guo <alice.guo@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Peng Fan <peng.fan@nxp.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver
Date: Wed, 18 Nov 2020 11:42:26 +0100	[thread overview]
Message-ID: <20201118104226.GA23766@kozik-lap> (raw)
In-Reply-To: <AM6PR04MB60534E7BD063455FDA2649C3E2E10@AM6PR04MB6053.eurprd04.prod.outlook.com>

On Wed, Nov 18, 2020 at 10:28:47AM +0000, Alice Guo wrote:
 > 
> > If it is properly explained and there is no other way then yes, you could. Here, for
> > old DTBs, I would prefer to use
> > of_platform_device_create() and bind to "soc" node (child of root).
> > This way you would always have device and exactly one entry point for the
> > probe.
> > 
> 
> static struct platform_driver imx8_soc_init_driver = {
> 	.probe = imx8_soc_init_probe,
> 	.driver = {
> 		.name = "soc@0",
> 	},
> };
> Can I use "soc@0" to match this driver? It will not use of_platform_device_create(). It will use of_find_property() to determine whether
> and nvmem-cells can be used. If there is no nvmem-cells, it will use the old way, which supports old DTBS. There is no need to add new
> compatible.

No, the soc@0 is not a proper name for the driver.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alice Guo <alice.guo@nxp.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	dl-linux-imx <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver
Date: Wed, 18 Nov 2020 11:42:26 +0100	[thread overview]
Message-ID: <20201118104226.GA23766@kozik-lap> (raw)
In-Reply-To: <AM6PR04MB60534E7BD063455FDA2649C3E2E10@AM6PR04MB6053.eurprd04.prod.outlook.com>

On Wed, Nov 18, 2020 at 10:28:47AM +0000, Alice Guo wrote:
 > 
> > If it is properly explained and there is no other way then yes, you could. Here, for
> > old DTBs, I would prefer to use
> > of_platform_device_create() and bind to "soc" node (child of root).
> > This way you would always have device and exactly one entry point for the
> > probe.
> > 
> 
> static struct platform_driver imx8_soc_init_driver = {
> 	.probe = imx8_soc_init_probe,
> 	.driver = {
> 		.name = "soc@0",
> 	},
> };
> Can I use "soc@0" to match this driver? It will not use of_platform_device_create(). It will use of_find_property() to determine whether
> and nvmem-cells can be used. If there is no nvmem-cells, it will use the old way, which supports old DTBS. There is no need to add new
> compatible.

No, the soc@0 is not a proper name for the driver.

Best regards,
Krzysztof

  reply	other threads:[~2020-11-18 10:43 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 11:04 [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo
2020-11-13 11:04 ` Alice Guo
2020-11-13 11:04 ` [PATCH v3 2/4] arm64: dts: imx8m: add compatible string to .dtsi file Alice Guo
2020-11-13 11:04   ` Alice Guo
2020-11-14 15:57   ` Krzysztof Kozlowski
2020-11-14 15:57     ` Krzysztof Kozlowski
2020-11-16  7:12     ` [EXT] " Alice Guo
2020-11-16  7:12       ` Alice Guo
2020-11-13 11:04 ` [PATCH v3 3/4] arm64: dts: imx8m: add nvmem-cell related stuff Alice Guo
2020-11-13 11:04   ` Alice Guo
2020-11-14 16:00   ` Krzysztof Kozlowski
2020-11-14 16:00     ` Krzysztof Kozlowski
2020-11-16  7:16     ` [EXT] " Alice Guo
2020-11-16  7:16       ` Alice Guo
2020-11-13 11:04 ` [PATCH v3 4/4] soc: imx8m: change to use platform driver Alice Guo
2020-11-13 11:04   ` Alice Guo
2020-11-14 16:41   ` Krzysztof Kozlowski
2020-11-14 16:41     ` Krzysztof Kozlowski
2020-11-16  8:18     ` [EXT] " Alice Guo
2020-11-16  8:18       ` Alice Guo
2020-11-16 16:13       ` Krzysztof Kozlowski
2020-11-16 16:13         ` Krzysztof Kozlowski
2020-11-18 10:28         ` Alice Guo
2020-11-18 10:28           ` Alice Guo
2020-11-18 10:42           ` Krzysztof Kozlowski [this message]
2020-11-18 10:42             ` Krzysztof Kozlowski
2020-11-18 14:07             ` Alice Guo
2020-11-18 14:07               ` Alice Guo
2020-11-18 14:10               ` Krzysztof Kozlowski
2020-11-18 14:10                 ` Krzysztof Kozlowski
2020-11-19  7:32                 ` Alice Guo
2020-11-19  7:32                   ` Alice Guo
2020-11-19  9:42                   ` Krzysztof Kozlowski
2020-11-19  9:42                     ` Krzysztof Kozlowski
2020-11-14 15:55 ` [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Krzysztof Kozlowski
2020-11-14 15:55   ` Krzysztof Kozlowski
2020-11-14 16:49 ` Krzysztof Kozlowski
2020-11-14 16:49   ` Krzysztof Kozlowski
2020-11-16  7:04   ` [EXT] " Alice Guo
2020-11-16  7:04     ` Alice Guo
2020-11-16 16:03     ` Krzysztof Kozlowski
2020-11-16 16:03       ` Krzysztof Kozlowski
2020-11-17  7:12       ` Alice Guo
2020-11-17  7:12         ` Alice Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201118104226.GA23766@kozik-lap \
    --to=krzk@kernel.org \
    --cc=alice.guo@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.