From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Daniel Rosenberg <drosen@google.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Eric Biggers <ebiggers@kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Chao Yu <chao@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Richard Weinberger <richard@nod.at>,
linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mtd@lists.infradead.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel-team@android.com
Subject: Re: [PATCH v2 2/3] fscrypt: Have filesystems handle their d_ops
Date: Tue, 17 Nov 2020 09:03:26 -0500 [thread overview]
Message-ID: <20201117140326.GA445084@mit.edu> (raw)
In-Reply-To: <20201117040315.28548-3-drosen@google.com>
On Tue, Nov 17, 2020 at 04:03:14AM +0000, Daniel Rosenberg wrote:
> This shifts the responsibility of setting up dentry operations from
> fscrypt to the individual filesystems, allowing them to have their own
> operations while still setting fscrypt's d_revalidate as appropriate.
>
> Most filesystems can just use generic_set_encrypted_ci_d_ops, unless
> they have their own specific dentry operations as well. That operation
> will set the minimal d_ops required under the circumstances.
>
> Since the fscrypt d_ops are set later on, we must set all d_ops there,
> since we cannot adjust those later on. This should not result in any
> change in behavior.
>
> Signed-off-by: Daniel Rosenberg <drosen@google.com>
Acked-by: Theodore Ts'o <tytso@mit.edu>
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Daniel Rosenberg <drosen@google.com>
Cc: kernel-team@android.com, Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH v2 2/3] fscrypt: Have filesystems handle their d_ops
Date: Tue, 17 Nov 2020 09:03:26 -0500 [thread overview]
Message-ID: <20201117140326.GA445084@mit.edu> (raw)
In-Reply-To: <20201117040315.28548-3-drosen@google.com>
On Tue, Nov 17, 2020 at 04:03:14AM +0000, Daniel Rosenberg wrote:
> This shifts the responsibility of setting up dentry operations from
> fscrypt to the individual filesystems, allowing them to have their own
> operations while still setting fscrypt's d_revalidate as appropriate.
>
> Most filesystems can just use generic_set_encrypted_ci_d_ops, unless
> they have their own specific dentry operations as well. That operation
> will set the minimal d_ops required under the circumstances.
>
> Since the fscrypt d_ops are set later on, we must set all d_ops there,
> since we cannot adjust those later on. This should not result in any
> change in behavior.
>
> Signed-off-by: Daniel Rosenberg <drosen@google.com>
Acked-by: Theodore Ts'o <tytso@mit.edu>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Daniel Rosenberg <drosen@google.com>
Cc: kernel-team@android.com, Richard Weinberger <richard@nod.at>,
Chao Yu <chao@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [PATCH v2 2/3] fscrypt: Have filesystems handle their d_ops
Date: Tue, 17 Nov 2020 09:03:26 -0500 [thread overview]
Message-ID: <20201117140326.GA445084@mit.edu> (raw)
In-Reply-To: <20201117040315.28548-3-drosen@google.com>
On Tue, Nov 17, 2020 at 04:03:14AM +0000, Daniel Rosenberg wrote:
> This shifts the responsibility of setting up dentry operations from
> fscrypt to the individual filesystems, allowing them to have their own
> operations while still setting fscrypt's d_revalidate as appropriate.
>
> Most filesystems can just use generic_set_encrypted_ci_d_ops, unless
> they have their own specific dentry operations as well. That operation
> will set the minimal d_ops required under the circumstances.
>
> Since the fscrypt d_ops are set later on, we must set all d_ops there,
> since we cannot adjust those later on. This should not result in any
> change in behavior.
>
> Signed-off-by: Daniel Rosenberg <drosen@google.com>
Acked-by: Theodore Ts'o <tytso@mit.edu>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-11-17 14:04 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 4:03 [PATCH v2 0/3] Add support for Encryption and Casefolding in F2FS Daniel Rosenberg
2020-11-17 4:03 ` Daniel Rosenberg
2020-11-17 4:03 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-17 4:03 ` [PATCH v2 1/3] libfs: Add generic function for setting dentry_ops Daniel Rosenberg
2020-11-17 4:03 ` Daniel Rosenberg
2020-11-17 4:03 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-17 17:33 ` Theodore Y. Ts'o
2020-11-17 17:33 ` Theodore Y. Ts'o
2020-11-17 17:33 ` [f2fs-dev] " Theodore Y. Ts'o
2020-11-17 18:16 ` Eric Biggers
2020-11-17 18:16 ` Eric Biggers
2020-11-17 18:16 ` [f2fs-dev] " Eric Biggers
2020-11-17 18:36 ` Eric Biggers
2020-11-17 18:36 ` Eric Biggers
2020-11-17 18:36 ` Eric Biggers
2020-11-17 4:03 ` [PATCH v2 2/3] fscrypt: Have filesystems handle their d_ops Daniel Rosenberg
2020-11-17 4:03 ` Daniel Rosenberg
2020-11-17 4:03 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-17 14:03 ` Theodore Y. Ts'o [this message]
2020-11-17 14:03 ` Theodore Y. Ts'o
2020-11-17 14:03 ` [f2fs-dev] " Theodore Y. Ts'o
2020-11-17 17:04 ` Jaegeuk Kim
2020-11-17 17:04 ` Jaegeuk Kim
2020-11-17 17:04 ` [f2fs-dev] " Jaegeuk Kim
2020-11-17 17:34 ` Theodore Y. Ts'o
2020-11-17 17:34 ` Theodore Y. Ts'o
2020-11-17 17:34 ` [f2fs-dev] " Theodore Y. Ts'o
2020-11-17 18:31 ` Eric Biggers
2020-11-17 18:31 ` Eric Biggers
2020-11-17 18:31 ` [f2fs-dev] " Eric Biggers
2020-11-17 4:03 ` [PATCH v2 3/3] f2fs: Handle casefolding with Encryption Daniel Rosenberg
2020-11-17 4:03 ` Daniel Rosenberg
2020-11-17 4:03 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-17 14:06 ` Dan Carpenter
2020-11-17 14:06 ` [kbuild] " Dan Carpenter
2020-11-17 18:50 ` Eric Biggers
2020-11-17 18:50 ` Eric Biggers
2020-11-17 18:50 ` [f2fs-dev] " Eric Biggers
2020-11-18 6:22 ` Daniel Rosenberg
2020-11-18 6:22 ` Daniel Rosenberg
2020-11-18 6:22 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-18 6:27 ` Eric Biggers
2020-11-18 6:27 ` Eric Biggers
2020-11-18 6:27 ` [f2fs-dev] " Eric Biggers
2020-11-18 1:03 ` kernel test robot
2020-11-17 18:53 ` [PATCH v2 0/3] Add support for Encryption and Casefolding in F2FS Eric Biggers
2020-11-17 18:53 ` Eric Biggers
2020-11-17 18:53 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117140326.GA445084@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=chao@kernel.org \
--cc=drosen@google.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.