From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v2 3/3] f2fs: Handle casefolding with Encryption
Date: Tue, 17 Nov 2020 17:06:13 +0300 [thread overview]
Message-ID: <20201117140613.GH18329@kadam> (raw)
In-Reply-To: <20201117040315.28548-4-drosen@google.com>
[-- Attachment #1: Type: text/plain, Size: 3013 bytes --]
Hi Daniel,
url: https://github.com/0day-ci/linux/commits/Daniel-Rosenberg/Add-support-for-Encryption-and-Casefolding-in-F2FS/20201117-120753
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> fs/f2fs/dir.c:206:3: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]
dentry_page = ERR_CAST(res);
^
fs/f2fs/f2fs.h:2200:15: warning: Local variable valid_node_count shadows outer function [shadowFunction]
unsigned int valid_node_count, user_block_count;
^
fs/f2fs/f2fs.h:2296:28: note: Shadowed declaration
static inline unsigned int valid_node_count(struct f2fs_sb_info *sbi)
^
fs/f2fs/f2fs.h:2200:15: note: Shadow variable
unsigned int valid_node_count, user_block_count;
^
vim +206 fs/f2fs/dir.c
2c2eb7a300cd7c6 Daniel Rosenberg 2019-07-23 192 static struct f2fs_dir_entry *find_in_block(struct inode *dir,
2c2eb7a300cd7c6 Daniel Rosenberg 2019-07-23 193 struct page *dentry_page,
43c780ba26244e4 Eric Biggers 2020-05-07 194 const struct f2fs_filename *fname,
17f930e0a649e15 Chao Yu 2020-09-26 195 int *max_slots)
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 196 {
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 197 struct f2fs_dentry_block *dentry_blk;
7b3cd7d6f026784 Jaegeuk Kim 2014-10-18 198 struct f2fs_dentry_ptr d;
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 199 struct f2fs_dir_entry *res;
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 200
bdbc90fa55af632 Yunlong Song 2018-02-28 201 dentry_blk = (struct f2fs_dentry_block *)page_address(dentry_page);
7b3cd7d6f026784 Jaegeuk Kim 2014-10-18 202
2c2eb7a300cd7c6 Daniel Rosenberg 2019-07-23 203 make_dentry_ptr_block(dir, &d, dentry_blk);
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 204 res = f2fs_find_target_dentry(&d, fname, max_slots);
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 205 if (IS_ERR(res)) {
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 @206 dentry_page = ERR_CAST(res);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 207 res = NULL;
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 208 }
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 209 return res;
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 210 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [kbuild] Re: [PATCH v2 3/3] f2fs: Handle casefolding with Encryption
Date: Tue, 17 Nov 2020 17:06:13 +0300 [thread overview]
Message-ID: <20201117140613.GH18329@kadam> (raw)
In-Reply-To: <20201117040315.28548-4-drosen@google.com>
[-- Attachment #1: Type: text/plain, Size: 3013 bytes --]
Hi Daniel,
url: https://github.com/0day-ci/linux/commits/Daniel-Rosenberg/Add-support-for-Encryption-and-Casefolding-in-F2FS/20201117-120753
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> fs/f2fs/dir.c:206:3: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]
dentry_page = ERR_CAST(res);
^
fs/f2fs/f2fs.h:2200:15: warning: Local variable valid_node_count shadows outer function [shadowFunction]
unsigned int valid_node_count, user_block_count;
^
fs/f2fs/f2fs.h:2296:28: note: Shadowed declaration
static inline unsigned int valid_node_count(struct f2fs_sb_info *sbi)
^
fs/f2fs/f2fs.h:2200:15: note: Shadow variable
unsigned int valid_node_count, user_block_count;
^
vim +206 fs/f2fs/dir.c
2c2eb7a300cd7c6 Daniel Rosenberg 2019-07-23 192 static struct f2fs_dir_entry *find_in_block(struct inode *dir,
2c2eb7a300cd7c6 Daniel Rosenberg 2019-07-23 193 struct page *dentry_page,
43c780ba26244e4 Eric Biggers 2020-05-07 194 const struct f2fs_filename *fname,
17f930e0a649e15 Chao Yu 2020-09-26 195 int *max_slots)
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 196 {
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 197 struct f2fs_dentry_block *dentry_blk;
7b3cd7d6f026784 Jaegeuk Kim 2014-10-18 198 struct f2fs_dentry_ptr d;
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 199 struct f2fs_dir_entry *res;
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 200
bdbc90fa55af632 Yunlong Song 2018-02-28 201 dentry_blk = (struct f2fs_dentry_block *)page_address(dentry_page);
7b3cd7d6f026784 Jaegeuk Kim 2014-10-18 202
2c2eb7a300cd7c6 Daniel Rosenberg 2019-07-23 203 make_dentry_ptr_block(dir, &d, dentry_blk);
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 204 res = f2fs_find_target_dentry(&d, fname, max_slots);
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 205 if (IS_ERR(res)) {
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 @206 dentry_page = ERR_CAST(res);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 207 res = NULL;
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 208 }
6f0a1d1d8d24e7e Daniel Rosenberg 2020-11-17 209 return res;
4e6ebf6d4935914 Jaegeuk Kim 2014-10-13 210 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
next prev parent reply other threads:[~2020-11-17 14:06 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 4:03 [PATCH v2 0/3] Add support for Encryption and Casefolding in F2FS Daniel Rosenberg
2020-11-17 4:03 ` Daniel Rosenberg
2020-11-17 4:03 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-17 4:03 ` [PATCH v2 1/3] libfs: Add generic function for setting dentry_ops Daniel Rosenberg
2020-11-17 4:03 ` Daniel Rosenberg
2020-11-17 4:03 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-17 17:33 ` Theodore Y. Ts'o
2020-11-17 17:33 ` Theodore Y. Ts'o
2020-11-17 17:33 ` [f2fs-dev] " Theodore Y. Ts'o
2020-11-17 18:16 ` Eric Biggers
2020-11-17 18:16 ` Eric Biggers
2020-11-17 18:16 ` [f2fs-dev] " Eric Biggers
2020-11-17 18:36 ` Eric Biggers
2020-11-17 18:36 ` Eric Biggers
2020-11-17 18:36 ` Eric Biggers
2020-11-17 4:03 ` [PATCH v2 2/3] fscrypt: Have filesystems handle their d_ops Daniel Rosenberg
2020-11-17 4:03 ` Daniel Rosenberg
2020-11-17 4:03 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-17 14:03 ` Theodore Y. Ts'o
2020-11-17 14:03 ` Theodore Y. Ts'o
2020-11-17 14:03 ` [f2fs-dev] " Theodore Y. Ts'o
2020-11-17 17:04 ` Jaegeuk Kim
2020-11-17 17:04 ` Jaegeuk Kim
2020-11-17 17:04 ` [f2fs-dev] " Jaegeuk Kim
2020-11-17 17:34 ` Theodore Y. Ts'o
2020-11-17 17:34 ` Theodore Y. Ts'o
2020-11-17 17:34 ` [f2fs-dev] " Theodore Y. Ts'o
2020-11-17 18:31 ` Eric Biggers
2020-11-17 18:31 ` Eric Biggers
2020-11-17 18:31 ` [f2fs-dev] " Eric Biggers
2020-11-17 4:03 ` [PATCH v2 3/3] f2fs: Handle casefolding with Encryption Daniel Rosenberg
2020-11-17 4:03 ` Daniel Rosenberg
2020-11-17 4:03 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-17 14:06 ` Dan Carpenter [this message]
2020-11-17 14:06 ` [kbuild] " Dan Carpenter
2020-11-17 18:50 ` Eric Biggers
2020-11-17 18:50 ` Eric Biggers
2020-11-17 18:50 ` [f2fs-dev] " Eric Biggers
2020-11-18 6:22 ` Daniel Rosenberg
2020-11-18 6:22 ` Daniel Rosenberg
2020-11-18 6:22 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-11-18 6:27 ` Eric Biggers
2020-11-18 6:27 ` Eric Biggers
2020-11-18 6:27 ` [f2fs-dev] " Eric Biggers
2020-11-18 1:03 ` kernel test robot
2020-11-17 18:53 ` [PATCH v2 0/3] Add support for Encryption and Casefolding in F2FS Eric Biggers
2020-11-17 18:53 ` Eric Biggers
2020-11-17 18:53 ` [f2fs-dev] " Eric Biggers
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 12:55 [PATCH v2 3/3] f2fs: Handle casefolding with Encryption kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117140613.GH18329@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.