All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: devicetree@vger.kernel.org, Chen Zhou <chenzhou10@huawei.com>,
	will@kernel.org, linux-kernel@vger.kernel.org,
	jeremy.linton@arm.com, hch@lst.de,
	iommu@lists.linux-foundation.org, robh+dt@kernel.org,
	James Morse <james.morse@arm.com>,
	linux-rpi-kernel@lists.infradead.org, guohanjun@huawei.com,
	robin.murphy@arm.com, ardb@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/7] arm64: mm: Move reserve_crashkernel() into mem_init()
Date: Thu, 19 Nov 2020 17:25:24 +0000	[thread overview]
Message-ID: <20201119172523.GG4376@gaia> (raw)
In-Reply-To: <20201119171048.GD4376@gaia>

On Thu, Nov 19, 2020 at 05:10:49PM +0000, Catalin Marinas wrote:
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index ed71b1c305d7..acdec0c67d3b 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -469,6 +469,21 @@ void __init mark_linear_text_alias_ro(void)
>  			    PAGE_KERNEL_RO);
>  }
>  
> +static bool crash_mem_map __initdata;
> +
> +static int __init enable_crash_mem_map(char *arg)
> +{
> +	/*
> +	 * Proper parameter parsing is done by reserve_crashkernel(). We only
> +	 * need to know if the linear map has to avoid block mappings so that
> +	 * the crashkernel reservations can be unmapped later.
> +	 */
> +	crash_mem_map = false;

It should be set to true.

-- 
Catalin
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com,
	Chen Zhou <chenzhou10@huawei.com>,
	will@kernel.org, linux-kernel@vger.kernel.org,
	jeremy.linton@arm.com, hch@lst.de,
	iommu@lists.linux-foundation.org, robh+dt@kernel.org,
	James Morse <james.morse@arm.com>,
	linux-rpi-kernel@lists.infradead.org, guohanjun@huawei.com,
	robin.murphy@arm.com, ardb@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/7] arm64: mm: Move reserve_crashkernel() into mem_init()
Date: Thu, 19 Nov 2020 17:25:24 +0000	[thread overview]
Message-ID: <20201119172523.GG4376@gaia> (raw)
In-Reply-To: <20201119171048.GD4376@gaia>

On Thu, Nov 19, 2020 at 05:10:49PM +0000, Catalin Marinas wrote:
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index ed71b1c305d7..acdec0c67d3b 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -469,6 +469,21 @@ void __init mark_linear_text_alias_ro(void)
>  			    PAGE_KERNEL_RO);
>  }
>  
> +static bool crash_mem_map __initdata;
> +
> +static int __init enable_crash_mem_map(char *arg)
> +{
> +	/*
> +	 * Proper parameter parsing is done by reserve_crashkernel(). We only
> +	 * need to know if the linear map has to avoid block mappings so that
> +	 * the crashkernel reservations can be unmapped later.
> +	 */
> +	crash_mem_map = false;

It should be set to true.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com,
	Chen Zhou <chenzhou10@huawei.com>,
	robin.murphy@arm.com, linux-kernel@vger.kernel.org,
	jeremy.linton@arm.com, ardb@kernel.org,
	iommu@lists.linux-foundation.org, robh+dt@kernel.org,
	James Morse <james.morse@arm.com>,
	linux-rpi-kernel@lists.infradead.org, guohanjun@huawei.com,
	will@kernel.org, hch@lst.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/7] arm64: mm: Move reserve_crashkernel() into mem_init()
Date: Thu, 19 Nov 2020 17:25:24 +0000	[thread overview]
Message-ID: <20201119172523.GG4376@gaia> (raw)
In-Reply-To: <20201119171048.GD4376@gaia>

On Thu, Nov 19, 2020 at 05:10:49PM +0000, Catalin Marinas wrote:
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index ed71b1c305d7..acdec0c67d3b 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -469,6 +469,21 @@ void __init mark_linear_text_alias_ro(void)
>  			    PAGE_KERNEL_RO);
>  }
>  
> +static bool crash_mem_map __initdata;
> +
> +static int __init enable_crash_mem_map(char *arg)
> +{
> +	/*
> +	 * Proper parameter parsing is done by reserve_crashkernel(). We only
> +	 * need to know if the linear map has to avoid block mappings so that
> +	 * the crashkernel reservations can be unmapped later.
> +	 */
> +	crash_mem_map = false;

It should be set to true.

-- 
Catalin

  reply	other threads:[~2020-11-19 17:25 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 17:31 [PATCH v6 0/7] arm64: Default to 32-bit wide ZONE_DMA Nicolas Saenz Julienne
2020-11-03 17:31 ` Nicolas Saenz Julienne
2020-11-03 17:31 ` Nicolas Saenz Julienne
2020-11-03 17:31 ` Nicolas Saenz Julienne
2020-11-03 17:31 ` [PATCH v6 1/7] arm64: mm: Move reserve_crashkernel() into mem_init() Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-05 16:11   ` James Morse
2020-11-05 16:11     ` James Morse
2020-11-05 16:11     ` James Morse
2020-11-06 18:46     ` Nicolas Saenz Julienne
2020-11-06 18:46       ` Nicolas Saenz Julienne
2020-11-06 18:46       ` Nicolas Saenz Julienne
2020-11-10 18:17       ` Catalin Marinas
2020-11-10 18:17         ` Catalin Marinas
2020-11-10 18:17         ` Catalin Marinas
2020-11-12 15:56         ` Nicolas Saenz Julienne
2020-11-12 15:56           ` Nicolas Saenz Julienne
2020-11-12 15:56           ` Nicolas Saenz Julienne
2020-11-13 11:29           ` Catalin Marinas
2020-11-13 11:29             ` Catalin Marinas
2020-11-13 11:29             ` Catalin Marinas
2020-11-19 14:09             ` Nicolas Saenz Julienne
2020-11-19 14:09               ` Nicolas Saenz Julienne
2020-11-19 14:09               ` Nicolas Saenz Julienne
2020-11-19 17:10               ` Catalin Marinas
2020-11-19 17:10                 ` Catalin Marinas
2020-11-19 17:10                 ` Catalin Marinas
2020-11-19 17:25                 ` Catalin Marinas [this message]
2020-11-19 17:25                   ` Catalin Marinas
2020-11-19 17:25                   ` Catalin Marinas
2020-11-19 17:25                 ` Nicolas Saenz Julienne
2020-11-19 17:25                   ` Nicolas Saenz Julienne
2020-11-19 17:25                   ` Nicolas Saenz Julienne
2020-11-19 17:45                   ` Catalin Marinas
2020-11-19 17:45                     ` Catalin Marinas
2020-11-19 17:45                     ` Catalin Marinas
2020-11-19 18:18       ` James Morse
2020-11-19 18:18         ` James Morse
2020-11-19 18:18         ` James Morse
2020-11-03 17:31 ` [PATCH v6 2/7] arm64: mm: Move zone_dma_bits initialization into zone_sizes_init() Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31 ` [PATCH v6 3/7] of/address: Introduce of_dma_get_max_cpu_address() Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31 ` [PATCH v6 4/7] of: unittest: Add test for of_dma_get_max_cpu_address() Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31 ` [PATCH v6 5/7] arm64: mm: Set ZONE_DMA size based on devicetree's dma-ranges Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31 ` [PATCH v6 6/7] arm64: mm: Set ZONE_DMA size based on early IORT scan Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31 ` [PATCH v6 7/7] mm: Remove examples from enum zone_type comment Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne
2020-11-03 17:31   ` Nicolas Saenz Julienne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119172523.GG4376@gaia \
    --to=catalin.marinas@arm.com \
    --cc=ardb@kernel.org \
    --cc=chenzhou10@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=guohanjun@huawei.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=james.morse@arm.com \
    --cc=jeremy.linton@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.