From: kernel test robot <lkp@intel.com>
To: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com
Cc: kbuild-all@lists.01.org, Sathya.Prakash@broadcom.com,
sreekanth.reddy@broadcom.com,
Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
Subject: Re: [PATCH 4/8] mpt3sas: Add Event triggers persistent Trigger Page2
Date: Tue, 24 Nov 2020 16:40:15 +0800 [thread overview]
Message-ID: <202011241606.eAWe7USW-lkp@intel.com> (raw)
In-Reply-To: <20201124035019.27975-5-suganath-prabu.subramani@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 4821 bytes --]
Hi Suganath,
I love your patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next v5.10-rc5 next-20201123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/0bded6ff43e4b0168fd607fed5169a35fa7edb4c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842
git checkout 0bded6ff43e4b0168fd607fed5169a35fa7edb4c
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/mpt3sas/mpt3sas_config.c:1793:1: warning: no previous prototype for '_config_set_driver_trigger_pg0' [-Wmissing-prototypes]
1793 | _config_set_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1835:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg0' [-Wmissing-prototypes]
1835 | mpt3sas_config_update_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1927:1: warning: no previous prototype for '_config_set_driver_trigger_pg1' [-Wmissing-prototypes]
1927 | _config_set_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1969:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg1' [-Wmissing-prototypes]
1969 | mpt3sas_config_update_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/scsi/mpt3sas/mpt3sas_config.c:2078:1: warning: no previous prototype for '_config_set_driver_trigger_pg2' [-Wmissing-prototypes]
2078 | _config_set_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2120:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg2' [-Wmissing-prototypes]
2120 | mpt3sas_config_update_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/_config_set_driver_trigger_pg2 +2078 drivers/scsi/mpt3sas/mpt3sas_config.c
2067
2068 /**
2069 * mpt3sas_config_set_driver_trigger_pg2 - write driver trigger page 2
2070 * @ioc: per adapter object
2071 * @mpi_reply: reply mf payload returned from firmware
2072 * @config_page: contents of the config page
2073 * Context: sleep.
2074 *
2075 * Returns 0 for success, non-zero for failure.
2076 */
2077 int
> 2078 _config_set_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
2079 Mpi2ConfigReply_t *mpi_reply, Mpi26DriverTriggerPage2_t *config_page)
2080 {
2081 Mpi2ConfigRequest_t mpi_request;
2082 int r;
2083
2084 memset(&mpi_request, 0, sizeof(Mpi2ConfigRequest_t));
2085 mpi_request.Function = MPI2_FUNCTION_CONFIG;
2086 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_HEADER;
2087 mpi_request.Header.PageType = MPI2_CONFIG_PAGETYPE_EXTENDED;
2088 mpi_request.ExtPageType =
2089 MPI2_CONFIG_EXTPAGETYPE_DRIVER_PERSISTENT_TRIGGER;
2090 mpi_request.Header.PageNumber = 2;
2091 mpi_request.Header.PageVersion = MPI26_DRIVER_TRIGGER_PAGE2_PAGEVERSION;
2092 ioc->build_zero_len_sge_mpi(ioc, &mpi_request.PageBufferSGE);
2093 r = _config_request(ioc, &mpi_request, mpi_reply,
2094 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, NULL, 0);
2095 if (r)
2096 goto out;
2097
2098 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_CURRENT;
2099 _config_request(ioc, &mpi_request, mpi_reply,
2100 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page,
2101 sizeof(*config_page));
2102 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_NVRAM;
2103 r = _config_request(ioc, &mpi_request, mpi_reply,
2104 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page,
2105 sizeof(*config_page));
2106 out:
2107 return r;
2108 }
2109
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 45542 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 4/8] mpt3sas: Add Event triggers persistent Trigger Page2
Date: Tue, 24 Nov 2020 16:40:15 +0800 [thread overview]
Message-ID: <202011241606.eAWe7USW-lkp@intel.com> (raw)
In-Reply-To: <20201124035019.27975-5-suganath-prabu.subramani@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 4918 bytes --]
Hi Suganath,
I love your patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next v5.10-rc5 next-20201123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/0bded6ff43e4b0168fd607fed5169a35fa7edb4c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842
git checkout 0bded6ff43e4b0168fd607fed5169a35fa7edb4c
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/mpt3sas/mpt3sas_config.c:1793:1: warning: no previous prototype for '_config_set_driver_trigger_pg0' [-Wmissing-prototypes]
1793 | _config_set_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1835:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg0' [-Wmissing-prototypes]
1835 | mpt3sas_config_update_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1927:1: warning: no previous prototype for '_config_set_driver_trigger_pg1' [-Wmissing-prototypes]
1927 | _config_set_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1969:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg1' [-Wmissing-prototypes]
1969 | mpt3sas_config_update_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/scsi/mpt3sas/mpt3sas_config.c:2078:1: warning: no previous prototype for '_config_set_driver_trigger_pg2' [-Wmissing-prototypes]
2078 | _config_set_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2120:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg2' [-Wmissing-prototypes]
2120 | mpt3sas_config_update_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/_config_set_driver_trigger_pg2 +2078 drivers/scsi/mpt3sas/mpt3sas_config.c
2067
2068 /**
2069 * mpt3sas_config_set_driver_trigger_pg2 - write driver trigger page 2
2070 * @ioc: per adapter object
2071 * @mpi_reply: reply mf payload returned from firmware
2072 * @config_page: contents of the config page
2073 * Context: sleep.
2074 *
2075 * Returns 0 for success, non-zero for failure.
2076 */
2077 int
> 2078 _config_set_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
2079 Mpi2ConfigReply_t *mpi_reply, Mpi26DriverTriggerPage2_t *config_page)
2080 {
2081 Mpi2ConfigRequest_t mpi_request;
2082 int r;
2083
2084 memset(&mpi_request, 0, sizeof(Mpi2ConfigRequest_t));
2085 mpi_request.Function = MPI2_FUNCTION_CONFIG;
2086 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_HEADER;
2087 mpi_request.Header.PageType = MPI2_CONFIG_PAGETYPE_EXTENDED;
2088 mpi_request.ExtPageType =
2089 MPI2_CONFIG_EXTPAGETYPE_DRIVER_PERSISTENT_TRIGGER;
2090 mpi_request.Header.PageNumber = 2;
2091 mpi_request.Header.PageVersion = MPI26_DRIVER_TRIGGER_PAGE2_PAGEVERSION;
2092 ioc->build_zero_len_sge_mpi(ioc, &mpi_request.PageBufferSGE);
2093 r = _config_request(ioc, &mpi_request, mpi_reply,
2094 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, NULL, 0);
2095 if (r)
2096 goto out;
2097
2098 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_CURRENT;
2099 _config_request(ioc, &mpi_request, mpi_reply,
2100 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page,
2101 sizeof(*config_page));
2102 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_NVRAM;
2103 r = _config_request(ioc, &mpi_request, mpi_reply,
2104 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page,
2105 sizeof(*config_page));
2106 out:
2107 return r;
2108 }
2109
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 45542 bytes --]
next prev parent reply other threads:[~2020-11-24 8:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 3:50 [PATCH 0/8] mpt3sas: Features to enhance driver debugging Suganath Prabu S
2020-11-24 3:50 ` [PATCH 1/8] mpt3sas: Sync time stamp periodically between Driver and FW Suganath Prabu S
2020-11-24 7:46 ` kernel test robot
2020-11-24 7:46 ` kernel test robot
2020-11-24 3:50 ` [PATCH 2/8] mpt3sas: Add persistent trigger pages support Suganath Prabu S
2020-11-24 6:34 ` kernel test robot
2020-11-24 6:34 ` kernel test robot
2020-11-24 8:41 ` kernel test robot
2020-11-24 8:41 ` kernel test robot
2020-11-24 8:41 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg0 can be static kernel test robot
2020-11-24 8:41 ` kernel test robot
2020-11-24 3:50 ` [PATCH 3/8] mpt3sas: Add master triggers persistent Trigger Page Suganath Prabu S
2020-11-24 7:48 ` kernel test robot
2020-11-24 7:48 ` kernel test robot
2020-11-24 9:25 ` kernel test robot
2020-11-24 9:25 ` kernel test robot
2020-11-24 9:25 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg1 can be static kernel test robot
2020-11-24 9:25 ` kernel test robot
2020-11-24 3:50 ` [PATCH 4/8] mpt3sas: Add Event triggers persistent Trigger Page2 Suganath Prabu S
2020-11-24 8:40 ` kernel test robot [this message]
2020-11-24 8:40 ` kernel test robot
2020-11-24 10:24 ` kernel test robot
2020-11-24 10:24 ` kernel test robot
2020-11-24 10:24 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg2 can be static kernel test robot
2020-11-24 10:24 ` kernel test robot
2020-11-24 3:50 ` [PATCH 5/8] mpt3sas: Add SCSI sense triggers persistent Trigger Page3 Suganath Prabu S
2020-11-24 9:52 ` kernel test robot
2020-11-24 9:52 ` kernel test robot
2020-11-24 11:09 ` kernel test robot
2020-11-24 11:09 ` kernel test robot
2020-11-24 11:09 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg3 can be static kernel test robot
2020-11-24 11:09 ` kernel test robot
2020-11-24 3:50 ` [PATCH 6/8] mpt3sas: Add MPI triggers persistent Trigger Page4 Suganath Prabu S
2020-11-24 11:03 ` kernel test robot
2020-11-24 11:03 ` kernel test robot
2020-11-24 12:05 ` kernel test robot
2020-11-24 12:05 ` kernel test robot
2020-11-24 12:05 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg4 can be static kernel test robot
2020-11-24 12:05 ` kernel test robot
2020-11-24 3:50 ` [PATCH 7/8] mpt3sas: Handle trigger page support after reset Suganath Prabu S
2020-11-24 3:50 ` [PATCH 8/8] mpt3sas: Update driver version to 36.100.00.00 Suganath Prabu S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011241606.eAWe7USW-lkp@intel.com \
--to=lkp@intel.com \
--cc=Sathya.Prakash@broadcom.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.