From: kernel test robot <lkp@intel.com>
To: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com
Cc: kbuild-all@lists.01.org, Sathya.Prakash@broadcom.com,
sreekanth.reddy@broadcom.com,
Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
Subject: Re: [PATCH 6/8] mpt3sas: Add MPI triggers persistent Trigger Page4
Date: Tue, 24 Nov 2020 19:03:58 +0800 [thread overview]
Message-ID: <202011241820.nY2Rltob-lkp@intel.com> (raw)
In-Reply-To: <20201124035019.27975-7-suganath-prabu.subramani@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 5893 bytes --]
Hi Suganath,
I love your patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next v5.10-rc5 next-20201123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d13faa942966ed911558ffa9c1fb021847f72632
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842
git checkout d13faa942966ed911558ffa9c1fb021847f72632
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/mpt3sas/mpt3sas_config.c:1793:1: warning: no previous prototype for '_config_set_driver_trigger_pg0' [-Wmissing-prototypes]
1793 | _config_set_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1835:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg0' [-Wmissing-prototypes]
1835 | mpt3sas_config_update_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1927:1: warning: no previous prototype for '_config_set_driver_trigger_pg1' [-Wmissing-prototypes]
1927 | _config_set_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1969:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg1' [-Wmissing-prototypes]
1969 | mpt3sas_config_update_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2078:1: warning: no previous prototype for '_config_set_driver_trigger_pg2' [-Wmissing-prototypes]
2078 | _config_set_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2120:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg2' [-Wmissing-prototypes]
2120 | mpt3sas_config_update_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2238:1: warning: no previous prototype for '_config_set_driver_trigger_pg3' [-Wmissing-prototypes]
2238 | _config_set_driver_trigger_pg3(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2280:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg3' [-Wmissing-prototypes]
2280 | mpt3sas_config_update_driver_trigger_pg3(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/scsi/mpt3sas/mpt3sas_config.c:2395:1: warning: no previous prototype for '_config_set_driver_trigger_pg4' [-Wmissing-prototypes]
2395 | _config_set_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2437:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg4' [-Wmissing-prototypes]
2437 | mpt3sas_config_update_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/_config_set_driver_trigger_pg4 +2395 drivers/scsi/mpt3sas/mpt3sas_config.c
2384
2385 /**
2386 * mpt3sas_config_set_driver_trigger_pg4 - write driver trigger page 4
2387 * @ioc: per adapter object
2388 * @mpi_reply: reply mf payload returned from firmware
2389 * @config_page: contents of the config page
2390 * Context: sleep.
2391 *
2392 * Returns 0 for success, non-zero for failure.
2393 */
2394 int
> 2395 _config_set_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc,
2396 Mpi2ConfigReply_t *mpi_reply, Mpi26DriverTriggerPage4_t *config_page)
2397 {
2398 Mpi2ConfigRequest_t mpi_request;
2399 int r;
2400
2401 memset(&mpi_request, 0, sizeof(Mpi2ConfigRequest_t));
2402 mpi_request.Function = MPI2_FUNCTION_CONFIG;
2403 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_HEADER;
2404 mpi_request.Header.PageType = MPI2_CONFIG_PAGETYPE_EXTENDED;
2405 mpi_request.ExtPageType =
2406 MPI2_CONFIG_EXTPAGETYPE_DRIVER_PERSISTENT_TRIGGER;
2407 mpi_request.Header.PageNumber = 4;
2408 mpi_request.Header.PageVersion = MPI26_DRIVER_TRIGGER_PAGE4_PAGEVERSION;
2409 ioc->build_zero_len_sge_mpi(ioc, &mpi_request.PageBufferSGE);
2410 r = _config_request(ioc, &mpi_request, mpi_reply,
2411 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, NULL, 0);
2412 if (r)
2413 goto out;
2414
2415 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_CURRENT;
2416 _config_request(ioc, &mpi_request, mpi_reply,
2417 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page,
2418 sizeof(*config_page));
2419 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_NVRAM;
2420 r = _config_request(ioc, &mpi_request, mpi_reply,
2421 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page,
2422 sizeof(*config_page));
2423 out:
2424 return r;
2425 }
2426
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 45542 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 6/8] mpt3sas: Add MPI triggers persistent Trigger Page4
Date: Tue, 24 Nov 2020 19:03:58 +0800 [thread overview]
Message-ID: <202011241820.nY2Rltob-lkp@intel.com> (raw)
In-Reply-To: <20201124035019.27975-7-suganath-prabu.subramani@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 6002 bytes --]
Hi Suganath,
I love your patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next v5.10-rc5 next-20201123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d13faa942966ed911558ffa9c1fb021847f72632
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842
git checkout d13faa942966ed911558ffa9c1fb021847f72632
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/mpt3sas/mpt3sas_config.c:1793:1: warning: no previous prototype for '_config_set_driver_trigger_pg0' [-Wmissing-prototypes]
1793 | _config_set_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1835:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg0' [-Wmissing-prototypes]
1835 | mpt3sas_config_update_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1927:1: warning: no previous prototype for '_config_set_driver_trigger_pg1' [-Wmissing-prototypes]
1927 | _config_set_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:1969:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg1' [-Wmissing-prototypes]
1969 | mpt3sas_config_update_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2078:1: warning: no previous prototype for '_config_set_driver_trigger_pg2' [-Wmissing-prototypes]
2078 | _config_set_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2120:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg2' [-Wmissing-prototypes]
2120 | mpt3sas_config_update_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2238:1: warning: no previous prototype for '_config_set_driver_trigger_pg3' [-Wmissing-prototypes]
2238 | _config_set_driver_trigger_pg3(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2280:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg3' [-Wmissing-prototypes]
2280 | mpt3sas_config_update_driver_trigger_pg3(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/scsi/mpt3sas/mpt3sas_config.c:2395:1: warning: no previous prototype for '_config_set_driver_trigger_pg4' [-Wmissing-prototypes]
2395 | _config_set_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/mpt3sas/mpt3sas_config.c:2437:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg4' [-Wmissing-prototypes]
2437 | mpt3sas_config_update_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/_config_set_driver_trigger_pg4 +2395 drivers/scsi/mpt3sas/mpt3sas_config.c
2384
2385 /**
2386 * mpt3sas_config_set_driver_trigger_pg4 - write driver trigger page 4
2387 * @ioc: per adapter object
2388 * @mpi_reply: reply mf payload returned from firmware
2389 * @config_page: contents of the config page
2390 * Context: sleep.
2391 *
2392 * Returns 0 for success, non-zero for failure.
2393 */
2394 int
> 2395 _config_set_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc,
2396 Mpi2ConfigReply_t *mpi_reply, Mpi26DriverTriggerPage4_t *config_page)
2397 {
2398 Mpi2ConfigRequest_t mpi_request;
2399 int r;
2400
2401 memset(&mpi_request, 0, sizeof(Mpi2ConfigRequest_t));
2402 mpi_request.Function = MPI2_FUNCTION_CONFIG;
2403 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_HEADER;
2404 mpi_request.Header.PageType = MPI2_CONFIG_PAGETYPE_EXTENDED;
2405 mpi_request.ExtPageType =
2406 MPI2_CONFIG_EXTPAGETYPE_DRIVER_PERSISTENT_TRIGGER;
2407 mpi_request.Header.PageNumber = 4;
2408 mpi_request.Header.PageVersion = MPI26_DRIVER_TRIGGER_PAGE4_PAGEVERSION;
2409 ioc->build_zero_len_sge_mpi(ioc, &mpi_request.PageBufferSGE);
2410 r = _config_request(ioc, &mpi_request, mpi_reply,
2411 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, NULL, 0);
2412 if (r)
2413 goto out;
2414
2415 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_CURRENT;
2416 _config_request(ioc, &mpi_request, mpi_reply,
2417 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page,
2418 sizeof(*config_page));
2419 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_NVRAM;
2420 r = _config_request(ioc, &mpi_request, mpi_reply,
2421 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page,
2422 sizeof(*config_page));
2423 out:
2424 return r;
2425 }
2426
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 45542 bytes --]
next prev parent reply other threads:[~2020-11-24 11:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 3:50 [PATCH 0/8] mpt3sas: Features to enhance driver debugging Suganath Prabu S
2020-11-24 3:50 ` [PATCH 1/8] mpt3sas: Sync time stamp periodically between Driver and FW Suganath Prabu S
2020-11-24 7:46 ` kernel test robot
2020-11-24 7:46 ` kernel test robot
2020-11-24 3:50 ` [PATCH 2/8] mpt3sas: Add persistent trigger pages support Suganath Prabu S
2020-11-24 6:34 ` kernel test robot
2020-11-24 6:34 ` kernel test robot
2020-11-24 8:41 ` kernel test robot
2020-11-24 8:41 ` kernel test robot
2020-11-24 8:41 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg0 can be static kernel test robot
2020-11-24 8:41 ` kernel test robot
2020-11-24 3:50 ` [PATCH 3/8] mpt3sas: Add master triggers persistent Trigger Page Suganath Prabu S
2020-11-24 7:48 ` kernel test robot
2020-11-24 7:48 ` kernel test robot
2020-11-24 9:25 ` kernel test robot
2020-11-24 9:25 ` kernel test robot
2020-11-24 9:25 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg1 can be static kernel test robot
2020-11-24 9:25 ` kernel test robot
2020-11-24 3:50 ` [PATCH 4/8] mpt3sas: Add Event triggers persistent Trigger Page2 Suganath Prabu S
2020-11-24 8:40 ` kernel test robot
2020-11-24 8:40 ` kernel test robot
2020-11-24 10:24 ` kernel test robot
2020-11-24 10:24 ` kernel test robot
2020-11-24 10:24 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg2 can be static kernel test robot
2020-11-24 10:24 ` kernel test robot
2020-11-24 3:50 ` [PATCH 5/8] mpt3sas: Add SCSI sense triggers persistent Trigger Page3 Suganath Prabu S
2020-11-24 9:52 ` kernel test robot
2020-11-24 9:52 ` kernel test robot
2020-11-24 11:09 ` kernel test robot
2020-11-24 11:09 ` kernel test robot
2020-11-24 11:09 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg3 can be static kernel test robot
2020-11-24 11:09 ` kernel test robot
2020-11-24 3:50 ` [PATCH 6/8] mpt3sas: Add MPI triggers persistent Trigger Page4 Suganath Prabu S
2020-11-24 11:03 ` kernel test robot [this message]
2020-11-24 11:03 ` kernel test robot
2020-11-24 12:05 ` kernel test robot
2020-11-24 12:05 ` kernel test robot
2020-11-24 12:05 ` [RFC PATCH] mpt3sas: _config_set_driver_trigger_pg4 can be static kernel test robot
2020-11-24 12:05 ` kernel test robot
2020-11-24 3:50 ` [PATCH 7/8] mpt3sas: Handle trigger page support after reset Suganath Prabu S
2020-11-24 3:50 ` [PATCH 8/8] mpt3sas: Update driver version to 36.100.00.00 Suganath Prabu S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011241820.nY2Rltob-lkp@intel.com \
--to=lkp@intel.com \
--cc=Sathya.Prakash@broadcom.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.