From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Uma Shankar <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [v2 2/2] Revert "drm/i915/display/fbc: Disable fbc by default on TGL"
Date: Wed, 25 Nov 2020 18:18:54 +0200 [thread overview]
Message-ID: <20201125161854.GO6112@intel.com> (raw)
In-Reply-To: <20201119155050.20328-3-uma.shankar@intel.com>
On Thu, Nov 19, 2020 at 09:20:50PM +0530, Uma Shankar wrote:
> FBC can be re-enabled on TGL with WA of keeping it disabled
> while PSR2 is enabled.
>
> This reverts commit 2982ded2ff5ce0cf1a49bc39a526da182782b664.
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Sorry, forgot to review this one.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbc.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index c64ed1cd29b1..7a5783564a0f 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1444,13 +1444,6 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
> if (!HAS_FBC(dev_priv))
> return 0;
>
> - /*
> - * Fbc is causing random underruns in CI execution on TGL platforms.
> - * Disabling the same while the problem is being debugged and analyzed.
> - */
> - if (IS_TIGERLAKE(dev_priv))
> - return 0;
> -
> if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9)
> return 1;
>
> --
> 2.26.2
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-11-25 16:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 15:50 [Intel-gfx] [v2 0/2] Re-enable FBC on TGL Uma Shankar
2020-11-19 15:50 ` [Intel-gfx] [v2 1/2] drm/i915/display/tgl: Disable FBC with PSR2 Uma Shankar
2020-11-19 15:42 ` Ville Syrjälä
2020-11-19 18:54 ` Shankar, Uma
2020-11-19 19:36 ` [Intel-gfx] [v3 " Uma Shankar
2020-11-24 16:19 ` Ville Syrjälä
2020-11-24 22:03 ` Souza, Jose
2020-11-25 16:17 ` Ville Syrjälä
2020-11-25 17:52 ` Souza, Jose
2020-11-27 14:45 ` Ville Syrjälä
2020-12-01 13:56 ` Shankar, Uma
2020-11-19 15:50 ` [Intel-gfx] [v2 2/2] Revert "drm/i915/display/fbc: Disable fbc by default on TGL" Uma Shankar
2020-11-25 16:18 ` Ville Syrjälä [this message]
2020-11-19 17:56 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Re-enable FBC on TGL (rev2) Patchwork
2020-11-19 23:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Re-enable FBC on TGL (rev3) Patchwork
2020-11-20 6:13 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125161854.GO6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.