From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
aford@beaconembedded.com, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8mm-beacon-som: Fix PMIC clock error
Date: Thu, 26 Nov 2020 09:07:08 +0100 [thread overview]
Message-ID: <20201126080708.GB4347@kozik-lap> (raw)
In-Reply-To: <20201125210339.1071419-2-aford173@gmail.com>
On Wed, Nov 25, 2020 at 03:03:39PM -0600, Adam Ford wrote:
> The PMIC throws an errors because the clock isn't assigned to it.
> Fix this by assigning the clocks info.
>
> Fixes: acb01032e11a ("arm64: defconfig: Enable clock driver for ROHM BD718x7 PMIC")
Hi,
This is not the correct Fixes tag. The defconfig change did not
introduce any bug in DTS. The error message was there before, regardless
of defconfigs. Defconfigs are merely a development or distro aid, not a
definition of working state.
If it really was a bug, then the commit adding DTS is to blame.
Second, I am not sure if there is a bug here to fix - having incomplete
DTS is a bug? Missing device nodes in DTS is a bug?
Also, pay attention to proper white spaces. There is only single
whitespace after ':' and no blank line after entire Fixes tag.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8mm-beacon-som: Fix PMIC clock error
Date: Thu, 26 Nov 2020 09:07:08 +0100 [thread overview]
Message-ID: <20201126080708.GB4347@kozik-lap> (raw)
In-Reply-To: <20201125210339.1071419-2-aford173@gmail.com>
On Wed, Nov 25, 2020 at 03:03:39PM -0600, Adam Ford wrote:
> The PMIC throws an errors because the clock isn't assigned to it.
> Fix this by assigning the clocks info.
>
> Fixes: acb01032e11a ("arm64: defconfig: Enable clock driver for ROHM BD718x7 PMIC")
Hi,
This is not the correct Fixes tag. The defconfig change did not
introduce any bug in DTS. The error message was there before, regardless
of defconfigs. Defconfigs are merely a development or distro aid, not a
definition of working state.
If it really was a bug, then the commit adding DTS is to blame.
Second, I am not sure if there is a bug here to fix - having incomplete
DTS is a bug? Missing device nodes in DTS is a bug?
Also, pay attention to proper white spaces. There is only single
whitespace after ':' and no blank line after entire Fixes tag.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-11-26 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 21:03 [PATCH 1/2] arm64: dts: imx8mm-beacon-som: Fix RTC aliases Adam Ford
2020-11-25 21:03 ` Adam Ford
2020-11-25 21:03 ` [PATCH 2/2] arm64: dts: imx8mm-beacon-som: Fix PMIC clock error Adam Ford
2020-11-25 21:03 ` Adam Ford
2020-11-26 8:07 ` Krzysztof Kozlowski [this message]
2020-11-26 8:07 ` Krzysztof Kozlowski
2020-11-26 8:03 ` [PATCH 1/2] arm64: dts: imx8mm-beacon-som: Fix RTC aliases Krzysztof Kozlowski
2020-11-26 8:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126080708.GB4347@kozik-lap \
--to=krzk@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.