[xlnx:xlnx_rebase_v5.4 1296/1696] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:214 axienet_dma_bd_init() error: uninitialized symbol 'ret'.

[Dan Carpenter <dan.carpenter@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]

Hi Vishal,

First bad commit (maybe != root cause):

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head:   61e889430e4c71c59bc43d5b4a23ef1f5845cd70
commit: 0b197959bbbdb68e1da974bd013339f08704b178 [1296/1696] staging: xlnxsync: Fix the uapi header license
config: x86_64-randconfig-m031-20201204 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1534 axienet_mii_init() warn: inconsistent returns 'lp->mii_bus->mdio_lock'.

vim +/ret +214 drivers/net/ethernet/xilinx/xilinx_axienet_main.c
  1688  static int axienet_mii_init(struct net_device *ndev)
  1689  {
  1690          struct axienet_local *lp = netdev_priv(ndev);
  1691          int ret;
  1692  
  1693          /* Disable the MDIO interface till Axi Ethernet Reset is completed.
  1694           * When we do an Axi Ethernet reset, it resets the complete core
  1695           * including the MDIO. MDIO must be disabled before resetting
  1696           * and re-enabled afterwards.
  1697           * Hold MDIO bus lock to avoid MDIO accesses during the reset.
  1698           */
  1699  
  1700          mutex_lock(&lp->mii_bus->mdio_lock);
  1701          ret = axienet_mdio_wait_until_ready(lp);
  1702          if (ret < 0)
  1703                  return ret;
                        ^^^^^^^^^^^
Unlock before returning.

  1704          axienet_mdio_disable(lp);
  1705          axienet_device_reset(ndev);
  1706          ret = axienet_mdio_enable(lp);
  1707          ret = axienet_mdio_wait_until_ready(lp);
  1708          mutex_unlock(&lp->mii_bus->mdio_lock);
  1709          if (ret < 0)
  1710                  return ret;
  1711  
  1712          return 0;
  1713  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35478 bytes --]