* [xlnx:xlnx_rebase_v5.4 1296/1696] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:214 axienet_dma_bd_init() error: uninitialized symbol 'ret'.
@ 2020-12-05 15:29 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2020-12-05 15:29 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5371 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Vishal Sagar <vishal.sagar@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
Hi Vishal,
First bad commit (maybe != root cause):
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head: 61e889430e4c71c59bc43d5b4a23ef1f5845cd70
commit: 0b197959bbbdb68e1da974bd013339f08704b178 [1296/1696] staging: xlnxsync: Fix the uapi header license
:::::: branch date: 2 days ago
:::::: commit date: 7 months ago
config: x86_64-randconfig-m031-20201204 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:214 axienet_dma_bd_init() error: uninitialized symbol 'ret'.
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1534 axienet_mii_init() warn: inconsistent returns 'lp->mii_bus->mdio_lock'.
drivers/usb/storage/uas.c:537 uas_workaround() warn: possible memory leak of 'temp_request'
Old smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1608 axienet_open() warn: inconsistent indenting
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1610 axienet_open() warn: inconsistent indenting
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1832 axienet_stop() warn: inconsistent indenting
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1839 axienet_stop() warn: inconsistent indenting
vim +/ret +214 drivers/net/ethernet/xilinx/xilinx_axienet_main.c
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 179
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 180 /**
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 181 * axienet_dma_bd_init - Setup buffer descriptor rings for Axi DMA
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 182 * @ndev: Pointer to the net_device structure
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 183 *
b0d081c524b46c2 Michal Simek 2015-05-05 184 * Return: 0, on success -ENOMEM, on failure
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 185 *
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 186 * This function is called to initialize the Rx and Tx DMA descriptor
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 187 * rings. This initializes the descriptors with required default values
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 188 * and is called when Axi Ethernet driver reset is called.
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 189 */
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 190 static int axienet_dma_bd_init(struct net_device *ndev)
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 191 {
51054464602520b Saurabh Sengar 2020-01-24 192 int i, ret;
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 193 struct axienet_local *lp = netdev_priv(ndev);
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 194
51054464602520b Saurabh Sengar 2020-01-24 195 #ifdef CONFIG_AXIENET_HAS_MCDMA
51054464602520b Saurabh Sengar 2020-01-24 196 for_each_tx_dma_queue(lp, i) {
51054464602520b Saurabh Sengar 2020-01-24 197 ret = axienet_mcdma_tx_q_init(ndev, lp->dq[i]);
51054464602520b Saurabh Sengar 2020-01-24 198 if (ret != 0)
51054464602520b Saurabh Sengar 2020-01-24 199 break;
51054464602520b Saurabh Sengar 2020-01-24 200 }
51054464602520b Saurabh Sengar 2020-01-24 201 #endif
51054464602520b Saurabh Sengar 2020-01-24 202 for_each_rx_dma_queue(lp, i) {
51054464602520b Saurabh Sengar 2020-01-24 203 #ifdef CONFIG_AXIENET_HAS_MCDMA
51054464602520b Saurabh Sengar 2020-01-24 204 ret = axienet_mcdma_rx_q_init(ndev, lp->dq[i]);
51054464602520b Saurabh Sengar 2020-01-24 205 #else
51054464602520b Saurabh Sengar 2020-01-24 206 ret = axienet_dma_q_init(ndev, lp->dq[i]);
51054464602520b Saurabh Sengar 2020-01-24 207 #endif
51054464602520b Saurabh Sengar 2020-01-24 208 if (ret != 0) {
51054464602520b Saurabh Sengar 2020-01-24 209 netdev_err(ndev, "%s: Failed to init DMA buf\n", __func__);
51054464602520b Saurabh Sengar 2020-01-24 210 break;
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 211 }
8daf52f28b3fa37 Appana Durga Kedareswara Rao 2020-01-24 212 }
8daf52f28b3fa37 Appana Durga Kedareswara Rao 2020-01-24 213
51054464602520b Saurabh Sengar 2020-01-24 @214 return ret;
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 215 }
8a3b7a252dca9fb Daniel Borkmann 2012-01-19 216
:::::: The code at line 214 was first introduced by commit
:::::: 51054464602520b2dbb7288048a68732956cc5f4 net: axienet: added multichannel DMA support
:::::: TO: Saurabh Sengar <saurabh.singh@xilinx.com>
:::::: CC: Michal Simek <michal.simek@xilinx.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35478 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [xlnx:xlnx_rebase_v5.4 1296/1696] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:214 axienet_dma_bd_init() error: uninitialized symbol 'ret'.
@ 2020-12-07 10:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-12-07 10:01 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]
Hi Vishal,
First bad commit (maybe != root cause):
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head: 61e889430e4c71c59bc43d5b4a23ef1f5845cd70
commit: 0b197959bbbdb68e1da974bd013339f08704b178 [1296/1696] staging: xlnxsync: Fix the uapi header license
config: x86_64-randconfig-m031-20201204 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1534 axienet_mii_init() warn: inconsistent returns 'lp->mii_bus->mdio_lock'.
vim +/ret +214 drivers/net/ethernet/xilinx/xilinx_axienet_main.c
1688 static int axienet_mii_init(struct net_device *ndev)
1689 {
1690 struct axienet_local *lp = netdev_priv(ndev);
1691 int ret;
1692
1693 /* Disable the MDIO interface till Axi Ethernet Reset is completed.
1694 * When we do an Axi Ethernet reset, it resets the complete core
1695 * including the MDIO. MDIO must be disabled before resetting
1696 * and re-enabled afterwards.
1697 * Hold MDIO bus lock to avoid MDIO accesses during the reset.
1698 */
1699
1700 mutex_lock(&lp->mii_bus->mdio_lock);
1701 ret = axienet_mdio_wait_until_ready(lp);
1702 if (ret < 0)
1703 return ret;
^^^^^^^^^^^
Unlock before returning.
1704 axienet_mdio_disable(lp);
1705 axienet_device_reset(ndev);
1706 ret = axienet_mdio_enable(lp);
1707 ret = axienet_mdio_wait_until_ready(lp);
1708 mutex_unlock(&lp->mii_bus->mdio_lock);
1709 if (ret < 0)
1710 return ret;
1711
1712 return 0;
1713 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35478 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [xlnx:xlnx_rebase_v5.4 1296/1696] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:214 axienet_dma_bd_init() error: uninitialized symbol 'ret'.
@ 2020-12-07 10:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-12-07 10:01 UTC (permalink / raw)
To: kbuild, Vishal Sagar
Cc: Michal Simek, Hyun Kwon, kbuild-all, lkp, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 2023 bytes --]
Hi Vishal,
First bad commit (maybe != root cause):
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head: 61e889430e4c71c59bc43d5b4a23ef1f5845cd70
commit: 0b197959bbbdb68e1da974bd013339f08704b178 [1296/1696] staging: xlnxsync: Fix the uapi header license
config: x86_64-randconfig-m031-20201204 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1534 axienet_mii_init() warn: inconsistent returns 'lp->mii_bus->mdio_lock'.
vim +/ret +214 drivers/net/ethernet/xilinx/xilinx_axienet_main.c
1688 static int axienet_mii_init(struct net_device *ndev)
1689 {
1690 struct axienet_local *lp = netdev_priv(ndev);
1691 int ret;
1692
1693 /* Disable the MDIO interface till Axi Ethernet Reset is completed.
1694 * When we do an Axi Ethernet reset, it resets the complete core
1695 * including the MDIO. MDIO must be disabled before resetting
1696 * and re-enabled afterwards.
1697 * Hold MDIO bus lock to avoid MDIO accesses during the reset.
1698 */
1699
1700 mutex_lock(&lp->mii_bus->mdio_lock);
1701 ret = axienet_mdio_wait_until_ready(lp);
1702 if (ret < 0)
1703 return ret;
^^^^^^^^^^^
Unlock before returning.
1704 axienet_mdio_disable(lp);
1705 axienet_device_reset(ndev);
1706 ret = axienet_mdio_enable(lp);
1707 ret = axienet_mdio_wait_until_ready(lp);
1708 mutex_unlock(&lp->mii_bus->mdio_lock);
1709 if (ret < 0)
1710 return ret;
1711
1712 return 0;
1713 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35478 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [xlnx:xlnx_rebase_v5.4 1296/1696] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:214 axienet_dma_bd_init() error: uninitialized symbol 'ret'.
@ 2020-12-07 10:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-12-07 10:01 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]
Hi Vishal,
First bad commit (maybe != root cause):
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head: 61e889430e4c71c59bc43d5b4a23ef1f5845cd70
commit: 0b197959bbbdb68e1da974bd013339f08704b178 [1296/1696] staging: xlnxsync: Fix the uapi header license
config: x86_64-randconfig-m031-20201204 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1534 axienet_mii_init() warn: inconsistent returns 'lp->mii_bus->mdio_lock'.
vim +/ret +214 drivers/net/ethernet/xilinx/xilinx_axienet_main.c
1688 static int axienet_mii_init(struct net_device *ndev)
1689 {
1690 struct axienet_local *lp = netdev_priv(ndev);
1691 int ret;
1692
1693 /* Disable the MDIO interface till Axi Ethernet Reset is completed.
1694 * When we do an Axi Ethernet reset, it resets the complete core
1695 * including the MDIO. MDIO must be disabled before resetting
1696 * and re-enabled afterwards.
1697 * Hold MDIO bus lock to avoid MDIO accesses during the reset.
1698 */
1699
1700 mutex_lock(&lp->mii_bus->mdio_lock);
1701 ret = axienet_mdio_wait_until_ready(lp);
1702 if (ret < 0)
1703 return ret;
^^^^^^^^^^^
Unlock before returning.
1704 axienet_mdio_disable(lp);
1705 axienet_device_reset(ndev);
1706 ret = axienet_mdio_enable(lp);
1707 ret = axienet_mdio_wait_until_ready(lp);
1708 mutex_unlock(&lp->mii_bus->mdio_lock);
1709 if (ret < 0)
1710 return ret;
1711
1712 return 0;
1713 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35478 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-07 10:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-07 10:01 [xlnx:xlnx_rebase_v5.4 1296/1696] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:214 axienet_dma_bd_init() error: uninitialized symbol 'ret' Dan Carpenter
2020-12-07 10:01 ` Dan Carpenter
2020-12-07 10:01 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-12-05 15:29 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.