* [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add()
@ 2020-12-11 10:05 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2020-12-11 10:05 UTC (permalink / raw)
To: Thierry Reding, Neil Armstrong
Cc: David Airlie, kernel-janitors, Sam Ravnborg, dri-devel
There is a copy and paste bug so it didn't return the correct error
code.
Fixes: b215212117f7 ("drm: panel: add Khadas TS050 panel driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/panel/panel-khadas-ts050.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c
index 87aa2cc8ec2a..8f6ac1a40c31 100644
--- a/drivers/gpu/drm/panel/panel-khadas-ts050.c
+++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c
@@ -786,7 +786,7 @@ static int khadas_ts050_panel_add(struct khadas_ts050_panel *khadas_ts050)
khadas_ts050->enable_gpio = devm_gpiod_get(dev, "enable",
GPIOD_OUT_HIGH);
if (IS_ERR(khadas_ts050->enable_gpio))
- return dev_err_probe(dev, PTR_ERR(khadas_ts050->reset_gpio),
+ return dev_err_probe(dev, PTR_ERR(khadas_ts050->enable_gpio),
"failed to get enable gpio");
drm_panel_init(&khadas_ts050->base, &khadas_ts050->link->dev,
--
2.29.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add()
@ 2020-12-11 10:05 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2020-12-11 10:05 UTC (permalink / raw)
To: Thierry Reding, Neil Armstrong
Cc: David Airlie, kernel-janitors, Sam Ravnborg, dri-devel
There is a copy and paste bug so it didn't return the correct error
code.
Fixes: b215212117f7 ("drm: panel: add Khadas TS050 panel driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/panel/panel-khadas-ts050.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c
index 87aa2cc8ec2a..8f6ac1a40c31 100644
--- a/drivers/gpu/drm/panel/panel-khadas-ts050.c
+++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c
@@ -786,7 +786,7 @@ static int khadas_ts050_panel_add(struct khadas_ts050_panel *khadas_ts050)
khadas_ts050->enable_gpio = devm_gpiod_get(dev, "enable",
GPIOD_OUT_HIGH);
if (IS_ERR(khadas_ts050->enable_gpio))
- return dev_err_probe(dev, PTR_ERR(khadas_ts050->reset_gpio),
+ return dev_err_probe(dev, PTR_ERR(khadas_ts050->enable_gpio),
"failed to get enable gpio");
drm_panel_init(&khadas_ts050->base, &khadas_ts050->link->dev,
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add()
2020-12-11 10:05 ` Dan Carpenter
@ 2020-12-11 11:01 ` Sam Ravnborg
-1 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2020-12-11 11:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: Neil Armstrong, David Airlie, kernel-janitors, dri-devel,
Thierry Reding
Hi Dan,
I assume your nice tooling found this buggy.
Nice!
On Fri, Dec 11, 2020 at 01:05:50PM +0300, Dan Carpenter wrote:
> There is a copy and paste bug so it didn't return the correct error
> code.
>
> Fixes: b215212117f7 ("drm: panel: add Khadas TS050 panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Neil, I assume you will take this via next-fixes, which I think is the
right tree at the moment.
Sam
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add()
@ 2020-12-11 11:01 ` Sam Ravnborg
0 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2020-12-11 11:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: Neil Armstrong, David Airlie, kernel-janitors, dri-devel,
Thierry Reding
Hi Dan,
I assume your nice tooling found this buggy.
Nice!
On Fri, Dec 11, 2020 at 01:05:50PM +0300, Dan Carpenter wrote:
> There is a copy and paste bug so it didn't return the correct error
> code.
>
> Fixes: b215212117f7 ("drm: panel: add Khadas TS050 panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Neil, I assume you will take this via next-fixes, which I think is the
right tree at the moment.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add()
2020-12-11 11:01 ` Sam Ravnborg
@ 2020-12-11 14:04 ` Dan Carpenter
-1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2020-12-11 14:04 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Neil Armstrong, David Airlie, kernel-janitors, dri-devel,
Thierry Reding
On Fri, Dec 11, 2020 at 12:01:57PM +0100, Sam Ravnborg wrote:
> Hi Dan,
>
> I assume your nice tooling found this buggy.
Yeah. Passing a valid pointer to PTR_ERR().
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add()
@ 2020-12-11 14:04 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2020-12-11 14:04 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Neil Armstrong, David Airlie, kernel-janitors, dri-devel,
Thierry Reding
On Fri, Dec 11, 2020 at 12:01:57PM +0100, Sam Ravnborg wrote:
> Hi Dan,
>
> I assume your nice tooling found this buggy.
Yeah. Passing a valid pointer to PTR_ERR().
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add()
2020-12-11 11:01 ` Sam Ravnborg
@ 2020-12-11 16:01 ` Neil Armstrong
-1 siblings, 0 replies; 8+ messages in thread
From: Neil Armstrong @ 2020-12-11 16:01 UTC (permalink / raw)
To: Sam Ravnborg, Dan Carpenter
Cc: David Airlie, Thierry Reding, kernel-janitors, dri-devel
Hi All,
On 11/12/2020 12:01, Sam Ravnborg wrote:
> Hi Dan,
>
> I assume your nice tooling found this buggy.
> Nice!
>
> On Fri, Dec 11, 2020 at 01:05:50PM +0300, Dan Carpenter wrote:
>> There is a copy and paste bug so it didn't return the correct error
>> code.
>>
>> Fixes: b215212117f7 ("drm: panel: add Khadas TS050 panel driver")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the fix !
>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> Neil, I assume you will take this via next-fixes, which I think is the
> right tree at the moment.
Sure, but seems drm-misc-next-fixes is out of sync with drm-misc-next right now,
I'll apply it when it's sync'ed back.
Neil
>
> Sam
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add()
@ 2020-12-11 16:01 ` Neil Armstrong
0 siblings, 0 replies; 8+ messages in thread
From: Neil Armstrong @ 2020-12-11 16:01 UTC (permalink / raw)
To: Sam Ravnborg, Dan Carpenter
Cc: David Airlie, Thierry Reding, kernel-janitors, dri-devel
Hi All,
On 11/12/2020 12:01, Sam Ravnborg wrote:
> Hi Dan,
>
> I assume your nice tooling found this buggy.
> Nice!
>
> On Fri, Dec 11, 2020 at 01:05:50PM +0300, Dan Carpenter wrote:
>> There is a copy and paste bug so it didn't return the correct error
>> code.
>>
>> Fixes: b215212117f7 ("drm: panel: add Khadas TS050 panel driver")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the fix !
>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> Neil, I assume you will take this via next-fixes, which I think is the
> right tree at the moment.
Sure, but seems drm-misc-next-fixes is out of sync with drm-misc-next right now,
I'll apply it when it's sync'ed back.
Neil
>
> Sam
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-11 16:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-11 10:05 [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add() Dan Carpenter
2020-12-11 10:05 ` Dan Carpenter
2020-12-11 11:01 ` Sam Ravnborg
2020-12-11 11:01 ` Sam Ravnborg
2020-12-11 14:04 ` Dan Carpenter
2020-12-11 14:04 ` Dan Carpenter
2020-12-11 16:01 ` Neil Armstrong
2020-12-11 16:01 ` Neil Armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.