* fs/f2fs/compress.c:212 lzo_decompress_pages() warn: should '(((1)) << (13)) << dic->log_cluster_size' be a 64 bit
@ 2020-10-10 23:18 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-10-10 23:18 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 7154 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Chao Yu <yuchao0@huawei.com>, Chao Yu <chao@kernel.org>
CC: Jaegeuk Kim <jaegeuk@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 6f2f486d57c4d562cdf4932320b66fbb878ab1c4
commit: 4c8ff7095bef64fc47e996a938f7d57f9e077da3 f2fs: support data compression
date: 9 months ago
:::::: branch date: 22 hours ago
:::::: commit date: 9 months ago
config: arc-randconfig-m031-20201011 (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
fs/f2fs/compress.c:212 lzo_decompress_pages() warn: should '(((1)) << (13)) << dic->log_cluster_size' be a 64 bit type?
fs/f2fs/compress.c:276 lz4_decompress_pages() warn: should '(((1)) << (13)) << dic->log_cluster_size' be a 64 bit type?
Old smatch warnings:
arch/arc/include/asm/thread_info.h:65 current_thread_info() error: uninitialized symbol 'sp'.
vim +212 fs/f2fs/compress.c
4c8ff7095bef64f Chao Yu 2019-11-01 198
4c8ff7095bef64f Chao Yu 2019-11-01 199 static int lzo_decompress_pages(struct decompress_io_ctx *dic)
4c8ff7095bef64f Chao Yu 2019-11-01 200 {
4c8ff7095bef64f Chao Yu 2019-11-01 201 int ret;
4c8ff7095bef64f Chao Yu 2019-11-01 202
4c8ff7095bef64f Chao Yu 2019-11-01 203 ret = lzo1x_decompress_safe(dic->cbuf->cdata, dic->clen,
4c8ff7095bef64f Chao Yu 2019-11-01 204 dic->rbuf, &dic->rlen);
4c8ff7095bef64f Chao Yu 2019-11-01 205 if (ret != LZO_E_OK) {
4c8ff7095bef64f Chao Yu 2019-11-01 206 printk_ratelimited("%sF2FS-fs (%s): lzo decompress failed, ret:%d\n",
4c8ff7095bef64f Chao Yu 2019-11-01 207 KERN_ERR, F2FS_I_SB(dic->inode)->sb->s_id, ret);
4c8ff7095bef64f Chao Yu 2019-11-01 208 return -EIO;
4c8ff7095bef64f Chao Yu 2019-11-01 209 }
4c8ff7095bef64f Chao Yu 2019-11-01 210
4c8ff7095bef64f Chao Yu 2019-11-01 211 if (dic->rlen != PAGE_SIZE << dic->log_cluster_size) {
4c8ff7095bef64f Chao Yu 2019-11-01 @212 printk_ratelimited("%sF2FS-fs (%s): lzo invalid rlen:%zu, "
4c8ff7095bef64f Chao Yu 2019-11-01 213 "expected:%lu\n", KERN_ERR,
4c8ff7095bef64f Chao Yu 2019-11-01 214 F2FS_I_SB(dic->inode)->sb->s_id,
4c8ff7095bef64f Chao Yu 2019-11-01 215 dic->rlen,
4c8ff7095bef64f Chao Yu 2019-11-01 216 PAGE_SIZE << dic->log_cluster_size);
4c8ff7095bef64f Chao Yu 2019-11-01 217 return -EIO;
4c8ff7095bef64f Chao Yu 2019-11-01 218 }
4c8ff7095bef64f Chao Yu 2019-11-01 219 return 0;
4c8ff7095bef64f Chao Yu 2019-11-01 220 }
4c8ff7095bef64f Chao Yu 2019-11-01 221
4c8ff7095bef64f Chao Yu 2019-11-01 222 static const struct f2fs_compress_ops f2fs_lzo_ops = {
4c8ff7095bef64f Chao Yu 2019-11-01 223 .init_compress_ctx = lzo_init_compress_ctx,
4c8ff7095bef64f Chao Yu 2019-11-01 224 .destroy_compress_ctx = lzo_destroy_compress_ctx,
4c8ff7095bef64f Chao Yu 2019-11-01 225 .compress_pages = lzo_compress_pages,
4c8ff7095bef64f Chao Yu 2019-11-01 226 .decompress_pages = lzo_decompress_pages,
4c8ff7095bef64f Chao Yu 2019-11-01 227 };
4c8ff7095bef64f Chao Yu 2019-11-01 228 #endif
4c8ff7095bef64f Chao Yu 2019-11-01 229
4c8ff7095bef64f Chao Yu 2019-11-01 230 #ifdef CONFIG_F2FS_FS_LZ4
4c8ff7095bef64f Chao Yu 2019-11-01 231 static int lz4_init_compress_ctx(struct compress_ctx *cc)
4c8ff7095bef64f Chao Yu 2019-11-01 232 {
4c8ff7095bef64f Chao Yu 2019-11-01 233 cc->private = f2fs_kvmalloc(F2FS_I_SB(cc->inode),
4c8ff7095bef64f Chao Yu 2019-11-01 234 LZ4_MEM_COMPRESS, GFP_NOFS);
4c8ff7095bef64f Chao Yu 2019-11-01 235 if (!cc->private)
4c8ff7095bef64f Chao Yu 2019-11-01 236 return -ENOMEM;
4c8ff7095bef64f Chao Yu 2019-11-01 237
4c8ff7095bef64f Chao Yu 2019-11-01 238 cc->clen = LZ4_compressBound(PAGE_SIZE << cc->log_cluster_size);
4c8ff7095bef64f Chao Yu 2019-11-01 239 return 0;
4c8ff7095bef64f Chao Yu 2019-11-01 240 }
4c8ff7095bef64f Chao Yu 2019-11-01 241
4c8ff7095bef64f Chao Yu 2019-11-01 242 static void lz4_destroy_compress_ctx(struct compress_ctx *cc)
4c8ff7095bef64f Chao Yu 2019-11-01 243 {
4c8ff7095bef64f Chao Yu 2019-11-01 244 kvfree(cc->private);
4c8ff7095bef64f Chao Yu 2019-11-01 245 cc->private = NULL;
4c8ff7095bef64f Chao Yu 2019-11-01 246 }
4c8ff7095bef64f Chao Yu 2019-11-01 247
4c8ff7095bef64f Chao Yu 2019-11-01 248 static int lz4_compress_pages(struct compress_ctx *cc)
4c8ff7095bef64f Chao Yu 2019-11-01 249 {
4c8ff7095bef64f Chao Yu 2019-11-01 250 int len;
4c8ff7095bef64f Chao Yu 2019-11-01 251
4c8ff7095bef64f Chao Yu 2019-11-01 252 len = LZ4_compress_default(cc->rbuf, cc->cbuf->cdata, cc->rlen,
4c8ff7095bef64f Chao Yu 2019-11-01 253 cc->clen, cc->private);
4c8ff7095bef64f Chao Yu 2019-11-01 254 if (!len) {
4c8ff7095bef64f Chao Yu 2019-11-01 255 printk_ratelimited("%sF2FS-fs (%s): lz4 compress failed\n",
4c8ff7095bef64f Chao Yu 2019-11-01 256 KERN_ERR, F2FS_I_SB(cc->inode)->sb->s_id);
4c8ff7095bef64f Chao Yu 2019-11-01 257 return -EIO;
4c8ff7095bef64f Chao Yu 2019-11-01 258 }
4c8ff7095bef64f Chao Yu 2019-11-01 259 cc->clen = len;
4c8ff7095bef64f Chao Yu 2019-11-01 260 return 0;
4c8ff7095bef64f Chao Yu 2019-11-01 261 }
4c8ff7095bef64f Chao Yu 2019-11-01 262
4c8ff7095bef64f Chao Yu 2019-11-01 263 static int lz4_decompress_pages(struct decompress_io_ctx *dic)
4c8ff7095bef64f Chao Yu 2019-11-01 264 {
4c8ff7095bef64f Chao Yu 2019-11-01 265 int ret;
4c8ff7095bef64f Chao Yu 2019-11-01 266
4c8ff7095bef64f Chao Yu 2019-11-01 267 ret = LZ4_decompress_safe(dic->cbuf->cdata, dic->rbuf,
4c8ff7095bef64f Chao Yu 2019-11-01 268 dic->clen, dic->rlen);
4c8ff7095bef64f Chao Yu 2019-11-01 269 if (ret < 0) {
4c8ff7095bef64f Chao Yu 2019-11-01 270 printk_ratelimited("%sF2FS-fs (%s): lz4 decompress failed, ret:%d\n",
4c8ff7095bef64f Chao Yu 2019-11-01 271 KERN_ERR, F2FS_I_SB(dic->inode)->sb->s_id, ret);
4c8ff7095bef64f Chao Yu 2019-11-01 272 return -EIO;
4c8ff7095bef64f Chao Yu 2019-11-01 273 }
4c8ff7095bef64f Chao Yu 2019-11-01 274
4c8ff7095bef64f Chao Yu 2019-11-01 275 if (ret != PAGE_SIZE << dic->log_cluster_size) {
4c8ff7095bef64f Chao Yu 2019-11-01 @276 printk_ratelimited("%sF2FS-fs (%s): lz4 invalid rlen:%zu, "
4c8ff7095bef64f Chao Yu 2019-11-01 277 "expected:%lu\n", KERN_ERR,
4c8ff7095bef64f Chao Yu 2019-11-01 278 F2FS_I_SB(dic->inode)->sb->s_id,
4c8ff7095bef64f Chao Yu 2019-11-01 279 dic->rlen,
4c8ff7095bef64f Chao Yu 2019-11-01 280 PAGE_SIZE << dic->log_cluster_size);
4c8ff7095bef64f Chao Yu 2019-11-01 281 return -EIO;
4c8ff7095bef64f Chao Yu 2019-11-01 282 }
4c8ff7095bef64f Chao Yu 2019-11-01 283 return 0;
4c8ff7095bef64f Chao Yu 2019-11-01 284 }
4c8ff7095bef64f Chao Yu 2019-11-01 285
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30269 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* fs/f2fs/compress.c:212 lzo_decompress_pages() warn: should '(1 << 13) << dic->log_cluster_size' be a 64 bit
@ 2020-12-12 20:57 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-12-12 20:57 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2652 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Chao Yu <yuchao0@huawei.com>, Chao Yu <chao@kernel.org>
CC: Jaegeuk Kim <jaegeuk@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7b1b868e1d9156484ccce9bf11122c053de82617
commit: 4c8ff7095bef64fc47e996a938f7d57f9e077da3 f2fs: support data compression
date: 11 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 11 months ago
config: openrisc-randconfig-m031-20201213 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
fs/f2fs/compress.c:212 lzo_decompress_pages() warn: should '(1 << 13) << dic->log_cluster_size' be a 64 bit type?
vim +212 fs/f2fs/compress.c
4c8ff7095bef64f Chao Yu 2019-11-01 198
4c8ff7095bef64f Chao Yu 2019-11-01 199 static int lzo_decompress_pages(struct decompress_io_ctx *dic)
4c8ff7095bef64f Chao Yu 2019-11-01 200 {
4c8ff7095bef64f Chao Yu 2019-11-01 201 int ret;
4c8ff7095bef64f Chao Yu 2019-11-01 202
4c8ff7095bef64f Chao Yu 2019-11-01 203 ret = lzo1x_decompress_safe(dic->cbuf->cdata, dic->clen,
4c8ff7095bef64f Chao Yu 2019-11-01 204 dic->rbuf, &dic->rlen);
4c8ff7095bef64f Chao Yu 2019-11-01 205 if (ret != LZO_E_OK) {
4c8ff7095bef64f Chao Yu 2019-11-01 206 printk_ratelimited("%sF2FS-fs (%s): lzo decompress failed, ret:%d\n",
4c8ff7095bef64f Chao Yu 2019-11-01 207 KERN_ERR, F2FS_I_SB(dic->inode)->sb->s_id, ret);
4c8ff7095bef64f Chao Yu 2019-11-01 208 return -EIO;
4c8ff7095bef64f Chao Yu 2019-11-01 209 }
4c8ff7095bef64f Chao Yu 2019-11-01 210
4c8ff7095bef64f Chao Yu 2019-11-01 211 if (dic->rlen != PAGE_SIZE << dic->log_cluster_size) {
4c8ff7095bef64f Chao Yu 2019-11-01 @212 printk_ratelimited("%sF2FS-fs (%s): lzo invalid rlen:%zu, "
4c8ff7095bef64f Chao Yu 2019-11-01 213 "expected:%lu\n", KERN_ERR,
4c8ff7095bef64f Chao Yu 2019-11-01 214 F2FS_I_SB(dic->inode)->sb->s_id,
4c8ff7095bef64f Chao Yu 2019-11-01 215 dic->rlen,
4c8ff7095bef64f Chao Yu 2019-11-01 216 PAGE_SIZE << dic->log_cluster_size);
4c8ff7095bef64f Chao Yu 2019-11-01 217 return -EIO;
4c8ff7095bef64f Chao Yu 2019-11-01 218 }
4c8ff7095bef64f Chao Yu 2019-11-01 219 return 0;
4c8ff7095bef64f Chao Yu 2019-11-01 220 }
4c8ff7095bef64f Chao Yu 2019-11-01 221
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 20982 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-12 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-12 20:57 fs/f2fs/compress.c:212 lzo_decompress_pages() warn: should '(1 << 13) << dic->log_cluster_size' be a 64 bit kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2020-10-10 23:18 fs/f2fs/compress.c:212 lzo_decompress_pages() warn: should '(((1)) << (13)) " kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.