From: Catalin Marinas <catalin.marinas@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>,
Ionela Voinescu <ionela.voinescu@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: topology: Drop the useless update to per-cpu cycles
Date: Tue, 15 Dec 2020 12:30:20 +0000 [thread overview]
Message-ID: <20201215123019.GB2511@gaia> (raw)
In-Reply-To: <20201211064850.gsqsszwhxx5lzqgw@vireshk-i7>
On Fri, Dec 11, 2020 at 12:18:50PM +0530, Viresh Kumar wrote:
> On 10-12-20, 11:17, Viresh Kumar wrote:
> > The previous call to update_freq_counters_refs() has already updated the
> > per-cpu variables, don't overwrite them with the same value again.
> >
> > Fixes: 4b9cf23c179a ("arm64: wrap and generalise counter read functions")
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > arch/arm64/kernel/topology.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
> > index c8308befdb1e..f6faa697e83e 100644
> > --- a/arch/arm64/kernel/topology.c
> > +++ b/arch/arm64/kernel/topology.c
> > @@ -314,7 +314,7 @@ void topology_scale_freq_tick(void)
> >
> > if (unlikely(core_cnt <= prev_core_cnt ||
> > const_cnt <= prev_const_cnt))
> > - goto store_and_exit;
> > + return;
> >
> > /*
> > * /\core arch_max_freq_scale
> > @@ -331,10 +331,6 @@ void topology_scale_freq_tick(void)
> >
> > scale = min_t(unsigned long, scale, SCHED_CAPACITY_SCALE);
> > this_cpu_write(freq_scale, (unsigned long)scale);
> > -
> > -store_and_exit:
> > - this_cpu_write(arch_core_cycles_prev, core_cnt);
> > - this_cpu_write(arch_const_cycles_prev, const_cnt);
> > }
> >
> > #ifdef CONFIG_ACPI_CPPC_LIB
>
> Catalin: Can you please pick this up for 5.11-rc1, the earlier patch
> (from fixes) is already in your tree. Thanks.
I will add it to the second pull request this merging window. Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Will Deacon <will@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: topology: Drop the useless update to per-cpu cycles
Date: Tue, 15 Dec 2020 12:30:20 +0000 [thread overview]
Message-ID: <20201215123019.GB2511@gaia> (raw)
In-Reply-To: <20201211064850.gsqsszwhxx5lzqgw@vireshk-i7>
On Fri, Dec 11, 2020 at 12:18:50PM +0530, Viresh Kumar wrote:
> On 10-12-20, 11:17, Viresh Kumar wrote:
> > The previous call to update_freq_counters_refs() has already updated the
> > per-cpu variables, don't overwrite them with the same value again.
> >
> > Fixes: 4b9cf23c179a ("arm64: wrap and generalise counter read functions")
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > arch/arm64/kernel/topology.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
> > index c8308befdb1e..f6faa697e83e 100644
> > --- a/arch/arm64/kernel/topology.c
> > +++ b/arch/arm64/kernel/topology.c
> > @@ -314,7 +314,7 @@ void topology_scale_freq_tick(void)
> >
> > if (unlikely(core_cnt <= prev_core_cnt ||
> > const_cnt <= prev_const_cnt))
> > - goto store_and_exit;
> > + return;
> >
> > /*
> > * /\core arch_max_freq_scale
> > @@ -331,10 +331,6 @@ void topology_scale_freq_tick(void)
> >
> > scale = min_t(unsigned long, scale, SCHED_CAPACITY_SCALE);
> > this_cpu_write(freq_scale, (unsigned long)scale);
> > -
> > -store_and_exit:
> > - this_cpu_write(arch_core_cycles_prev, core_cnt);
> > - this_cpu_write(arch_const_cycles_prev, const_cnt);
> > }
> >
> > #ifdef CONFIG_ACPI_CPPC_LIB
>
> Catalin: Can you please pick this up for 5.11-rc1, the earlier patch
> (from fixes) is already in your tree. Thanks.
I will add it to the second pull request this merging window. Thanks.
--
Catalin
next prev parent reply other threads:[~2020-12-15 12:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 5:47 [PATCH] arm64: topology: Drop the useless update to per-cpu cycles Viresh Kumar
2020-12-10 5:47 ` Viresh Kumar
2020-12-10 9:37 ` Sudeep Holla
2020-12-10 9:37 ` Sudeep Holla
2020-12-10 9:57 ` Ionela Voinescu
2020-12-10 9:57 ` Ionela Voinescu
2020-12-11 6:48 ` Viresh Kumar
2020-12-11 6:48 ` Viresh Kumar
2020-12-15 12:30 ` Catalin Marinas [this message]
2020-12-15 12:30 ` Catalin Marinas
2020-12-15 17:44 ` Catalin Marinas
2020-12-15 17:44 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215123019.GB2511@gaia \
--to=catalin.marinas@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.