From: David Sterba <dsterba@suse.cz>
To: kernel test robot <lkp@intel.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
kbuild-all@lists.01.org, David Sterba <dsterba@suse.com>,
Nikolay Borisov <nborisov@suse.com>,
Chris Mason <chris.mason@fusionio.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix boolreturn.cocci warnings
Date: Tue, 15 Dec 2020 19:13:32 +0100 [thread overview]
Message-ID: <20201215181332.GC6430@twin.jikos.cz> (raw)
In-Reply-To: <20201101052051.GA16691@39d425248bd2>
On Sun, Nov 01, 2020 at 01:20:51PM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> fs/btrfs/space-info.c:810:9-10: WARNING: return of 0/1 in function 'need_preemptive_reclaim' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: fc96d3794eb2 ("btrfs: rename need_do_async_reclaim")
> CC: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
The patchset is still in a topic branch so I folded the change. There
were more int/bool mismatches in other patches, that got fixed too.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] btrfs: fix boolreturn.cocci warnings
Date: Tue, 15 Dec 2020 19:13:32 +0100 [thread overview]
Message-ID: <20201215181332.GC6430@twin.jikos.cz> (raw)
In-Reply-To: <20201101052051.GA16691@39d425248bd2>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Sun, Nov 01, 2020 at 01:20:51PM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> fs/btrfs/space-info.c:810:9-10: WARNING: return of 0/1 in function 'need_preemptive_reclaim' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: fc96d3794eb2 ("btrfs: rename need_do_async_reclaim")
> CC: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
The patchset is still in a topic branch so I folded the change. There
were more int/bool mismatches in other patches, that got fixed too.
next prev parent reply other threads:[~2020-12-15 18:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 5:20 [kdave-btrfs-devel:for-next-20201030 14921/14978] fs/btrfs/space-info.c:810:9-10: WARNING: return of 0/1 in function 'need_preemptive_reclaim' with return type bool kernel test robot
2020-11-01 5:20 ` [PATCH] btrfs: fix boolreturn.cocci warnings kernel test robot
2020-11-01 5:20 ` kernel test robot
2020-12-15 18:13 ` David Sterba [this message]
2020-12-15 18:13 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2021-01-30 6:49 [kdave-btrfs-devel:for-next-20210129 14784/14851] fs/btrfs/volumes.c:1462:10-11: WARNING: return of 0/1 in function 'dev_extent_hole_check_zoned' with return type bool kernel test robot
2021-01-30 6:49 ` [PATCH] btrfs: fix boolreturn.cocci warnings kernel test robot
2021-01-30 6:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215181332.GC6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.