From: kernel test robot <lkp@intel.com>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: kbuild-all@lists.01.org, David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
Chris Mason <chris.mason@fusionio.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] btrfs: fix boolreturn.cocci warnings
Date: Sat, 30 Jan 2021 14:49:27 +0800 [thread overview]
Message-ID: <20210130064927.GA96852@a09516cde295> (raw)
In-Reply-To: <202101301416.gmP3XmvI-lkp@intel.com>
From: kernel test robot <lkp@intel.com>
fs/btrfs/volumes.c:1462:10-11: WARNING: return of 0/1 in function 'dev_extent_hole_check_zoned' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 69e81c8e2824 ("btrfs: implement zoned chunk allocator")
CC: Naohiro Aota <naohiro.aota@wdc.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/kdave/btrfs-devel.git for-next-20210129
head: 6e043613b2c4377ce095ea826160d42031156d35
commit: 69e81c8e2824ec495071293cfebb74faca15e616 [14784/14851] btrfs: implement zoned chunk allocator
volumes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -1459,7 +1459,7 @@ static bool dev_extent_hole_check_zoned(
if (ret == -ERANGE) {
*hole_start += *hole_size;
*hole_size = 0;
- return 1;
+ return true;
}
*hole_start += zone_size;
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] btrfs: fix boolreturn.cocci warnings
Date: Sat, 30 Jan 2021 14:49:27 +0800 [thread overview]
Message-ID: <20210130064927.GA96852@a09516cde295> (raw)
In-Reply-To: <202101301416.gmP3XmvI-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
From: kernel test robot <lkp@intel.com>
fs/btrfs/volumes.c:1462:10-11: WARNING: return of 0/1 in function 'dev_extent_hole_check_zoned' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 69e81c8e2824 ("btrfs: implement zoned chunk allocator")
CC: Naohiro Aota <naohiro.aota@wdc.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/kdave/btrfs-devel.git for-next-20210129
head: 6e043613b2c4377ce095ea826160d42031156d35
commit: 69e81c8e2824ec495071293cfebb74faca15e616 [14784/14851] btrfs: implement zoned chunk allocator
volumes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -1459,7 +1459,7 @@ static bool dev_extent_hole_check_zoned(
if (ret == -ERANGE) {
*hole_start += *hole_size;
*hole_size = 0;
- return 1;
+ return true;
}
*hole_start += zone_size;
next prev parent reply other threads:[~2021-01-30 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 6:49 [kdave-btrfs-devel:for-next-20210129 14784/14851] fs/btrfs/volumes.c:1462:10-11: WARNING: return of 0/1 in function 'dev_extent_hole_check_zoned' with return type bool kernel test robot
2021-01-30 6:49 ` kernel test robot [this message]
2021-01-30 6:49 ` [PATCH] btrfs: fix boolreturn.cocci warnings kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2020-11-01 5:20 [kdave-btrfs-devel:for-next-20201030 14921/14978] fs/btrfs/space-info.c:810:9-10: WARNING: return of 0/1 in function 'need_preemptive_reclaim' with return type bool kernel test robot
2020-11-01 5:20 ` [PATCH] btrfs: fix boolreturn.cocci warnings kernel test robot
2020-11-01 5:20 ` kernel test robot
2020-12-15 18:13 ` David Sterba
2020-12-15 18:13 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210130064927.GA96852@a09516cde295 \
--to=lkp@intel.com \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.