All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [Intel-gfx] [PATCH v4 05/11] drm/i915: refactor some crtc code out of intel display.
@ 2020-12-16 16:07 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-12-16 16:07 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <72e2f24020bb18931b34f990372636e2c67ebd5d.1608117676.git.jani.nikula@intel.com>
References: <72e2f24020bb18931b34f990372636e2c67ebd5d.1608117676.git.jani.nikula@intel.com>
TO: Jani Nikula <jani.nikula@intel.com>
TO: intel-gfx(a)lists.freedesktop.org
CC: jani.nikula(a)intel.com
CC: Dave Airlie <airlied@redhat.com>

Hi Jani,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20201215]
[cannot apply to drm-tip/drm-tip v5.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-refactor-intel-display/20201216-194754
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: i386-randconfig-m021-20201216 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/i915/display/intel_crtc.c:869 intel_crtc_init() warn: passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +869 drivers/gpu/drm/i915/display/intel_crtc.c

48148b2af754d91 Dave Airlie 2020-12-16  859  
48148b2af754d91 Dave Airlie 2020-12-16  860  int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
48148b2af754d91 Dave Airlie 2020-12-16  861  {
48148b2af754d91 Dave Airlie 2020-12-16  862  	struct intel_plane *primary, *cursor;
48148b2af754d91 Dave Airlie 2020-12-16  863  	const struct drm_crtc_funcs *funcs;
48148b2af754d91 Dave Airlie 2020-12-16  864  	struct intel_crtc *crtc;
48148b2af754d91 Dave Airlie 2020-12-16  865  	int sprite, ret;
48148b2af754d91 Dave Airlie 2020-12-16  866  
48148b2af754d91 Dave Airlie 2020-12-16  867  	crtc = intel_crtc_alloc();
48148b2af754d91 Dave Airlie 2020-12-16  868  	if (IS_ERR(crtc))
48148b2af754d91 Dave Airlie 2020-12-16 @869  		return PTR_ERR(crtc);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32439 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [Intel-gfx] [PATCH v4 00/11] drm/i915: refactor intel display
@ 2020-12-16 11:29 Jani Nikula
  2020-12-16 11:29 ` [Intel-gfx] [PATCH v4 05/11] drm/i915: refactor some crtc code out of " Jani Nikula
  0 siblings, 1 reply; 2+ messages in thread
From: Jani Nikula @ 2020-12-16 11:29 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

This is Dave's intel_display.c refactoring series [1] with some minor
issues addressed, to get CI results among other things.

I've reviewed and fixed any remaining minor issues I spotted in patches
1-8. I'm aware there may be things to improve, but I think this is
overall forward progress and cleanup that's long overdue. I'm prepared
to merge patches 1-8 unless there are strong objections.

I ran out of steam a little with patches 9-11, and haven't reviewed
them. They're included here just for completeness.

BR,
Jani.


[1] https://patchwork.freedesktop.org/series/84812/


Dave Airlie (11):
  drm/i915/display: move needs_modeset to an inline in header
  drm/i915/display: move to_intel_frontbuffer to header
  drm/i915/display: fix misused comma
  drm/i915: refactor cursor code out of i915_display.c
  drm/i915: refactor some crtc code out of intel display.
  drm/i915: refactor pll code out into intel_dpll.c
  drm/i915: split fdi code out from intel_display.c
  drm/i915: migrate hsw fdi code to new file.
  drm/i915: migrate skl planes code new file
  drm/i915: move pipe update code into crtc.
  drm/i915: split fb scalable checks into g4x and skl versions

 drivers/gpu/drm/i915/Makefile                 |     5 +
 .../gpu/drm/i915/display/intel_atomic_plane.c |    76 -
 drivers/gpu/drm/i915/display/intel_crt.c      |     1 +
 drivers/gpu/drm/i915/display/intel_crtc.c     |  1187 +
 drivers/gpu/drm/i915/display/intel_crtc.h     |    22 +
 drivers/gpu/drm/i915/display/intel_cursor.c   |   806 +
 drivers/gpu/drm/i915/display/intel_cursor.h   |    17 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |   197 +-
 drivers/gpu/drm/i915/display/intel_ddi.h      |    14 +-
 drivers/gpu/drm/i915/display/intel_display.c  | 20019 ++++++----------
 drivers/gpu/drm/i915/display/intel_display.h  |    46 +-
 .../drm/i915/display/intel_display_types.h    |    55 +
 drivers/gpu/drm/i915/display/intel_dpll.c     |  1363 ++
 drivers/gpu/drm/i915/display/intel_dpll.h     |    23 +
 drivers/gpu/drm/i915/display/intel_fdi.c      |   857 +
 drivers/gpu/drm/i915/display/intel_fdi.h      |    29 +
 .../gpu/drm/i915/display/intel_gen9_plane.c   |  2832 +++
 drivers/gpu/drm/i915/display/intel_sprite.c   |  1712 +-
 18 files changed, 14739 insertions(+), 14522 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_crtc.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_crtc.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_cursor.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_cursor.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_dpll.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_dpll.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_fdi.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_fdi.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_gen9_plane.c

-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-16 16:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-16 16:07 [Intel-gfx] [PATCH v4 05/11] drm/i915: refactor some crtc code out of intel display kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-12-16 11:29 [Intel-gfx] [PATCH v4 00/11] drm/i915: refactor " Jani Nikula
2020-12-16 11:29 ` [Intel-gfx] [PATCH v4 05/11] drm/i915: refactor some crtc code out of " Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.