From: Nigel Christian <nigel.l.christian@gmail.com>
To: hverkuil-cisco@xs4all.nl, mchehab@kernel.org,
sakari.ailus@linux.intel.com, dan.carpenter@oracle.com,
gustavoars@kernel.org
Cc: linux-media@vger.kernel.org, trivial@kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] media: cec: fix trivial style warnings
Date: Fri, 18 Dec 2020 06:31:17 +0000 [thread overview]
Message-ID: <20201218063117.GA80700@fedora> (raw)
Comment has 'then' repeated twice. Let's clean it up.
Use unsigned int to maintain naming consistency.
Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
drivers/media/cec/core/cec-adap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c
index d5d5d28d0b36..79fa36de8a04 100644
--- a/drivers/media/cec/core/cec-adap.c
+++ b/drivers/media/cec/core/cec-adap.c
@@ -1296,7 +1296,7 @@ static int cec_config_log_addr(struct cec_adapter *adap,
/*
* If we are unable to get an OK or a NACK after max_retries attempts
* (and note that each attempt already consists of four polls), then
- * then we assume that something is really weird and that it is not a
+ * we assume that something is really weird and that it is not a
* good idea to try and claim this logical address.
*/
if (i = max_retries)
@@ -1735,7 +1735,7 @@ int __cec_s_log_addrs(struct cec_adapter *adap,
const u8 feature_sz = ARRAY_SIZE(log_addrs->features[0]);
u8 *features = log_addrs->features[i];
bool op_is_dev_features = false;
- unsigned j;
+ unsigned int j;
log_addrs->log_addr[i] = CEC_LOG_ADDR_INVALID;
if (log_addrs->log_addr_type[i] > CEC_LOG_ADDR_TYPE_UNREGISTERED) {
--
2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Nigel Christian <nigel.l.christian@gmail.com>
To: hverkuil-cisco@xs4all.nl, mchehab@kernel.org,
sakari.ailus@linux.intel.com, dan.carpenter@oracle.com,
gustavoars@kernel.org
Cc: linux-media@vger.kernel.org, trivial@kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] media: cec: fix trivial style warnings
Date: Fri, 18 Dec 2020 01:31:17 -0500 [thread overview]
Message-ID: <20201218063117.GA80700@fedora> (raw)
Comment has 'then' repeated twice. Let's clean it up.
Use unsigned int to maintain naming consistency.
Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
drivers/media/cec/core/cec-adap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c
index d5d5d28d0b36..79fa36de8a04 100644
--- a/drivers/media/cec/core/cec-adap.c
+++ b/drivers/media/cec/core/cec-adap.c
@@ -1296,7 +1296,7 @@ static int cec_config_log_addr(struct cec_adapter *adap,
/*
* If we are unable to get an OK or a NACK after max_retries attempts
* (and note that each attempt already consists of four polls), then
- * then we assume that something is really weird and that it is not a
+ * we assume that something is really weird and that it is not a
* good idea to try and claim this logical address.
*/
if (i == max_retries)
@@ -1735,7 +1735,7 @@ int __cec_s_log_addrs(struct cec_adapter *adap,
const u8 feature_sz = ARRAY_SIZE(log_addrs->features[0]);
u8 *features = log_addrs->features[i];
bool op_is_dev_features = false;
- unsigned j;
+ unsigned int j;
log_addrs->log_addr[i] = CEC_LOG_ADDR_INVALID;
if (log_addrs->log_addr_type[i] > CEC_LOG_ADDR_TYPE_UNREGISTERED) {
--
2.29.2
next reply other threads:[~2020-12-18 6:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 6:31 Nigel Christian [this message]
2020-12-18 6:31 ` [PATCH] media: cec: fix trivial style warnings Nigel Christian
2020-12-18 10:16 ` Dan Carpenter
2020-12-18 10:16 ` Dan Carpenter
2020-12-18 12:35 ` Nigel Christian
2020-12-18 12:35 ` Nigel Christian
2020-12-18 13:36 ` Dan Carpenter
2020-12-18 13:36 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218063117.GA80700@fedora \
--to=nigel.l.christian@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gustavoars@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.