From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nigel Christian <nigel.l.christian@gmail.com>
Cc: hverkuil-cisco@xs4all.nl, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gustavoars@kernel.org,
linux-media@vger.kernel.org, trivial@kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: cec: fix trivial style warnings
Date: Fri, 18 Dec 2020 13:36:31 +0000 [thread overview]
Message-ID: <20201218133631.GL2809@kadam> (raw)
In-Reply-To: <20201218123558.GA4088@fedora>
On Fri, Dec 18, 2020 at 07:35:58AM -0500, Nigel Christian wrote:
> On Fri, Dec 18, 2020 at 01:16:30PM +0300, Dan Carpenter wrote:
> > On Fri, Dec 18, 2020 at 01:31:17AM -0500, Nigel Christian wrote:
> > > Comment has 'then' repeated twice. Let's clean it up.
> > > Use unsigned int to maintain naming consistency.
> > >
> >
> > Do you use a tool to find the double "then then"?
> >
> > regards,
> > dan carpenter
> >
>
> Started working on nodejs script to run the 'checkpatch.pl -f'
> on directories and filter the output by command line arg.
Ah... I didn't realize that checkpatch could find this sort of thing.
Thanks!
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nigel Christian <nigel.l.christian@gmail.com>
Cc: hverkuil-cisco@xs4all.nl, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gustavoars@kernel.org,
linux-media@vger.kernel.org, trivial@kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: cec: fix trivial style warnings
Date: Fri, 18 Dec 2020 16:36:31 +0300 [thread overview]
Message-ID: <20201218133631.GL2809@kadam> (raw)
In-Reply-To: <20201218123558.GA4088@fedora>
On Fri, Dec 18, 2020 at 07:35:58AM -0500, Nigel Christian wrote:
> On Fri, Dec 18, 2020 at 01:16:30PM +0300, Dan Carpenter wrote:
> > On Fri, Dec 18, 2020 at 01:31:17AM -0500, Nigel Christian wrote:
> > > Comment has 'then' repeated twice. Let's clean it up.
> > > Use unsigned int to maintain naming consistency.
> > >
> >
> > Do you use a tool to find the double "then then"?
> >
> > regards,
> > dan carpenter
> >
>
> Started working on nodejs script to run the 'checkpatch.pl -f'
> on directories and filter the output by command line arg.
Ah... I didn't realize that checkpatch could find this sort of thing.
Thanks!
regards,
dan carpenter
next prev parent reply other threads:[~2020-12-18 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 6:31 [PATCH] media: cec: fix trivial style warnings Nigel Christian
2020-12-18 6:31 ` Nigel Christian
2020-12-18 10:16 ` Dan Carpenter
2020-12-18 10:16 ` Dan Carpenter
2020-12-18 12:35 ` Nigel Christian
2020-12-18 12:35 ` Nigel Christian
2020-12-18 13:36 ` Dan Carpenter [this message]
2020-12-18 13:36 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218133631.GL2809@kadam \
--to=dan.carpenter@oracle.com \
--cc=gustavoars@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nigel.l.christian@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.